luke/OpenSTA
1
0
Fork 0
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git synced 2026-09-03 08:25:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: remove empty if-bodies and meaningless status prints

Browse Source 
Negate conditions in empty if-body assertions so the FAIL message
is printed directly (e.g. `if { $x != 0 } { } else { puts FAIL }`
becomes `if { $x == 0 } { puts FAIL }`).  Remove dead if/else blocks
where both branches were empty, strip meaningless status-only puts
from Tcl tests and their .ok golden files, and wrap a long line in
search_report_gated_datacheck.tcl to stay within 80 columns.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Jaehyun Kim <[email protected]>
This commit is contained in:
Jaehyun Kim
2026-02-22 23:43:31 +09:00
co-authored by Claude Opus 4.6
parent a58d7e4cc6
commit e0f47a92f4
18 changed files with 30 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/test/util_pattern_string.tcl
+2 -4
View File
@@ -110,16 +110,14 @@ sta::set_debug "delay_calc" 0
puts "--- FileNotWritable error path ---"
# catch: intentionally testing FileNotWritable error for nonexistent directory
set rc [catch { write_sdf "/nonexistent_dir/no_write.sdf" } msg]
if { $rc != 0 } {
} else {
if { $rc == 0 } {
puts "INFO: no error for bad write path"
}
# Try write to read-only path
# catch: intentionally testing FileNotWritable error for /proc path
set rc [catch { log_begin "/proc/nonexistent_log" } msg]
if { $rc != 0 } {
} else {
if { $rc == 0 } {
log_end
puts "INFO: log_begin succeeded on /proc path"
}