luke
/
OpenSTA
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change DispatchQueue::dispatch to use notify_one. (#308) 

This prevents the thundering herd problem and should increase the
scalability of the DispatchQueue significantly.

Additionally the code the DispatchQueue was taken from made this
improvement five years ago:
79ad8a539d

Signed-off-by: Drew Lewis <cannada@google.com>
This commit is contained in:
Drew Lewis 2025-10-12 17:11:21 -04:00 committed by GitHub
parent 36e516924f
commit daeea4ab7e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/DispatchQueue.cc
View File

@ -66,7 +66,7 @@ DispatchQueue::dispatch(const fp_t& op)
// Manual unlocking is done before notifying, to avoid waking up // Manual unlocking is done before notifying, to avoid waking up
// the waiting thread only to block again (see notify_one for details) // the waiting thread only to block again (see notify_one for details)
lock.unlock(); lock.unlock();
cv_.notify_all(); cv_.notify_one();
} }
void void
@ -79,7 +79,7 @@ DispatchQueue::dispatch(fp_t&& op)
// Manual unlocking is done before notifying, to avoid waking up // Manual unlocking is done before notifying, to avoid waking up
// the waiting thread only to block again (see notify_one for details) // the waiting thread only to block again (see notify_one for details)
lock.unlock(); lock.unlock();
cv_.notify_all(); cv_.notify_one();
} }
void void