luke
/
OpenSTA
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert diff_files/diff_files_sorted to original return behavior 

Revert error-on-mismatch back to return 1, as the new GitHub Action
(github-actions-are-differences-found) now detects "Differences found"
in CI output, making the error approach unnecessary.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
This commit is contained in:
Jaehyun Kim 2026-04-07 23:42:21 +09:00
parent d19c99932f
commit 5fd751e8d7
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/helpers.tcl
View File

@ -56,10 +56,14 @@ proc diff_files_sorted { file1 file2 } {
} else { } else {
for {set i 0} {$i < [llength $lines1] && $i < [llength $lines2]} {incr i} { for {set i 0} {$i < [llength $lines1] && $i < [llength $lines2]} {incr i} {
if { [lindex $lines1 $i] ne [lindex $lines2 $i] } { if { [lindex $lines1 $i] ne [lindex $lines2 $i] } {
error "diff_files_sorted: $file1 vs $file2 differ at sorted line $i\n< [lindex $lines1 $i]\n> [lindex $lines2 $i]" puts "Differences found (sorted)."
puts "[lindex $lines1 $i]"
puts "[lindex $lines2 $i]"
return 1
} }
} }
error "diff_files_sorted: $file1 vs $file2 differ: file lengths differ" puts "Differences found (sorted): file lengths differ."
return 1
} }
} }
@ -102,7 +106,10 @@ proc diff_files { file1 file2 { ignore "" } } {
close $stream1 close $stream1
close $stream2 close $stream2
if { $found_diff || $line1_length != $line2_length } { if { $found_diff || $line1_length != $line2_length } {
error "diff_files: $file1 vs $file2 differ at line $line\n< $line1\n> $line2" puts "Differences found at line $line."
puts "$line1"
puts "$line2"
return 1
} else { } else {
puts "No differences found." puts "No differences found."
return 0 return 0