mirror of
https://github.com/The-OpenROAD-Project/OpenSTA.git
synced 2026-09-06 17:21:05 +02:00
test: Apply review feedback - part2
- Remove stale line-number coverage comments (# Targets: line NNN, hit=0) - Remove useless file-existence checks from verilog/sdf tests - Delete 21 orphaned dcalc Tcl tests (C++ tests already cover them) - Rename liberty_ccsn_ecsm -> liberty_ccsn (no ECSM libs available) - Fix liberty_sky130_corners to use define_corners/-corner for real multi-corner testing - Add report_checks per wireload model in liberty_wireload - Fix test/regression to work from test/ directory (label mismatch) - Refactor all module CMakeLists.txt with sta_module_tests() macro Co-Authored-By: Claude Opus 4.6 <[email protected]>
This commit is contained in:
Jaehyun Kim
co-authored by
Claude Opus 4.6
Claude Opus 4.6
parent
6799b1909a
commit
547737f71e
+28
-180
@@ -1,183 +1,31 @@
|
||||
add_test(
|
||||
NAME tcl.network.query
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_query
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
sta_module_tests("network"
|
||||
TESTS
|
||||
advanced
|
||||
bus_parse
|
||||
cell_match_merge
|
||||
connect_liberty
|
||||
connected_pins
|
||||
deep_modify
|
||||
escaped_names
|
||||
fanin_fanout
|
||||
find_cells_regex
|
||||
gcd_traversal
|
||||
hier_pin_query
|
||||
hierarchy
|
||||
leaf_iter
|
||||
merge_bus_hier
|
||||
modify
|
||||
multi_lib
|
||||
namespace_escape
|
||||
net_cap_query
|
||||
pattern_match
|
||||
properties
|
||||
query
|
||||
sdc_adapt_deep
|
||||
sdc_pattern_deep
|
||||
sdc_query
|
||||
sorting
|
||||
traversal
|
||||
)
|
||||
set_tests_properties(tcl.network.query PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.traversal
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_traversal
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.traversal PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.modify
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_modify
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.modify PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.advanced
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_advanced
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.advanced PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.properties
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_properties
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.properties PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.connect_liberty
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_connect_liberty
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.connect_liberty PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.bus_parse
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_bus_parse
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.bus_parse PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.pattern_match
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_pattern_match
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.pattern_match PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.sorting
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_sorting
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.sorting PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.hierarchy
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_hierarchy
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.hierarchy PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.sdc_query
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_sdc_query
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.sdc_query PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.deep_modify
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_deep_modify
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.deep_modify PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.leaf_iter
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_leaf_iter
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.leaf_iter PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.escaped_names
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_escaped_names
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.escaped_names PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.multi_lib
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_multi_lib
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.multi_lib PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.namespace_escape
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_namespace_escape
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.namespace_escape PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.net_cap_query
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_net_cap_query
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.net_cap_query PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.fanin_fanout
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_fanin_fanout
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.fanin_fanout PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.connected_pins
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_connected_pins
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.connected_pins PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.hier_pin_query
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_hier_pin_query
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.hier_pin_query PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.cell_match_merge
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_cell_match_merge
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.cell_match_merge PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.sdc_adapt_deep
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_sdc_adapt_deep
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.sdc_adapt_deep PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.merge_bus_hier
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_merge_bus_hier
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.merge_bus_hier PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.sdc_pattern_deep
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_sdc_pattern_deep
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.sdc_pattern_deep PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.gcd_traversal
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_gcd_traversal
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.gcd_traversal PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_test(
|
||||
NAME tcl.network.find_cells_regex
|
||||
COMMAND bash ${STA_HOME}/test/regression.sh $<TARGET_FILE:sta> network_find_cells_regex
|
||||
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
)
|
||||
set_tests_properties(tcl.network.find_cells_regex PROPERTIES LABELS "tcl;module_network")
|
||||
|
||||
add_subdirectory(cpp)
|
||||
|
||||
@@ -1,9 +1,4 @@
|
||||
# Test advanced network operations for coverage improvement
|
||||
# Targets: Network.cc uncovered functions (instanceCount, pinCount, netCount,
|
||||
# leafInstanceCount, leafPinCount, leafInstances, setPathDivider, setPathEscape,
|
||||
# findNet, findPin, pathNameTerm, checkLibertyCells, connectedNets, isInside, etc.)
|
||||
# Also targets: NetworkCmp.cc (sortByPathName for instances/nets), PortDirection.cc
|
||||
|
||||
read_liberty ../../test/nangate45/Nangate45_typ.lib
|
||||
read_verilog network_test1.v
|
||||
link_design network_test1
|
||||
|
||||
@@ -1,13 +1,4 @@
|
||||
# Test network modify operations using liberty cell references
|
||||
# Targets: ConcreteNetwork.cc uncovered functions:
|
||||
# - connect(Instance, LibertyPort, Net) - line 1367 hit=0
|
||||
# - mergeInto(Net, Net) - line 1203 hit=0
|
||||
# - addConstantNet - line 1541 hit=0
|
||||
# - clearConstantNets - line 1534 hit=0
|
||||
# - clear - line 273 hit=0
|
||||
# Also tests: Network.cc (findInstancesMatching, findNetsMatchingLinear,
|
||||
# findPinsMatching, leafInstanceIterator(inst), etc.)
|
||||
|
||||
read_liberty ../../test/nangate45/Nangate45_typ.lib
|
||||
read_verilog network_test1.v
|
||||
link_design network_test1
|
||||
|
||||
@@ -1,20 +1,4 @@
|
||||
# Test pattern matching functions for coverage improvement
|
||||
# Targets: Network.cc uncovered functions:
|
||||
# findNetsMatching (line 914, hit=0), findNetsMatchingLinear (line 977, hit=0),
|
||||
# findPinsMatching (line 992, hit=0), findInstPinsMatching (line 1066, hit=0),
|
||||
# findInstancesMatching (line 724, hit=0), findInstancesMatching1 (line 744, hit=0),
|
||||
# findNetLinear (line 898, hit=0), findPinLinear (line 839, hit=0),
|
||||
# connectedNets(Pin) (line 580, hit=0),
|
||||
# pathNameLess(Instance) (line 287, hit=0), pathNameLess(Net) (line 486, hit=0),
|
||||
# pathNameCmp(Net) (line 493, hit=0),
|
||||
# isInside(Instance) (line 344, hit=0), isInside(Net) (line 416, hit=0),
|
||||
# isInside(Pin, Instance) (line 448, hit=0), isInside(Pin, Pin) (line 441, hit=0),
|
||||
# instanceCount (line 1098, 1111, hit=0), pinCount (line 1117, 1137, hit=0),
|
||||
# netCount (line 1143, 1163, hit=0), leafInstanceCount (line 1169, hit=0),
|
||||
# leafPinCount (line 1182, hit=0)
|
||||
# Also targets: SdcNetwork.cc (findNet, busName)
|
||||
# NetworkCmp.cc (InstancePathNameLess, NetPathNameLess, sortByPathName for Instances/Nets)
|
||||
|
||||
read_liberty ../../test/nangate45/Nangate45_typ.lib
|
||||
read_verilog network_test1.v
|
||||
link_design network_test1
|
||||
|
||||
@@ -1,10 +1,4 @@
|
||||
# Test network property queries and edge cases for coverage improvement
|
||||
# Targets: ConcreteNetwork.cc (getAttribute, attributeMap, bus ports, cell properties,
|
||||
# id, groupBusPorts, isBundle, portBitCount, fromIndex/toIndex, filename, setName, etc.)
|
||||
# Targets: Network.cc (instanceCount, pinCount, netCount, leafInstanceCount,
|
||||
# leafPinCount, connectedNets, isInside, pathNameNet, pathNameTerm, etc.)
|
||||
# Targets: SdcNetwork.cc (findNet, busName, various uncovered adapter functions)
|
||||
|
||||
#---------------------------------------------------------------
|
||||
# Use ASAP7 design which has bus ports for bus coverage
|
||||
#---------------------------------------------------------------
|
||||
|
||||
@@ -1,17 +1,4 @@
|
||||
# Test network comparison and sorting operations
|
||||
# Targets: NetworkCmp.cc uncovered functions:
|
||||
# InstancePathNameLess (line 71-81, hit=0)
|
||||
# NetPathNameLess::operator() (line 65-68, hit=0)
|
||||
# PortNameLess::operator() (line 41-44, hit=0)
|
||||
# sortByPathName(InstanceSet) (line 108-116, hit=0)
|
||||
# sortByPathName(NetSet) (line 119-127, hit=0)
|
||||
# Also targets: Network.cc
|
||||
# pathNameLess(Instance) (line 287, hit=0), pathNameCmp(Instance) (line 294)
|
||||
# pathNameLess(Net) (line 486, hit=0), pathNameCmp(Net) (line 493, hit=0)
|
||||
# instanceCount, pinCount, netCount, leafInstanceCount, leafPinCount
|
||||
# setPathDivider (line 1213, hit=0), setPathEscape (line 1219, hit=0)
|
||||
# leafInstanceIterator(Instance) (line 1297, hit=0)
|
||||
|
||||
read_liberty ../../test/nangate45/Nangate45_typ.lib
|
||||
read_verilog network_test1.v
|
||||
link_design network_test1
|
||||
|
||||
Reference in New Issue
Block a user