Klockwork warnings

Signed-off-by: James Cherry <[email protected]>
This commit is contained in:
James Cherry
2022-01-15 12:51:05 -07:00
parent bb36b3cb31
commit 16f3f94b5b
33 changed files with 688 additions and 562 deletions
+1 -1
View File
@@ -1197,7 +1197,7 @@ ConcreteParasitics::findPiPoleResidue(const Pin *drvr_pin,
ap_rf_index = parasiticAnalysisPtIndex(ap, RiseFall::rise());
parasitic = parasitics[ap_rf_index];
}
if (parasitic->isPiPoleResidue())
if (parasitic && parasitic->isPiPoleResidue())
return parasitic;
}
}
+13 -11
View File
@@ -314,7 +314,7 @@ SpefReader::nameMapLookup(char *name)
return mapped_name;
else {
warn(169, "no name map entry for %d.", index);
return 0;
return nullptr;
}
}
else
@@ -351,17 +351,19 @@ SpefReader::findPin(char *name)
if (delim) {
*delim = '\0';
name = nameMapLookup(name);
Instance *inst = findInstanceRelative(name);
// Replace delimiter for error messages.
*delim = delimiter_;
const char *port_name = delim + 1;
if (inst) {
pin = network_->findPin(inst, port_name);
if (pin == nullptr)
warn(171, "pin %s not found.", name);
if (name) {
Instance *inst = findInstanceRelative(name);
// Replace delimiter for error messages.
*delim = delimiter_;
const char *port_name = delim + 1;
if (inst) {
pin = network_->findPin(inst, port_name);
if (pin == nullptr)
warn(171, "pin %s not found.", name);
}
else
warn(172, "instance %s not found.", name);
}
else
warn(172, "instance %s not found.", name);
}
else {
pin = findPortPinRelative(name);