luke/OpenSTA
1
0
Fork 0
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git synced 2026-09-01 18:36:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Strengthen C++ test assertions with meaningful checks

Browse Source 
Replace empty-body checks and trivial file-existence assertions with
actual content verification and state validation in C++ unit tests.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Jaehyun Kim <[email protected]>
This commit is contained in:
Jaehyun Kim
2026-02-22 18:52:36 +09:00
co-authored by Claude Opus 4.6
parent e5d8d8c970
commit 0693e7d479
3 changed files with 84 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spice/test/cpp/TestSpice.cc
+4 -2
View File
@@ -1775,8 +1775,10 @@ TEST_F(SpiceDesignTest, HoldTimingPaths) {
10, 1, false, false, -INF, INF, false, nullptr,
false, true, false, false, false, false
);
// Hold paths should exist for the constrained design
EXPECT_GE(path_ends.size(), 0u);
// Hold paths should exist for the constrained design.
ASSERT_FALSE(path_ends.empty());
ASSERT_NE(path_ends[0], nullptr);
EXPECT_NE(path_ends[0]->path(), nullptr);
}
// Verify clock can be found for SPICE waveform generation