luke
/
OpenRAM
mirror of https://github.com/VLSIDA/OpenRAM.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removing we_b signal from write ports since it is redundant.

This commit is contained in:
Michael Timothy Grimes 2018-10-04 09:31:04 -07:00
parent 34d8a19871
commit e258199fa3
4 changed files with 60 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler/modules/bank.py
View File

@ -249,8 +249,8 @@ class bank(design.design):
for port in range(self.total_ports): for port in range(self.total_ports):
self.column_mux_array.append(self.mod_column_mux_array(columns=self.num_cols, self.column_mux_array.append(self.mod_column_mux_array(columns=self.num_cols,
word_size=self.word_size, word_size=self.word_size,
bitcell_bl=self.read_bl_list[port], bitcell_bl=self.total_bl_list[port],
bitcell_br=self.read_br_list[port])) bitcell_br=self.total_br_list[port]))
self.add_mod(self.column_mux_array[port]) self.add_mod(self.column_mux_array[port])

79
compiler/modules/control_logic.py
View File

@ -18,19 +18,19 @@ class control_logic(design.design):
Dynamically generated Control logic for the total SRAM circuit. Dynamically generated Control logic for the total SRAM circuit.
""" """
def __init__(self, num_rows, port="rw"): def __init__(self, num_rows, port_type="rw"):
""" Constructor """ """ Constructor """
name = "control_logic_" + port name = "control_logic_" + port_type
design.design.__init__(self, name) design.design.__init__(self, name)
debug.info(1, "Creating {}".format(name)) debug.info(1, "Creating {}".format(name))
self.num_rows = num_rows self.num_rows = num_rows
self.port = port self.port_type = port_type
if self.port == "r": if self.port_type == "rw":
self.num_control_signals = 1
else:
self.num_control_signals = 2 self.num_control_signals = 2
else:
self.num_control_signals = 1
self.create_netlist() self.create_netlist()
if not OPTS.netlist_only: if not OPTS.netlist_only:
@ -88,7 +88,7 @@ class control_logic(design.design):
self.inv8 = pinv(size=16, height=dff_height) self.inv8 = pinv(size=16, height=dff_height)
self.add_mod(self.inv8) self.add_mod(self.inv8)
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
from importlib import reload from importlib import reload
c = reload(__import__(OPTS.replica_bitline)) c = reload(__import__(OPTS.replica_bitline))
replica_bitline = getattr(c, OPTS.replica_bitline) replica_bitline = getattr(c, OPTS.replica_bitline)
@ -96,7 +96,7 @@ class control_logic(design.design):
delay_stages = 4 # Must be non-inverting delay_stages = 4 # Must be non-inverting
delay_fanout = 3 # This can be anything >=2 delay_fanout = 3 # This can be anything >=2
bitcell_loads = int(math.ceil(self.num_rows / 5.0)) bitcell_loads = int(math.ceil(self.num_rows / 5.0))
self.replica_bitline = replica_bitline(delay_stages, delay_fanout, bitcell_loads, name="replica_bitline_"+self.port) self.replica_bitline = replica_bitline(delay_stages, delay_fanout, bitcell_loads, name="replica_bitline_"+self.port_type)
self.add_mod(self.replica_bitline) self.add_mod(self.replica_bitline)
@ -104,28 +104,28 @@ class control_logic(design.design):
""" Setup bus names, determine the size of the busses etc """ """ Setup bus names, determine the size of the busses etc """
# List of input control signals # List of input control signals
if self.port == "r": if self.port_type == "rw":
self.input_list =["csb"] self.input_list = ["csb", "web"]
else: else:
self.input_list =["csb", "web"] self.input_list = ["csb"]
if self.port == "r": if self.port_type == "rw":
self.dff_output_list =["cs_bar", "cs"] self.dff_output_list = ["cs_bar", "cs", "we_bar", "we"]
else: else:
self.dff_output_list =["cs_bar", "cs", "we_bar", "we"] self.dff_output_list = ["cs_bar", "cs"]
# list of output control signals (for making a vertical bus) # list of output control signals (for making a vertical bus)
if self.port == "r": if self.port_type == "rw":
self.internal_bus_list = ["clk_buf", "clk_buf_bar", "cs"]
else:
self.internal_bus_list = ["clk_buf", "clk_buf_bar", "we", "cs"] self.internal_bus_list = ["clk_buf", "clk_buf_bar", "we", "cs"]
else:
self.internal_bus_list = ["clk_buf", "clk_buf_bar", "cs"]
# leave space for the bus plus one extra space # leave space for the bus plus one extra space
self.internal_bus_width = (len(self.internal_bus_list)+1)*self.m2_pitch self.internal_bus_width = (len(self.internal_bus_list)+1)*self.m2_pitch
# Outputs to the bank # Outputs to the bank
if self.port == "r": if self.port_type == "r":
self.output_list = ["s_en"] self.output_list = ["s_en"]
elif self.port == "w": elif self.port_type == "w":
self.output_list = ["w_en"] self.output_list = ["w_en"]
else: else:
self.output_list = ["s_en", "w_en"] self.output_list = ["s_en", "w_en"]
@ -147,9 +147,9 @@ class control_logic(design.design):
""" Create all the modules """ """ Create all the modules """
self.create_dffs() self.create_dffs()
self.create_clk_row() self.create_clk_row()
if (self.port == "rw") or (self.port == "w"): if (self.port_type == "rw") or (self.port_type == "w"):
self.create_we_row() self.create_we_row()
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
self.create_rbl_in_row() self.create_rbl_in_row()
self.create_sen_row() self.create_sen_row()
self.create_rbl() self.create_rbl()
@ -168,12 +168,12 @@ class control_logic(design.design):
# Add the logic on the right of the bus # Add the logic on the right of the bus
self.place_clk_row(row=row) # clk is a double-high cell self.place_clk_row(row=row) # clk is a double-high cell
row += 2 row += 2
if (self.port == "rw") or (self.port == "w"): if (self.port_type == "rw") or (self.port_type == "w"):
self.place_we_row(row=row) self.place_we_row(row=row)
pre_height = self.w_en_inst.uy() pre_height = self.w_en_inst.uy()
control_center_y = self.w_en_inst.by() control_center_y = self.w_en_inst.by()
row += 1 row += 1
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
self.place_rbl_in_row(row=row) self.place_rbl_in_row(row=row)
self.place_sen_row(row=row+1) self.place_sen_row(row=row+1)
self.place_rbl(row=row+2) self.place_rbl(row=row+2)
@ -186,7 +186,7 @@ class control_logic(design.design):
# Extra pitch on top and right # Extra pitch on top and right
self.height = pre_height + self.m3_pitch self.height = pre_height + self.m3_pitch
# Max of modules or logic rows # Max of modules or logic rows
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
self.width = max(self.rbl_inst.rx(), max([inst.rx() for inst in self.row_end_inst])) + self.m2_pitch self.width = max(self.rbl_inst.rx(), max([inst.rx() for inst in self.row_end_inst])) + self.m2_pitch
else: else:
self.width = max([inst.rx() for inst in self.row_end_inst]) + self.m2_pitch self.width = max([inst.rx() for inst in self.row_end_inst]) + self.m2_pitch
@ -194,9 +194,9 @@ class control_logic(design.design):
def route_all(self): def route_all(self):
""" Routing between modules """ """ Routing between modules """
self.route_dffs() self.route_dffs()
if (self.port == "rw") or (self.port == "w"): if (self.port_type == "rw") or (self.port_type == "w"):
self.route_wen() self.route_wen()
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
self.route_rbl_in() self.route_rbl_in()
self.route_sen() self.route_sen()
self.route_clk() self.route_clk()
@ -295,7 +295,7 @@ class control_logic(design.design):
def route_dffs(self): def route_dffs(self):
""" Route the input inverters """ """ Route the input inverters """
if self.port == "r": if self.port_type == "r":
control_inputs = ["cs"] control_inputs = ["cs"]
else: else:
control_inputs = ["cs", "we"] control_inputs = ["cs", "we"]
@ -312,7 +312,7 @@ class control_logic(design.design):
rotate=90) rotate=90)
self.copy_layout_pin(self.ctrl_dff_inst, "din[0]", "csb") self.copy_layout_pin(self.ctrl_dff_inst, "din[0]", "csb")
if (self.port == "rw") or (self.port == "w"): if (self.port_type == "rw"):
self.copy_layout_pin(self.ctrl_dff_inst, "din[1]", "web") self.copy_layout_pin(self.ctrl_dff_inst, "din[1]", "web")
@ -340,9 +340,16 @@ class control_logic(design.design):
def create_we_row(self): def create_we_row(self):
# input: WE, CS output: w_en_bar # input: WE, CS output: w_en_bar
if self.port_type == "rw":
nand_mod = self.nand3
temp = ["clk_buf_bar", "cs", "we", "w_en_bar", "vdd", "gnd"]
else:
nand_mod = self.nand2
temp = ["clk_buf_bar", "cs", "w_en_bar", "vdd", "gnd"]
self.w_en_bar_inst = self.add_inst(name="nand3_w_en_bar", self.w_en_bar_inst = self.add_inst(name="nand3_w_en_bar",
mod=self.nand3) mod=nand_mod)
self.connect_inst(["clk_buf_bar", "cs", "we", "w_en_bar", "vdd", "gnd"]) self.connect_inst(temp)
# input: w_en_bar, output: pre_w_en # input: w_en_bar, output: pre_w_en
self.pre_w_en_inst = self.add_inst(name="inv_pre_w_en", self.pre_w_en_inst = self.add_inst(name="inv_pre_w_en",
@ -366,7 +373,10 @@ class control_logic(design.design):
w_en_bar_offset = vector(x_off, y_off) w_en_bar_offset = vector(x_off, y_off)
self.w_en_bar_inst.place(offset=w_en_bar_offset, self.w_en_bar_inst.place(offset=w_en_bar_offset,
mirror=mirror) mirror=mirror)
x_off += self.nand3.width if self.port_type == "rw":
x_off += self.nand3.width
else:
x_off += self.nand2.width
pre_w_en_offset = vector(x_off, y_off) pre_w_en_offset = vector(x_off, y_off)
self.pre_w_en_inst.place(offset=pre_w_en_offset, self.pre_w_en_inst.place(offset=pre_w_en_offset,
@ -460,7 +470,10 @@ class control_logic(design.design):
def route_wen(self): def route_wen(self):
wen_map = zip(["A", "B", "C"], ["clk_buf_bar", "cs", "we"]) if self.port_type == "rw":
wen_map = zip(["A", "B", "C"], ["clk_buf_bar", "cs", "we"])
else:
wen_map = zip(["A", "B"], ["clk_buf_bar", "cs"])
self.connect_vertical_bus(wen_map, self.w_en_bar_inst, self.rail_offsets) self.connect_vertical_bus(wen_map, self.w_en_bar_inst, self.rail_offsets)
# Connect the NAND3 output to the inverter # Connect the NAND3 output to the inverter
@ -536,7 +549,7 @@ class control_logic(design.design):
self.add_power_pin("gnd", pin_loc) self.add_power_pin("gnd", pin_loc)
self.add_path("metal1", [row_loc, pin_loc]) self.add_path("metal1", [row_loc, pin_loc])
if (self.port == "rw") or (self.port == "r"): if (self.port_type == "rw") or (self.port_type == "r"):
self.copy_layout_pin(self.rbl_inst,"gnd") self.copy_layout_pin(self.rbl_inst,"gnd")
self.copy_layout_pin(self.rbl_inst,"vdd") self.copy_layout_pin(self.rbl_inst,"vdd")

10
compiler/sram_base.py
View File

@ -48,7 +48,7 @@ class sram_base(design):
for port in range(self.total_ports): for port in range(self.total_ports):
self.add_pin("csb{}".format(port),"INPUT") self.add_pin("csb{}".format(port),"INPUT")
for port in range(self.total_write): for port in range(self.num_rw_ports):
self.add_pin("web{}".format(port),"INPUT") self.add_pin("web{}".format(port),"INPUT")
for port in range(self.total_ports): for port in range(self.total_ports):
self.add_pin("clk{}".format(port),"INPUT") self.add_pin("clk{}".format(port),"INPUT")
@ -231,13 +231,13 @@ class sram_base(design):
from control_logic import control_logic from control_logic import control_logic
# Create the control logic module for each port type # Create the control logic module for each port type
if OPTS.num_rw_ports>0: if OPTS.num_rw_ports>0:
self.control_logic = self.control_logic_rw = control_logic(num_rows=self.num_rows, port="rw") self.control_logic = self.control_logic_rw = control_logic(num_rows=self.num_rows, port_type="rw")
self.add_mod(self.control_logic_rw) self.add_mod(self.control_logic_rw)
if OPTS.num_w_ports>0: if OPTS.num_w_ports>0:
self.control_logic_w = control_logic(num_rows=self.num_rows, port="w") self.control_logic_w = control_logic(num_rows=self.num_rows, port_type="w")
self.add_mod(self.control_logic_w) self.add_mod(self.control_logic_w)
if OPTS.num_r_ports>0: if OPTS.num_r_ports>0:
self.control_logic_r = control_logic(num_rows=self.num_rows, port="r") self.control_logic_r = control_logic(num_rows=self.num_rows, port_type="r")
self.add_mod(self.control_logic_r) self.add_mod(self.control_logic_r)
# Create the address and control flops (but not the clk) # Create the address and control flops (but not the clk)
@ -404,7 +404,7 @@ class sram_base(design):
mod=mod)) mod=mod))
temp = ["csb{}".format(port)] temp = ["csb{}".format(port)]
if (self.port_id[port] == "rw") or (self.port_id[port] == "w"): if self.port_id[port] == "rw":
temp.append("web{}".format(port)) temp.append("web{}".format(port))
temp.append("clk{}".format(port)) temp.append("clk{}".format(port))
if (self.port_id[port] == "rw") or (self.port_id[port] == "r"): if (self.port_id[port] == "rw") or (self.port_id[port] == "r"):

10
compiler/tests/16_control_logic_test.py
View File

@ -34,17 +34,21 @@ class control_logic_test(openram_test):
a = control_logic.control_logic(num_rows=128) a = control_logic.control_logic(num_rows=128)
self.local_check(a) self.local_check(a)
# Check write-only and read-only control logic # Check port specific control logic
OPTS.num_rw_ports = 1 OPTS.num_rw_ports = 1
OPTS.num_w_ports = 1 OPTS.num_w_ports = 1
OPTS.num_r_ports = 1 OPTS.num_r_ports = 1
debug.info(1, "Testing sample for control_logic for multiport, only write control logic") debug.info(1, "Testing sample for control_logic for multiport, only write control logic")
a = control_logic.control_logic(num_rows=128, port="w") a = control_logic.control_logic(num_rows=128, port_type="rw")
self.local_check(a)
debug.info(1, "Testing sample for control_logic for multiport, only write control logic")
a = control_logic.control_logic(num_rows=128, port_type="w")
self.local_check(a) self.local_check(a)
debug.info(1, "Testing sample for control_logic for multiport, only read control logic") debug.info(1, "Testing sample for control_logic for multiport, only read control logic")
a = control_logic.control_logic(num_rows=128, port="r") a = control_logic.control_logic(num_rows=128, port_type="r")
self.local_check(a) self.local_check(a)
globals.end_openram() globals.end_openram()