Remove dynamic bitcell multiple detection.

Check for decoder bitcell multiple in tech file or assume 1.
PEP8 fixes.

compiler/globals.py

@@ -589,4 +589,4 @@ def report_status():
         if OPTS.trim_netlist:
             debug.print_raw("Trimming netlist to speed up characterization (trim_netlist=False to disable).")
     if OPTS.nominal_corner_only:
-        debug.print_raw("Only characterizing nominal corner.")        
+        debug.print_raw("Only characterizing nominal corner.")

compiler/modules/hierarchical_decoder.py

@@ -12,6 +12,7 @@ from sram_factory import factory
 from vector import vector
 from globals import OPTS
 from errors import drc_error
+from tech import cell_properties
 
 
 class hierarchical_decoder(design.design):
@@ -26,7 +27,13 @@ class hierarchical_decoder(design.design):
         self.pre2x4_inst = []
         self.pre3x8_inst = []
 
-        (self.cell_height, self.cell_multiple) = self.find_decoder_height()
+        b = factory.create(module_type="bitcell")
+        try:
+            self.cell_multiple = cell_properties.bitcell.decoder_bitcell_multiple
+        except AttributeError:
+            self.cell_multiple = 1
+        self.cell_height = self.cell_multiple * b.height
+        
         self.num_outputs = num_outputs
         # We may have more than one bitcell per decoder row
         self.rows = math.ceil(num_outputs / self.cell_multiple)
@@ -38,11 +45,12 @@ class hierarchical_decoder(design.design):
             self.create_layout()
 
     def find_decoder_height(self):
-            
+        """
+        Dead code. This would dynamically determine the bitcell multiple,
+        but I just decided to hard code it in the tech file if it is not 1
+        because a DRC tool would be required even to run in front-end mode.
+        """
         b = factory.create(module_type="bitcell")
-        # Old behavior
-        if OPTS.netlist_only:
-            return (b.height, 1)
 
         # Search for the smallest multiple that works
         cell_multiple = 1

compiler/tests/30_openram_back_end_test.py

@@ -51,7 +51,7 @@ class openram_back_end_test(openram_test):
             debug.warning("Failed to find coverage installation. This can be installed with pip3 install coverage")
             exe_name = "{0}/openram.py ".format(OPENRAM_HOME)
         else:
-            exe_name = "coverage run -p {0}/openram.py ".format(OPENRAM_HOME) 
+            exe_name = "coverage run -p {0}/openram.py ".format(OPENRAM_HOME)
         config_name = "{0}/tests/configs/config_back_end.py".format(OPENRAM_HOME)
         cmd = "{0} -n -o {1} -p {2} {3} {4} 2>&1 > {5}/output.log".format(exe_name,
                                                                           out_file,
@@ -64,33 +64,32 @@ class openram_back_end_test(openram_test):
         
         # assert an error until we actually check a resul
         for extension in ["gds", "v", "lef", "sp"]:
-            filename = "{0}/{1}.{2}".format(out_path,out_file,extension)
+            filename = "{0}/{1}.{2}".format(out_path, out_file, extension)
-            debug.info(1,"Checking for file: " + filename)
+            debug.info(1, "Checking for file: " + filename)
-            self.assertEqual(os.path.exists(filename),True)
+            self.assertEqual(os.path.exists(filename), True)
 
         # Make sure there is any .lib file
         import glob
         files = glob.glob('{0}/*.lib'.format(out_path))
         self.assertTrue(len(files)>0)
         
-        # Make sure there is any .html file 
+        # Make sure there is any .html file
         if os.path.exists(out_path):
             datasheets = glob.glob('{0}/*html'.format(out_path))
             self.assertTrue(len(datasheets)>0)
         
         # grep any errors from the output
-        output_log = open("{0}/output.log".format(out_path),"r")
+        output_log = open("{0}/output.log".format(out_path), "r")
         output = output_log.read()
         output_log.close()
-        self.assertEqual(len(re.findall('ERROR',output)),0)
+        self.assertEqual(len(re.findall('ERROR', output)), 0)
-        self.assertEqual(len(re.findall('WARNING',output)),0)
+        self.assertEqual(len(re.findall('WARNING', output)), 0)
-
 
         # now clean up the directory
         if OPTS.purge_temp:
             if os.path.exists(out_path):
                 shutil.rmtree(out_path, ignore_errors=True)
-            self.assertEqual(os.path.exists(out_path),False)
+            self.assertEqual(os.path.exists(out_path), False)
  
         globals.end_openram()
 

compiler/tests/30_openram_front_end_test.py

@@ -51,7 +51,7 @@ class openram_front_end_test(openram_test):
             debug.warning("Failed to find coverage installation. This can be installed with pip3 install coverage")
             exe_name = "{0}/openram.py ".format(OPENRAM_HOME)
         else:
-            exe_name = "coverage run -p {0}/openram.py ".format(OPENRAM_HOME) 
+            exe_name = "coverage run -p {0}/openram.py ".format(OPENRAM_HOME)
         config_name = "{0}/tests/configs/config_front_end.py".format(OPENRAM_HOME)
         cmd = "{0} -n -o {1} -p {2} {3} {4} 2>&1 > {5}/output.log".format(exe_name,
                                                                           out_file,
@@ -64,33 +64,32 @@ class openram_front_end_test(openram_test):
         
         # assert an error until we actually check a result
         for extension in ["v", "lef", "sp", "gds"]:
-            filename = "{0}/{1}.{2}".format(out_path,out_file,extension)
+            filename = "{0}/{1}.{2}".format(out_path, out_file, extension)
-            debug.info(1,"Checking for file: " + filename)
+            debug.info(1, "Checking for file: " + filename)
-            self.assertEqual(os.path.exists(filename),True)
+            self.assertEqual(os.path.exists(filename), True)
 
         # Make sure there is any .lib file
         import glob
         files = glob.glob('{0}/*.lib'.format(out_path))
         self.assertTrue(len(files)>0)
         
-        # Make sure there is any .html file 
+        # Make sure there is any .html file
         if os.path.exists(out_path):
             datasheets = glob.glob('{0}/*html'.format(out_path))
             self.assertTrue(len(datasheets)>0)
         
         # grep any errors from the output
-        output_log = open("{0}/output.log".format(out_path),"r")
+        output_log = open("{0}/output.log".format(out_path), "r")
         output = output_log.read()
         output_log.close()
-        self.assertEqual(len(re.findall('ERROR',output)),0)
+        self.assertEqual(len(re.findall('ERROR', output)), 0)
-        self.assertEqual(len(re.findall('WARNING',output)),0)
+        self.assertEqual(len(re.findall('WARNING', output)), 0)
 
-
+        # now clean up the directory
-       # now clean up the directory
         if OPTS.purge_temp:
             if os.path.exists(out_path):
                 shutil.rmtree(out_path, ignore_errors=True)
-            self.assertEqual(os.path.exists(out_path),False)
+            self.assertEqual(os.path.exists(out_path), False)
 
         globals.end_openram()