From 1d9fbb6143d2b595c7342e8191b9d504bbade3f4 Mon Sep 17 00:00:00 2001 From: Mohamed Gaber Date: Thu, 15 May 2025 18:01:13 +0300 Subject: [PATCH] misc: review feedback, remove MUL vestiges --- passes/silimate/splitlarge.cc | 4 +--- tests/silimate/wide_op.v | 9 ++------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/passes/silimate/splitlarge.cc b/passes/silimate/splitlarge.cc index f38cf76a7..c08984edd 100644 --- a/passes/silimate/splitlarge.cc +++ b/passes/silimate/splitlarge.cc @@ -58,8 +58,6 @@ auto width_low = width / 2; auto width_high = width - width_low; // Handle odd widths - auto a = cell->getPort(ID::A); - auto b = cell->getPort(ID::B); bool aSigned = cell->parameters[ID::A_SIGNED].as_bool(); bool bSigned = cell->parameters[ID::B_SIGNED].as_bool(); SigSpec aHigh, aLow, bHigh, bLow; @@ -198,6 +196,6 @@ Pass::call(design, "clean *"); } - } SplitfanoutPass; + } SplitlargePass; PRIVATE_NAMESPACE_END diff --git a/tests/silimate/wide_op.v b/tests/silimate/wide_op.v index 52b54e83a..2e2c589e7 100644 --- a/tests/silimate/wide_op.v +++ b/tests/silimate/wide_op.v @@ -4,11 +4,10 @@ ); parameter width = 1024; - // ADD/SUB: 0/4 + (0 unsigned+unsigned, 1 unsigned+signed, 2 signed+unsigned, 3 signed+signed) - // reserved for MUL: 8 + // ADD/SUB: 0/4 + (0 unsigned;unsigned, 1 unsigned;signed, 2 signed;unsigned, 3 signed;signed) parameter op = 0; - localparam ywidth = (op == 8) ? width * 2 : width; + localparam ywidth = width; // (op == MUL) ? width * 2 : width; input[width-1:0] a; input[width-1:0] b; output [width-1:0] y; @@ -31,9 +30,5 @@ assign {c, y} = $signed(a) - b; else if (op == 7) assign {c, y} = $signed(a) - $signed(b); - else if (op == 8) begin - assign c = 0; - assign y = a * b; - end endgenerate endmodule