From 45a567a405c551d150dea991412fda0e388f645f Mon Sep 17 00:00:00 2001
From: Stefan Frederik <stefan.schippers@gmail.com>
Date: Wed, 27 Oct 2021 10:12:16 +0200
Subject: [PATCH] fix compiler warnings (unused return value check on some
 function calls, missing %s on non literal string printf args)

---
 src/hilight.c  | 4 ++--
 src/netlist.c  | 6 +++++-
 src/psprint.c  | 4 ++--
 src/rawtovcd.c | 4 +++-
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/hilight.c b/src/hilight.c
index 7f15019f..88769c35 100644
--- a/src/hilight.c
+++ b/src/hilight.c
@@ -187,7 +187,7 @@ void create_plot_cmd(void)
             xcolor_array[c].red>>8, xcolor_array[c].green>>8, xcolor_array[c].blue>>8);
           if(idx > 9) {
             idx = 2;
-            fprintf(fd, str);
+            fprintf(fd, "%s", str);
             fprintf(fd, "\n");
             first = 1;
             my_free(758, &str);
@@ -272,7 +272,7 @@ void create_plot_cmd(void)
     }
   }
   if(viewer == NGSPICE) {
-    fprintf(fd, str);
+    fprintf(fd, "%s", str);
     fprintf(fd, "\nremcirc\n.endc\n");
     my_free(761, &str);
     fclose(fd);
diff --git a/src/netlist.c b/src/netlist.c
index 58d12aaf..f8c17d5f 100644
--- a/src/netlist.c
+++ b/src/netlist.c
@@ -1131,7 +1131,11 @@ int sym_vs_sch_pins()
               load_ascii_string( &tmp, fd);
               break;
             case 'A':
-              fscanf(fd, "%d",&tmpi);
+              if(fscanf(fd, "%d",&tmpi)< 1) {
+                 fprintf(errfp,"sym_vs_sch_pins(): WARNING:  missing fields for ARC object, ignoring\n");
+                 read_line(fd, 0);
+                 break;
+              }
               if(fscanf(fd, "%lf %lf %lf %lf %lf ",&tmpd, &tmpd, &tmpd, &tmpd, &tmpd) < 5) {
                 fprintf(errfp,"sym_vs_sch_pins(): WARNING:  missing fields for ARC object, ignoring\n");
                 read_line(fd, 0);
diff --git a/src/psprint.c b/src/psprint.c
index 2e02cc99..e4ea0bc2 100644
--- a/src/psprint.c
+++ b/src/psprint.c
@@ -709,10 +709,10 @@ void create_ps(char **psfile, int what)
     fprintf(fd, "%%%%BeginProlog\n\n");
   
     for(i = 0; i < sizeof(utf8_enc)/sizeof(char *); i++) {
-      fprintf(fd, utf8_enc[i]);
+      fprintf(fd, "%s", utf8_enc[i]);
     }
     for(i = 0; i < sizeof(utf8)/sizeof(char *); i++) {
-      fprintf(fd, utf8[i]);
+      fprintf(fd, "%s", utf8[i]);
     }
   
     fprintf(fd, "/Times /Times chararr recode\n");
diff --git a/src/rawtovcd.c b/src/rawtovcd.c
index 8e3de1dc..f0640f81 100644
--- a/src/rawtovcd.c
+++ b/src/rawtovcd.c
@@ -83,7 +83,9 @@ void read_binary_block()
   }
   /* read binary block */
   for(p = 0; p < npoints; p++) {
-    fread(values[p], sizeof(double), nvars, fd);
+    if(fread(values[p], sizeof(double), nvars, fd) != nvars) {
+       fprintf(stderr, "Warning: binary block is not of correct size\n");
+    }
   }
   if(debug) fprintf(stderr, "done reading binary block\n");
 }