From fee839a80eb72e1e776168b81defcec47d98602d Mon Sep 17 00:00:00 2001 From: John Khoo Date: Fri, 18 Apr 2025 19:35:36 +1000 Subject: [PATCH] Update UNOPTFLAT warning to suggest isolate_assignments (#5942) --- docs/CONTRIBUTORS | 1 + src/V3SchedAcyclic.cpp | 2 +- test_regress/t/t_unoptflat_simple_2_bad.out | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/CONTRIBUTORS b/docs/CONTRIBUTORS index b3afaf402..28cce9e65 100644 --- a/docs/CONTRIBUTORS +++ b/docs/CONTRIBUTORS @@ -110,6 +110,7 @@ Jiuyang Liu Joey Liu John Coiner John Demme +John Khoo John Wehle Jonathan Drolet Jonathan Schröter diff --git a/src/V3SchedAcyclic.cpp b/src/V3SchedAcyclic.cpp index 628d2d072..1b98e02c7 100644 --- a/src/V3SchedAcyclic.cpp +++ b/src/V3SchedAcyclic.cpp @@ -317,7 +317,7 @@ void reportLoopVars(Graph* graphp, SchedAcyclicVarVertex* vvtxp) { if (splittable) { std::cerr << V3Error::warnMoreStandalone() - << "... Suggest add /*verilator split_var*/ to appropriate variables above." + << "... Suggest add /*verilator split_var*/ or /*verilator isolate_assignments*/ to appropriate variables above." << std::endl; } V3Stats::addStat("Scheduling, split_var, candidates", splittable); diff --git a/test_regress/t/t_unoptflat_simple_2_bad.out b/test_regress/t/t_unoptflat_simple_2_bad.out index be3386782..49c85ef34 100644 --- a/test_regress/t/t_unoptflat_simple_2_bad.out +++ b/test_regress/t/t_unoptflat_simple_2_bad.out @@ -10,5 +10,5 @@ t/t_unoptflat_simple_2.v:16:15: t.x, width 3, circular fanout 1, can split_var ... Candidates with the highest fanout: t/t_unoptflat_simple_2.v:16:15: t.x, width 3, circular fanout 1, can split_var - ... Suggest add /*verilator split_var*/ to appropriate variables above. + ... Suggest add /*verilator split_var*/ or /*verilator isolate_assignments*/ to appropriate variables above. %Error: Exiting due to