From f789d28277aefb599302a5f99eae42c0da84ffab Mon Sep 17 00:00:00 2001
From: Krzysztof Bieganski <kbieganski@antmicro.com>
Date: Tue, 31 Oct 2023 02:26:46 +0100
Subject: [PATCH] Fix signals read via virtual iface optimized out (#4645)

Signed-off-by: Krzysztof Bieganski <kbieganski@antmicro.com>
---
 src/V3Gate.cpp                            |  5 +++
 test_regress/t/t_interface_virtual_opt.pl | 21 ++++++++++++
 test_regress/t/t_interface_virtual_opt.v  | 42 +++++++++++++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100755 test_regress/t/t_interface_virtual_opt.pl
 create mode 100644 test_regress/t/t_interface_virtual_opt.v

diff --git a/src/V3Gate.cpp b/src/V3Gate.cpp
index df38ef6df..6560dc054 100644
--- a/src/V3Gate.cpp
+++ b/src/V3Gate.cpp
@@ -372,6 +372,11 @@ private:
             UINFO(6, "New vertex " << varscp << endl);
             vertexp = new GateVarVertex{&m_graph, m_scopep, varscp};
             varscp->user1p(vertexp);
+            if (varscp->varp()->isUsedVirtIface()) {
+                // Can be used in a class method, which cannot be tracked statically
+                vertexp->clearReducibleAndDedupable("VirtIface");
+                vertexp->setConsumed("VirtIface");
+            }
             if (varscp->varp()->isSigPublic()) {
                 // Public signals shouldn't be changed, pli code might be messing with them
                 vertexp->clearReducibleAndDedupable("SigPublic");
diff --git a/test_regress/t/t_interface_virtual_opt.pl b/test_regress/t/t_interface_virtual_opt.pl
new file mode 100755
index 000000000..b46d46042
--- /dev/null
+++ b/test_regress/t/t_interface_virtual_opt.pl
@@ -0,0 +1,21 @@
+#!/usr/bin/env perl
+if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
+# DESCRIPTION: Verilator: Verilog Test driver/expect definition
+#
+# Copyright 2003 by Wilson Snyder. This program is free software; you
+# can redistribute it and/or modify it under the terms of either the GNU
+# Lesser General Public License Version 3 or the Perl Artistic License
+# Version 2.0.
+# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
+
+scenarios(simulator => 1);
+
+compile(
+    );
+
+execute(
+    check_finished => 1,
+    );
+
+ok(1);
+1;
diff --git a/test_regress/t/t_interface_virtual_opt.v b/test_regress/t/t_interface_virtual_opt.v
new file mode 100644
index 000000000..d538fc009
--- /dev/null
+++ b/test_regress/t/t_interface_virtual_opt.v
@@ -0,0 +1,42 @@
+// DESCRIPTION: Verilator: Verilog Test module
+//
+// This file ONLY is placed under the Creative Commons Public Domain, for
+// any use, without warranty, 2023 by Antmicro Ltd.
+// SPDX-License-Identifier: CC0-1.0
+
+interface Bus;
+   logic [7:0] data;
+endinterface
+
+class Cls;
+   virtual Bus vbus;
+
+   function void check(logic [7:0] data);
+       if (vbus.data != data) $stop;
+   endfunction
+endclass
+
+module t (clk);
+   input clk;
+   int cyc = 0;
+
+   Bus bus();
+   virtual Bus vbus;
+   Cls obj;
+
+   assign bus.data = 'hFA;
+
+   always @(posedge clk) begin
+      cyc <= cyc + 1;
+      if (cyc == 1) begin
+         obj = new;
+         vbus = bus;
+         obj.vbus = bus;
+      end
+      else if (cyc == 2) begin
+         obj.check('hFA);
+         $write("*-* All Finished *-*\n");
+         $finish;
+      end
+   end
+endmodule