From cc5a744b3a64a50b917db541ff826a194253feda Mon Sep 17 00:00:00 2001 From: Mateusz Gancarz Date: Tue, 11 Feb 2025 11:21:06 +0100 Subject: [PATCH] [#72179] remove unused code --- include/verilated_saif_c.cpp | 24 ++++-------------------- include/verilated_saif_c.h | 12 ------------ 2 files changed, 4 insertions(+), 32 deletions(-) diff --git a/include/verilated_saif_c.cpp b/include/verilated_saif_c.cpp index 4f1a91fd0..7ec026d16 100644 --- a/include/verilated_saif_c.cpp +++ b/include/verilated_saif_c.cpp @@ -229,7 +229,7 @@ void VerilatedSaif::close() VL_MT_SAFE_EXCLUDES(m_mutex) { printStr(std::to_string(m_time).c_str()); printStr(")\n"); - //NOTE: for now only care about + //NOTE: for now only care about NET, also PORT will be added printStr("(INSTANCE foo (NET\n"); for (auto& activity : m_activity) { for (size_t i = 0; i < activity.width; i++) { @@ -240,6 +240,9 @@ void VerilatedSaif::close() VL_MT_SAFE_EXCLUDES(m_mutex) { if (!bit.transitions) { // FIXME for some reason, signals are duplicated. // The duplicates have no transitions, so we skip them. + + fprintf(stdout, "Possible duplicate activity - name: %s, bit index: %d\n", activity.name, i); + continue; } assert(m_time >= bit.highTime); @@ -332,12 +335,6 @@ void VerilatedSaif::bufferFlush() VL_MT_UNSAFE_ONE { //============================================================================= // Definitions -void VerilatedSaif::printIndent(int level_change) { - if (level_change < 0) m_indent += level_change; - for (int i = 0; i < m_indent; ++i) printStr(" "); - if (level_change > 0) m_indent += level_change; -} - void VerilatedSaif::pushPrefix(const std::string& name, VerilatedTracePrefixType type) { assert(!m_prefixStack.empty()); // Constructor makes an empty entry std::string pname = name; @@ -391,19 +388,6 @@ void VerilatedSaif::declare(uint32_t code, const char* name, const char* wirep, const std::string hierarchicalName = m_prefixStack.back().first + name; const bool enabled = Super::declCode(code, hierarchicalName, bits); - - //NOTE: m_suffixes currently not used anywhere - if (m_suffixes.size() <= nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE) { - m_suffixes.resize(nextCode() * VL_TRACE_SUFFIX_ENTRY_SIZE * 2, 0); - } - - //NOTE: m_maxSignalBytes currently used only here - // Keep upper bound on bytes a single signal can emit into the buffer - m_maxSignalBytes = std::max(m_maxSignalBytes, bits + 32); - // Make sure write buffer is large enough, plus header - bufferResize(m_maxSignalBytes + 1024); - - //NOTE: enabled is set much earlier but returned here if (!enabled) return; const size_t block_size = 1024; diff --git a/include/verilated_saif_c.h b/include/verilated_saif_c.h index 373cd0ae3..5dbc5e3c4 100644 --- a/include/verilated_saif_c.h +++ b/include/verilated_saif_c.h @@ -78,7 +78,6 @@ private: size_t m_maxSignalBytes = 0; // Upper bound on number of bytes a single signal can generate uint64_t m_wroteBytes = 0; // Number of bytes written to this file - std::vector m_suffixes; // SAIF line end string codes + metadata std::vector m_activity; std::vector m_codeToActivity; std::vector> m_activityArena; @@ -102,7 +101,6 @@ private: void openNextImp(bool incFilename); void closePrev(); void closeErr(); - void printIndent(int level_change); void printStr(const char* str); void declare(uint32_t code, const char* name, const char* wirep, bool array, int arraynum, bool bussed, int msb, int lsb); @@ -211,21 +209,11 @@ class VerilatedSaifBuffer VL_NOT_FINAL { // Output buffer flush trigger location (only used when not parallel) char* const m_wrFlushp = m_owner.parallel() ? nullptr : m_owner.m_wrFlushp; - // SAIF line end string codes + metadata - const char* const m_suffixes = m_owner.m_suffixes.data(); //NOTE: currently not used anywhere - // The maximum number of bytes a single signal can emit - const size_t m_maxSignalBytes = m_owner.m_maxSignalBytes; - // Additional data for parallel tracing only char* m_bufp = nullptr; // The beginning of the trace buffer size_t m_size = 0; // The size of the buffer at m_bufp char* m_growp = nullptr; // Resize limit pointer - void adjustGrowp() { - m_growp = (m_bufp + m_size) - (2 * m_maxSignalBytes); - assert(m_growp >= m_bufp + m_maxSignalBytes); - } - // CONSTRUCTOR explicit VerilatedSaifBuffer(VerilatedSaif& owner) : m_owner{owner} {}