From c63b6976365c1b78bfcc08942750dc232eeffe0f Mon Sep 17 00:00:00 2001
From: Wilson Snyder <wsnyder@wsnyder.org>
Date: Mon, 12 Mar 2012 20:29:00 -0400
Subject: [PATCH] Fix signed array warning, bug456.

---
 Changes                            |  2 +
 src/V3Width.cpp                    |  1 +
 test_regress/t/t_typedef_signed.pl | 18 ++++++
 test_regress/t/t_typedef_signed.v  | 91 ++++++++++++++++++++++++++++++
 4 files changed, 112 insertions(+)
 create mode 100755 test_regress/t/t_typedef_signed.pl
 create mode 100644 test_regress/t/t_typedef_signed.v

diff --git a/Changes b/Changes
index c21fbcc5c..f66ce5133 100644
--- a/Changes
+++ b/Changes
@@ -6,6 +6,8 @@ indicates the contributor was also the author of the fix; Thanks!
 
 * Verilator 3.833 devel
 
+****  Fix signed array warning, bug456. [Alex Solomatnikov]
+
 ****  Fix and document --gdb option, bug454. [Jeremy Bennett]
 
 
diff --git a/src/V3Width.cpp b/src/V3Width.cpp
index 7f70f05c4..f950d7fc2 100644
--- a/src/V3Width.cpp
+++ b/src/V3Width.cpp
@@ -618,6 +618,7 @@ private:
 	// But also cleanup array size
 	nodep->arrayp()->iterateAndNext(*this,WidthVP(ANYSIZE,0,BOTH).p());
 	nodep->widthFrom(nodep->dtypep());
+	nodep->numericFrom(nodep->dtypep());
 	UINFO(4,"dtWidthed "<<nodep<<endl);
     }
     virtual void visit(AstBasicDType* nodep, AstNUser* vup) {
diff --git a/test_regress/t/t_typedef_signed.pl b/test_regress/t/t_typedef_signed.pl
new file mode 100755
index 000000000..7058e622f
--- /dev/null
+++ b/test_regress/t/t_typedef_signed.pl
@@ -0,0 +1,18 @@
+#!/usr/bin/perl
+if (!$::Driver) { use FindBin; exec("$FindBin::Bin/bootstrap.pl", @ARGV, $0); die; }
+# DESCRIPTION: Verilator: Verilog Test driver/expect definition
+#
+# Copyright 2003 by Wilson Snyder. This program is free software; you can
+# redistribute it and/or modify it under the terms of either the GNU
+# Lesser General Public License Version 3 or the Perl Artistic License
+# Version 2.0.
+
+compile (
+	 );
+
+execute (
+	 check_finished=>1,
+     );
+
+ok(1);
+1;
diff --git a/test_regress/t/t_typedef_signed.v b/test_regress/t/t_typedef_signed.v
new file mode 100644
index 000000000..a0245942c
--- /dev/null
+++ b/test_regress/t/t_typedef_signed.v
@@ -0,0 +1,91 @@
+// DESCRIPTION: Verilator: Verilog Test module
+//
+// This file ONLY is placed into the Public Domain, for any use,
+// without warranty, 2012 by Wilson Snyder.
+
+//bug456
+
+typedef logic signed [34:0] rc_t;
+
+module t (/*AUTOARG*/
+   // Inputs
+   clk
+   );
+   input clk;
+
+   integer 	cyc=0;
+   reg [63:0] 	crc;
+   reg [63:0] 	sum;
+
+   // Take CRC data and apply to testblock inputs
+   wire [34:0]  rc = crc[34:0];
+
+   /*AUTOWIRE*/
+   // Beginning of automatic wires (for undeclared instantiated-module outputs)
+   logic		o;			// From test of Test.v
+   // End of automatics
+
+   Test test (/*AUTOINST*/
+	      // Outputs
+	      .o			(o),
+	      // Inputs
+	      .rc			(rc),
+	      .clk			(clk));
+
+   // Aggregate outputs into a single result vector
+   wire [63:0] result = {63'h0, o};
+
+   // Test loop
+   always @ (posedge clk) begin
+`ifdef TEST_VERBOSE
+      $write("[%0t] cyc==%0d crc=%x result=%x\n",$time, cyc, crc, result);
+`endif
+      cyc <= cyc + 1;
+      crc <= {crc[62:0], crc[63]^crc[2]^crc[0]};
+      sum <= result ^ {sum[62:0],sum[63]^sum[2]^sum[0]};
+      if (cyc==0) begin
+	 // Setup
+	 crc <= 64'h5aef0c8d_d70a4497;
+	 sum <= 64'h0;
+      end
+      else if (cyc<10) begin
+	 sum <= 64'h0;
+      end
+      else if (cyc==99) begin
+	 $write("[%0t] cyc==%0d crc=%x sum=%x\n",$time, cyc, crc, sum);
+	 if (crc !== 64'hc77bb9b3784ea091) $stop;
+	 // What checksum will we end up with (above print should match)
+`define EXPECTED_SUM 64'h7211d24a17b25ec9
+	 if (sum !== `EXPECTED_SUM) $stop;
+	 $write("*-* All Finished *-*\n");
+	 $finish;
+      end
+   end
+
+endmodule
+
+module Test( output logic o,
+             input 	 rc_t rc,
+             input logic clk);
+
+   localparam RATIO = 2;
+
+   rc_t rc_d[RATIO:1];
+
+   always_ff @(posedge clk) begin
+      integer  k;
+
+      rc_d[1] <= rc;
+      
+      for( k=2; k<RATIO+1; k++ ) begin
+         rc_d[k] <= rc_d[k-1];
+      end
+   end // always_ff @
+
+   assign o = rc_d[RATIO] < 0;
+
+endmodule
+
+// Local Variables:
+// verilog-typedef-regexp: "_t$"
+// End: