From affe776463fe7fa58e09889704309c05912f1aa4 Mon Sep 17 00:00:00 2001 From: Matthew Ballance Date: Thu, 5 Mar 2026 14:38:20 +0000 Subject: [PATCH] t_covergroup_with_sample_args_too_many_bad: remove redundant test 'sample' argument count checking is generic function/task behavior already covered by t_func_bad and similar tests. Removing this test eliminates fragility from upstream error message/caret changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- ...covergroup_with_sample_args_too_many_bad.out | 9 --------- ..._covergroup_with_sample_args_too_many_bad.py | 16 ---------------- ...t_covergroup_with_sample_args_too_many_bad.v | 17 ----------------- 3 files changed, 42 deletions(-) delete mode 100644 test_regress/t/t_covergroup_with_sample_args_too_many_bad.out delete mode 100755 test_regress/t/t_covergroup_with_sample_args_too_many_bad.py delete mode 100644 test_regress/t/t_covergroup_with_sample_args_too_many_bad.v diff --git a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.out b/test_regress/t/t_covergroup_with_sample_args_too_many_bad.out deleted file mode 100644 index a42bb7bda..000000000 --- a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.out +++ /dev/null @@ -1,9 +0,0 @@ -%Error: t/t_covergroup_with_sample_args_too_many_bad.v:15:26: Too many arguments in call to function 'sample' - : ... note: In instance 't' - 15 | cov1.sample(5, 1'b0, 42); - | ^~~~~~ - : ... Location of function 'sample' declaration: - 9 | covergroup cg_with_sample(int init) with function sample (int addr, bit is_read = 1'b0); - | ^~~~~~~~~~~~~~ - ... See the manual at https://verilator.org/verilator_doc.html?v=latest for more assistance. -%Error: Exiting due to diff --git a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.py b/test_regress/t/t_covergroup_with_sample_args_too_many_bad.py deleted file mode 100755 index 1d5ccb8f4..000000000 --- a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.py +++ /dev/null @@ -1,16 +0,0 @@ -#!/usr/bin/env python3 -# DESCRIPTION: Verilator: Verilog Test driver/expect definition -# -# This program is free software; you can redistribute it and/or modify it -# under the terms of either the GNU Lesser General Public License Version 3 -# or the Perl Artistic License Version 2.0. -# SPDX-FileCopyrightText: 2025 Wilson Snyder -# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0 - -import vltest_bootstrap - -test.scenarios('linter') - -test.lint(fails=True, expect_filename=test.golden_filename) - -test.passes() diff --git a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.v b/test_regress/t/t_covergroup_with_sample_args_too_many_bad.v deleted file mode 100644 index 718188ae6..000000000 --- a/test_regress/t/t_covergroup_with_sample_args_too_many_bad.v +++ /dev/null @@ -1,17 +0,0 @@ -// DESCRIPTION: Verilator: Verilog Test module -// -// This file ONLY is placed under the Creative Commons Public Domain -// SPDX-FileCopyrightText: 2025 Antmicro -// SPDX-License-Identifier: CC0-1.0 - -/* verilator lint_off COVERIGN */ -module t; - covergroup cg_with_sample(int init) with function sample (int addr, bit is_read = 1'b0); - endgroup - - cg_with_sample cov1 = new(7); - - function void run(); - cov1.sample(5, 1'b0, 42); // Too many arguments - endfunction -endmodule