From 6fc25dae9e0c488de8b54a13f9a646d68e7b5ef5 Mon Sep 17 00:00:00 2001
From: Geza Lore <gezalore@gmail.com>
Date: Tue, 2 Aug 2022 15:47:14 +0100
Subject: [PATCH] Fix clang-tidy warnings (#3522)

---
 src/V3Order.cpp | 7 ++++---
 src/V3Order.h   | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/V3Order.cpp b/src/V3Order.cpp
index 0ce70e37f..938e91232 100644
--- a/src/V3Order.cpp
+++ b/src/V3Order.cpp
@@ -951,7 +951,8 @@ class OrderProcess final : VNDeleter {
     // CONSTRUCTOR
     OrderProcess(AstNetlist* netlistp, OrderGraph& graph,
                  const std::unordered_map<const AstSenItem*, const AstSenTree*>& trigToSen,
-                 const string& tag, bool slow, V3Order::ExternalDomainsProvider externalDomains)
+                 const string& tag, bool slow,
+                 const V3Order::ExternalDomainsProvider& externalDomains)
         : m_graph{graph}
         , m_trigToSen{trigToSen}
         , m_externalDomains{externalDomains}
@@ -970,7 +971,7 @@ public:
     main(AstNetlist* netlistp, OrderGraph& graph,
          const std::unordered_map<const AstSenItem*, const AstSenTree*>& trigToSen,
          const string& tag, bool parallel, bool slow,
-         V3Order::ExternalDomainsProvider externalDomains) {
+         const V3Order::ExternalDomainsProvider& externalDomains) {
         OrderProcess visitor{netlistp, graph, trigToSen, tag, slow, externalDomains};
         visitor.process(parallel);
         return std::move(visitor.m_result);
@@ -1518,7 +1519,7 @@ AstCFunc* order(AstNetlist* netlistp,  //
                 const string& tag,  //
                 bool parallel,  //
                 bool slow,  //
-                ExternalDomainsProvider externalDomains) {
+                const ExternalDomainsProvider& externalDomains) {
     // Order the code
     const std::unique_ptr<OrderGraph> graph
         = OrderBuildVisitor::process(netlistp, logic, trigToSen);
diff --git a/src/V3Order.h b/src/V3Order.h
index edd7db707..6beac4031 100644
--- a/src/V3Order.h
+++ b/src/V3Order.h
@@ -47,7 +47,7 @@ AstCFunc* order(
     const string& tag,  //
     bool parallel,  //
     bool slow,  //
-    ExternalDomainsProvider externalDomains
+    const ExternalDomainsProvider& externalDomains
     = [](const AstVarScope*, std::vector<AstSenTree*>&) {});
 
 };  // namespace V3Order