From 5be89d2ae52ca004915728c35d85d927d0e7b268 Mon Sep 17 00:00:00 2001 From: Saksham Date: Sun, 21 Jun 2026 23:32:05 +0530 Subject: [PATCH] Address reviewer feedback: update existing test for multiple warnings --- docs/CONTRIBUTORS | 2 +- test_regress/t/t_case_enum_incomplete_bad.out | 3 +++ test_regress/t/t_case_enum_incomplete_bad.v | 1 - .../t/t_case_enum_incomplete_wildcard_bad.out | 12 ++++++++++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/CONTRIBUTORS b/docs/CONTRIBUTORS index 13d5a99e7..a22db1f07 100644 --- a/docs/CONTRIBUTORS +++ b/docs/CONTRIBUTORS @@ -252,6 +252,7 @@ Rowan Goemans Rupert Swarbrick Ryan Ziegler Ryszard Rozak +Saksham Gupta Samuel Riedel Sean Cross Sebastien Van Cauwenberghe @@ -329,4 +330,3 @@ Zubin Jain Muzaffer Kal Yilin Li Shashvat Prabhu -Saksham Gupta diff --git a/test_regress/t/t_case_enum_incomplete_bad.out b/test_regress/t/t_case_enum_incomplete_bad.out index 6fa08e122..b1a0c8b1f 100644 --- a/test_regress/t/t_case_enum_incomplete_bad.out +++ b/test_regress/t/t_case_enum_incomplete_bad.out @@ -3,4 +3,7 @@ | ^~~~ ... For warning description see https://verilator.org/warn/CASEINCOMPLETE?v=latest ... Use "/* verilator lint_off CASEINCOMPLETE */" and lint_on around source to disable this message. +%Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_bad.v:18:12: Enum item 'S2' not covered by case + 18 | unique case (state) + | ^~~~ %Error: Exiting due to diff --git a/test_regress/t/t_case_enum_incomplete_bad.v b/test_regress/t/t_case_enum_incomplete_bad.v index d5d4dabab..6f5dfd6c0 100644 --- a/test_regress/t/t_case_enum_incomplete_bad.v +++ b/test_regress/t/t_case_enum_incomplete_bad.v @@ -17,7 +17,6 @@ module t; unique case (state) S0: $stop; - S2: $stop; endcase end endmodule diff --git a/test_regress/t/t_case_enum_incomplete_wildcard_bad.out b/test_regress/t/t_case_enum_incomplete_wildcard_bad.out index 289933112..ec731329c 100644 --- a/test_regress/t/t_case_enum_incomplete_wildcard_bad.out +++ b/test_regress/t/t_case_enum_incomplete_wildcard_bad.out @@ -3,12 +3,24 @@ | ^~~~ ... For warning description see https://verilator.org/warn/CASEINCOMPLETE?v=latest ... Use "/* verilator lint_off CASEINCOMPLETE */" and lint_on around source to disable this message. +%Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:26:12: Enum item 'SX0' not covered by case + 26 | unique case (state) + | ^~~~ %Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:30:12: Enum item 'S00' not covered by case 30 | unique case (state) | ^~~~ +%Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:30:12: Enum item 'SX0' not covered by case + 30 | unique case (state) + | ^~~~ +%Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:30:12: Enum item 'S0X' not covered by case + 30 | unique case (state) + | ^~~~ %Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:35:12: Enum item 'S10' not covered by case 35 | unique casez (state) | ^~~~~ +%Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:35:12: Enum item 'SX0' not covered by case + 35 | unique casez (state) + | ^~~~~ %Warning-CASEINCOMPLETE: t/t_case_enum_incomplete_wildcard_bad.v:40:5: Case values incompletely covered (example pattern 0x3) 40 | case (state) | ^~~~