From 51de2c919498c1d599048f18275c0e78a0cf64c2 Mon Sep 17 00:00:00 2001 From: Wilson Snyder Date: Sat, 17 Dec 2022 16:48:08 -0500 Subject: [PATCH] Remove reader task code which was non-functional (#3360) --- src/V3Partition.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/V3Partition.cpp b/src/V3Partition.cpp index 87a631ea0..07223f2fd 100644 --- a/src/V3Partition.cpp +++ b/src/V3Partition.cpp @@ -1971,13 +1971,9 @@ private: tasksByRank[writerMtaskp->rank()].insert(writerMtaskp); } } - // Find all reader tasks for this variable, group by rank. - for (V3GraphEdge* edgep = varVtxp->outBeginp(); edgep; edgep = edgep->outNextp()) { - if (const auto* const logicVtxp = dynamic_cast(edgep->fromp())) { - LogicMTask* const readerMtaskp = static_cast(logicVtxp->userp()); - tasksByRank[readerMtaskp->rank()].insert(readerMtaskp); - } - } + // Not: Find all reader tasks for this variable, group by rank. + // There was "broken" code here to find readers, but fixing it to + // work properly harmed performance on some tests, see #3360. } void mergeSameRankTasks(const TasksByRank& tasksByRank) { LogicMTask* lastRecipientp = nullptr;