diff --git a/docs/CONTRIBUTING.rst b/docs/CONTRIBUTING.rst index 15f2fed27..1e81842ad 100644 --- a/docs/CONTRIBUTING.rst +++ b/docs/CONTRIBUTING.rst @@ -59,7 +59,7 @@ Did you write a patch that fixes a bug? Creative Commons Public Domain (CC0), unless you request otherwise or put a GNU/Artistic license on your file. -- Most important is we get your patch. If you’d like to clean up +- Most important is we get your patch. If you'd like to clean up indentation and related issues ahead of our feedback, that is appreciated; please see the coding conventions in `docs/internals `__. diff --git a/docs/guide/languages.rst b/docs/guide/languages.rst index 4cdd0217a..4865f5375 100644 --- a/docs/guide/languages.rst +++ b/docs/guide/languages.rst @@ -130,11 +130,11 @@ simulation (perhaps using :vlopt:`--build`) and run it. With :vlopt:`--no-timing`, all timing controls cause the :option:`NOTIMING` error, except: -* delay statements – they are ignored (as they are in synthesis), though they +* delay statements - they are ignored (as they are in synthesis), though they do issue a :option:`STMTDLY` warning, -* intra-assignment timing controls – they are ignored, though they do issue an +* intra-assignment timing controls - they are ignored, though they do issue an :option:`ASSIGNDLY` warning, -* net delays – they are ignored, +* net delays - they are ignored, * event controls at the top of the procedure, Forks cause this error as well, except: diff --git a/docs/internals.rst b/docs/internals.rst index 6f5a4b577..7e96fa7bd 100644 --- a/docs/internals.rst +++ b/docs/internals.rst @@ -564,7 +564,7 @@ lifetime, and prevents multiple ``resume`` calls in the case of ^^^^^^^^^^^^^^^ Return value of all coroutines. Together with the promise type contained -within, it allows for chaining coroutines – resuming coroutines from up the +within, it allows for chaining coroutines - resuming coroutines from up the call stack. The calling coroutine's handle is saved in the promise object as a continuation, that is, the coroutine that must be resumed after the promise's coroutine finishes. This is necessary as C++ coroutines are stackless, meaning @@ -585,7 +585,7 @@ simulation time is retrieved from a ``VerilatedContext`` object. This class manages processes that await events (triggers). There is one such object per each trigger awaited by coroutines. Coroutines ``co_await`` this -object's ``trigger`` function. They are stored in two stages – `uncommitted` +object's ``trigger`` function. They are stored in two stages - `uncommitted` and `ready`. First, they land in the `uncommitted` stage, and cannot be resumed. The ``resume`` function resumes all coroutines from the `ready` stage and moves `uncommitted` coroutines into `ready`. The ``commit`` function only diff --git a/test_regress/t/t_dist_whitespace.pl b/test_regress/t/t_dist_whitespace.pl index 1aaf1975f..1d8825d6c 100755 --- a/test_regress/t/t_dist_whitespace.pl +++ b/test_regress/t/t_dist_whitespace.pl @@ -34,7 +34,6 @@ foreach my $file (sort keys %files) { if ($contents =~ /[ \t]\n/ || $contents =~ m/\n\n+$/) { # Regexp repeated below my $eol_ws_exempt = ($file =~ /(\.txt|\.html)$/ - || $file =~ m!^README$! || $file =~ m!/gtkwave/!); next if $eol_ws_exempt; if ($ENV{HARNESS_UPDATE_GOLDEN}) { @@ -62,6 +61,16 @@ foreach my $file (sort keys %files) { $warns{$file} = "Trailing newlines at EOF in $file"; } } + # Unicode checker; should this be done in another file? + # No way to auto-fix. + # Files with \r are flagged elsewhere, right? + if ($contents =~ /[^[:alnum:][:punct:] \t\r\n]/) { + my $unicode_exempt = ($file =~ /Changes$/ + || $file =~ /CONTRIBUTORS$/ + || $file =~ /contributors.rst$/); + next if $unicode_exempt; + $warns{$file} = "Warning: non-ASCII contents in $file\n"; + } ++$any; } $any > 50 or error("Too few source files found");