From 432d5f851df2e562c6b96a652c9b99bf758275dd Mon Sep 17 00:00:00 2001 From: Wilson Snyder Date: Fri, 24 Jan 2025 20:52:31 -0500 Subject: [PATCH] Internals: Cleanup some misnamed nodep's. No functional change. --- src/V3LinkDot.cpp | 10 +++++----- src/V3Param.cpp | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/V3LinkDot.cpp b/src/V3LinkDot.cpp index 8c54b2984..9f77c8aad 100644 --- a/src/V3LinkDot.cpp +++ b/src/V3LinkDot.cpp @@ -986,8 +986,8 @@ class LinkDotFindVisitor final : public VNVisitor { if (nodep->hierParams()) { UINFO(1, "Found module with hier type parameters" << endl); m_hierParamsName = nodep->name(); - for (const AstNode* node = nodep->op2p(); node; node = node->nextp()) { - if (const AstTypedef* const tdef = VN_CAST(node, Typedef)) { + for (const AstNode* stmtp = nodep->stmtsp(); stmtp; stmtp = stmtp->nextp()) { + if (const AstTypedef* const tdef = VN_CAST(stmtp, Typedef)) { UINFO(1, "Inserting hier type parameter typedef: " << tdef << endl); VSymEnt* const upperSymp = m_curSymp ? m_curSymp : m_statep->rootEntp(); m_curSymp = m_modSymp = m_statep->insertBlock(upperSymp, nodep->name(), @@ -1501,9 +1501,9 @@ class LinkDotFindVisitor final : public VNVisitor { if (const VSymEnt* const typedefEntp = m_curSymp->findIdFallback(m_hierParamsName)) { const AstModule* modp = VN_CAST(typedefEntp->nodep(), Module); - for (const AstNode* node = modp ? modp->stmtsp() : nullptr; node; - node = node->nextp()) { - const AstTypedef* tdefp = VN_CAST(node, Typedef); + for (const AstNode* stmtp = modp ? modp->stmtsp() : nullptr; stmtp; + stmtp = stmtp->nextp()) { + const AstTypedef* tdefp = VN_CAST(stmtp, Typedef); if (tdefp && tdefp->name() == nodep->name() && m_statep->forPrimary()) { UINFO(8, "Replacing type of" << nodep << endl diff --git a/src/V3Param.cpp b/src/V3Param.cpp index 17ecb785b..5cea41c8b 100644 --- a/src/V3Param.cpp +++ b/src/V3Param.cpp @@ -543,18 +543,18 @@ class ParamProcessor final { for (auto&& defaultValue : paramsIt->second) { const auto pinIt = pins.find(defaultValue.first); // If the pin does not have a value assigned, use the default one. - const AstNode* const node = pinIt == pins.end() ? defaultValue.second : pinIt->second; + const AstNode* const nodep = pinIt == pins.end() ? defaultValue.second : pinIt->second; // This longname is not valid as verilog symbol, but ok, because it will be hashed longname += "_" + defaultValue.first + "="; // constp can be nullptr - if (const AstConst* const p = VN_CAST(node, Const)) { + if (const AstConst* const p = VN_CAST(nodep, Const)) { // Treat modules parametrized with the same values but with different type as the // same. longname += p->num().ascii(false); - } else if (node) { + } else if (nodep) { std::stringstream type; - V3EmitV::verilogForTree(node, type); + V3EmitV::verilogForTree(nodep, type); longname += type.str(); } }