From 42debebb07583fbdf14575691cb3c7d2d1fbe4c6 Mon Sep 17 00:00:00 2001 From: Matthew Ballance Date: Sat, 28 Feb 2026 20:58:54 +0000 Subject: [PATCH] verilog.y: fix accidental DEL omissions for wait_order, expect, property case Three node deletions were accidentally dropped from the initial covergroup commit as collateral damage: - wait_order (no-stmt variant): restore DEL($3) for vrdList - expect (no-stmt variant): restore DEL($3) for property_spec - property_exprCaseIf yIF/yELSE: restore DEL($3) for condition expr In all three cases $3 is an AstNode* that is not assigned to $$ and would be leaked without the deletion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/verilog.y | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/verilog.y b/src/verilog.y index 2350088cc..dbb704146 100644 --- a/src/verilog.y +++ b/src/verilog.y @@ -3729,7 +3729,7 @@ statement_item: // IEEE: statement_item | yWAIT_ORDER '(' vrdList ')' stmt yELSE stmt { $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($3, $5, $7);} | yWAIT_ORDER '(' vrdList ')' yELSE stmt - { $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($6); } + { $$ = nullptr; BBUNSUP($4, "Unsupported: wait_order"); DEL($3, $6); } // // // IEEE: procedural_assertion_statement | procedural_assertion_statement { $$ = $1; } @@ -3746,7 +3746,7 @@ statement_item: // IEEE: statement_item | yEXPECT '(' property_spec ')' stmt yELSE stmt { $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($3, $5, $7); } | yEXPECT '(' property_spec ')' yELSE stmt - { $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($6); } + { $$ = nullptr; BBUNSUP($1, "Unsupported: expect"); DEL($3, $6); } ; statementVerilatorPragmas: @@ -6642,7 +6642,7 @@ property_exprCaseIf: // IEEE: part of property_expr for if/case | yIF '(' expr/*expression_or_dist*/ ')' pexpr %prec prLOWER_THAN_ELSE { $$ = $5; BBUNSUP($1, "Unsupported: property case expression"); DEL($3); } | yIF '(' expr/*expression_or_dist*/ ')' pexpr yELSE pexpr - { $$ = $5; BBUNSUP($1, "Unsupported: property case expression"); DEL($7); } + { $$ = $5; BBUNSUP($1, "Unsupported: property case expression"); DEL($3, $7); } ; property_case_itemList: // IEEE: {property_case_item}