From 0c53d191139a717d142dda20921e2160e4c827a1 Mon Sep 17 00:00:00 2001 From: Huanghuang Zhou Date: Tue, 31 May 2022 19:10:58 +0800 Subject: [PATCH] Commentary: `InstrCountVisitor` documentation (#3457) Signed-off-by: huanghuang.zhou --- docs/CONTRIBUTORS | 1 + docs/internals.rst | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/CONTRIBUTORS b/docs/CONTRIBUTORS index 8079639e2..d598cebd5 100644 --- a/docs/CONTRIBUTORS +++ b/docs/CONTRIBUTORS @@ -35,6 +35,7 @@ Guokai Chen Harald Heckmann Howard Su Huang Rui +Huanghuang Zhou HungMingWu HyungKi Jeong Iru Cai diff --git a/docs/internals.rst b/docs/internals.rst index 62358f1d7..499e0fa12 100644 --- a/docs/internals.rst +++ b/docs/internals.rst @@ -274,7 +274,7 @@ path through the graph is the sum of macro-task execution costs. Sarkar does almost the same thing, except that he has nonzero estimates for synchronization costs. -Verilator's cost estimates are assigned by ``InstrCountCostVisitor``. This +Verilator's cost estimates are assigned by ``InstrCountVisitor``. This class is perhaps the most fragile piece of the multithread implementation. It's easy to have a bug where you count something cheap (eg. accessing one element of a huge array) as if it were expensive (eg.