From 02e88e38486d2acd95783d3199c59b6fd4b35417 Mon Sep 17 00:00:00 2001
From: Wilson Snyder <wsnyder@wsnyder.org>
Date: Thu, 19 Sep 2024 22:56:47 -0400
Subject: [PATCH] Fix suppression of WIDTH* warnings when immediately under a
 size cast (#3417).

---
 Changes                             |  1 +
 src/V3Width.cpp                     |  3 +++
 test_regress/t/t_lint_width_cast.py | 18 +++++++++++++++++
 test_regress/t/t_lint_width_cast.v  | 30 +++++++++++++++++++++++++++++
 4 files changed, 52 insertions(+)
 create mode 100755 test_regress/t/t_lint_width_cast.py
 create mode 100644 test_regress/t/t_lint_width_cast.v

diff --git a/Changes b/Changes
index 63a921c85..d65967f93 100644
--- a/Changes
+++ b/Changes
@@ -32,6 +32,7 @@ Verilator 5.029 devel
 * Improve Verilation thread pool (#5161). [Bartłomiej Chmiel, Antmicro Ltd.]
 * Improve performance of V3VariableOrder with parallelism (#5406). [Bartłomiej Chmiel, Antmicro Ltd.]
 * Improve parser error handling. [Arkadiusz Kozdra, Antmicro Ltd.]
+* Fix suppression of WIDTH* warnings when immediately under a size cast (#3417).
 * Fix `$fatal` to not be affected by `+verilator+error+limit` (#5135). [Gökçe Aydos]
 * Fix display with multiple string formats (#5311). [Luiza de Melo]
 * Fix performance of V3Trace when many activity blocks (#5372). [Deniz Güzel]
diff --git a/src/V3Width.cpp b/src/V3Width.cpp
index 0e6215645..e43dc3a3c 100644
--- a/src/V3Width.cpp
+++ b/src/V3Width.cpp
@@ -7229,6 +7229,9 @@ class WidthVisitor final : public VNVisitor {
                 underp = nullptr;  // Changes underp
                 return;
             }
+            // If user has a sizing cast, assume they know what they are doing
+            // (for better or worse)
+            if (VN_IS(nodep->backp(), CastSize)) warnOn = false;
             if (VN_IS(underp, Const) && VN_AS(underp, Const)->num().isFromString()
                 && expWidth > underp->width()
                 && (((expWidth - underp->width()) % 8) == 0)) {  // At least it's character sized
diff --git a/test_regress/t/t_lint_width_cast.py b/test_regress/t/t_lint_width_cast.py
new file mode 100755
index 000000000..d4f986441
--- /dev/null
+++ b/test_regress/t/t_lint_width_cast.py
@@ -0,0 +1,18 @@
+#!/usr/bin/env python3
+# DESCRIPTION: Verilator: Verilog Test driver/expect definition
+#
+# Copyright 2024 by Wilson Snyder. This program is free software; you
+# can redistribute it and/or modify it under the terms of either the GNU
+# Lesser General Public License Version 3 or the Perl Artistic License
+# Version 2.0.
+# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0
+
+import vltest_bootstrap
+
+test.scenarios('simulator')
+
+test.compile()
+
+test.execute()
+
+test.passes()
diff --git a/test_regress/t/t_lint_width_cast.v b/test_regress/t/t_lint_width_cast.v
new file mode 100644
index 000000000..80413b2a2
--- /dev/null
+++ b/test_regress/t/t_lint_width_cast.v
@@ -0,0 +1,30 @@
+// DESCRIPTION: Verilator: Verilog Test module
+//
+// This file ONLY is placed under the Creative Commons Public Domain, for
+// any use, without warranty, 2024 by Wilson Snyder.
+// SPDX-License-Identifier: CC0-1.0
+
+`define stop $stop
+`define checkh(gotv,expv) do if ((gotv) !== (expv)) begin $write("%%Error: %s:%0d:  got='h%x exp='h%x\n", `__FILE__,`__LINE__, (gotv), (expv)); `stop; end while(0);
+
+module t(/*AUTOARG*/);
+
+   wire [5:0] b1 = 6'b101101;
+   wire [5:0] b2 = 6'b011110;
+   logic [5:0] a6;
+   logic [9:0] a10;
+
+   initial begin
+      // issue #3417
+      a6 = b2 - b1;
+      `checkh(a6, 6'h31);
+      a10 = 10'(b2 - b1);
+      `checkh(a10, 10'h3f1);  // This being not 31 indicates operator expands
+      `checkh($bits(10'(b1)), 10);
+      `checkh($bits(10'(b2 - b1)), 10);
+      `checkh($bits(b2 - b1), 6);
+      $write("*-* All Finished *-*\n");
+      $finish;
+   end
+
+endmodule