Commit Graph

17940 Commits

Author SHA1 Message Date
Ethan Atkins f8d729cd3b Don't set fileOutputs at the compile config level
This was problematic because it had no dependency on the compile task
which meant that any other task in the config would pick up those
fileOutputs which did not make sense. I noticed this because
(resources / outputFileStamps).value would include class files.
2019-05-28 09:53:35 -07:00
Ethan Atkins 1a8b9de625 Catch NoClassDefFoundErrors in tests
If a test threw a NoClassDefFoundError, it was uncaught and the user got
an obscure error. After this change, they will be warned that the
classloader layering strategy may be at fault and will get instructions
on how to fix it.
2019-05-28 09:53:35 -07:00
Ethan Atkins df628d4f87 Improve legacy launcher
To minimize classloading and consistency between sbt instances launched
with the latest launcher compared to old launchers, I overhauled code
that replaces the app configuration and meta build classloader at
startup. The goals of this change for legacy launchers were:

1) Do not ever load the scala-library.jar from the app provider class loader.
2) Close the class loaders that are below the topLoader in the class
   loading hierarcy

For the new launcher, we simply want to avoid modifying the loader at
all.

I added the SbtParserInit class so that it was more straightforward to
preload the global instance using reflection. We now use reflection to
instantiate an SbtParserInit instance for both the legacy and new
launcher cases to simplify the logic.

After this change, the legacy loader still uses somewhat more metaspace
than the new loader, but the difference seems to be O(10MB), which
should only impact projects that were close their MaxMetaspaceSize to
begin with.

I verified using javap that none of the code in this class uses the
scala standard library which should help metaspace since we don't load
much of the scala standard library until we enter xMainImpl.run.
2019-05-28 09:53:35 -07:00
Ethan Atkins e6d2b32902 Add scripted watchTriggers
This allows the scripted test files to trigger a continuous scripted
build.
2019-05-28 09:53:35 -07:00
Alexandre Archambault bed2d2dd28
Easier bin compat for stuff under lmcoursier.definitions (#73) 2019-05-28 12:48:16 +02:00
eugene yokota b6f02b9b8c
Merge pull request #4730 from eatkins/external-hooks
Move external hooks definition
2019-05-27 18:49:00 -04:00
Alexandre Archambault bf189d8fc1
Merge pull request #65 from alexarchambault/bump-coursier
Switch to coursier 1.1.0-M14-5
2019-05-27 16:16:14 +02:00
Alexandre Archambault cbbdd02422 Disable sbt-pgp-coursier tests
Seems some signatures use an algo that bouncycastle doesn't support, and
/ or some stuff broke internally.
2019-05-27 14:50:33 +02:00
Alexandre Archambault 4f41e866fd Missing item in cache key? 2019-05-27 14:47:09 +02:00
Alexandre Archambault 4f0d90483b Bump sbt-pgp dependency of sbt-pgp-coursier 2019-05-27 14:46:53 +02:00
Ethan Atkins 22d5fbad13 Move external hooks definition
I verified manually that ExternalHooks were still applied by default but
that I could set the incOptions in the Test and Compile configs so that
they weren't used.

Fixes #4624
2019-05-26 19:15:55 -07:00
eugene yokota 707972e190
Merge pull request #4728 from eed3si9n/wip/collectfiles
Reproduce Twirl regression
2019-05-26 00:33:36 -04:00
Eugene Yokota 5936bd1ff2 Revert Defaults.collectFiles
Fixes #4681
Ref #4649
2019-05-25 14:10:14 -04:00
Eugene Yokota 90af7a46c1 Reproduce Twirl regression
Ref #4681
2019-05-25 14:10:14 -04:00
eugene yokota 07dec80a70
Merge pull request #4725 from eed3si9n/wip/bridge
scalaCompilerBridgeDependencyResolution
2019-05-25 11:39:06 -04:00
Eugene Yokota 67eeffe765 add scripted test for Hydra plugin 2019-05-24 13:59:56 -04:00
Alexandre Archambault 8bca7041f4 Get name and extension from resolution
Fixes https://github.com/coursier/coursier/issues/419
2019-05-24 17:43:12 +02:00
Alexandre Archambault 24dabbf5b6 Bump coursier 2019-05-24 17:43:12 +02:00
Eugene Yokota 0ff97e4561 scalaCompilerBridgeDependencyResolution
Fixes #4712

This adds a specialized DependencyResolution instance called `scalaCompilerBridgeDependencyResolution` to download the compiler bridge. It has its own list of resolvers set by `scalaCompilerBridgeResolvers`. For backward compatibility, it will append `externalResolvers.value` as well.
2019-05-24 01:02:44 -04:00
eugene yokota 9956a676ab
Merge pull request #268 from eed3si9n/wip/opts
Update Java options
2019-05-23 13:35:10 -04:00
Eugene Yokota f94dc1a9ed no more warnings 2019-05-23 12:42:19 -04:00
Alexandre Archambault 052756db1f
Merge pull request #67 from alexarchambault/develop
Take ivyPaths into account
2019-05-23 11:39:46 +02:00
Alexandre Archambault 5436809323 Take ivyPaths into account 2019-05-23 10:50:55 +02:00
Alexandre Archambault 87f812d6f3 Switch to coursier sbt-launcher 1.2.11
Has fixes for ivy paths handling in particular
2019-05-23 10:50:50 +02:00
Alexandre Archambault d94503446e Make CoursierConfiguration easier to edit 2019-05-23 10:49:37 +02:00
Alexandre Archambault d02fc470da
Merge pull request #69 from eed3si9n/wip/mima
Run MiMa on Travis CI
2019-05-23 10:34:19 +02:00
Eugene Yokota 8015e9f1a9 Remove reference to get_mem_opts 2019-05-22 23:40:10 -04:00
Eugene Yokota bd32204c21 Bump stack size
Ref https://github.com/scala/bug/issues/10870
2019-05-22 23:38:50 -04:00
Eugene Yokota 8a3a7c2b7d Remove MaxMetaspaceSize
Ref https://github.com/sbt/sbt/issues/4686
2019-05-22 23:36:52 -04:00
Eugene Yokota e39a139042 Remove -XX:MaxPermSize out of Windows default
Fixes #223
2019-05-22 17:32:13 -04:00
Eugene Yokota 05ea7eedc5 whitespace fix 2019-05-22 17:22:03 -04:00
Eugene Yokota 1f372805c4 sbt 1.2.8 2019-05-22 15:19:59 -04:00
Eugene Yokota 21ee54e198 Run MiMa on Travis CI
Ref 62d1ab0249
Ref https://github.com/coursier/coursier/issues/1174
2019-05-22 15:19:46 -04:00
Guillaume Martres 186693368d Make coursier-related tasks public
This follows the discussion in
https://github.com/coursier/coursier/issues/1181.
2019-05-21 19:10:38 +02:00
eugene yokota 745894efc5 Handle whitespace in file resolver path (#68)
Fixes https://github.com/coursier/coursier/issues/1175
2019-05-21 10:03:27 +02:00
eugene yokota a021528af4
Merge pull request #4641 from smarter/reenable-dotty
Reenable dotty-compiler-plugin test
2019-05-20 14:49:43 -04:00
eugene yokota ecce47e5b7
Merge pull request #4703 from eed3si9n/wip/scalatest
Fixes layer 4 missing scala-reflect
2019-05-20 14:26:42 -04:00
eugene yokota b7363ea4fc
Merge pull request #4702 from eed3si9n/wip/bumpsbt
sbt 1.3.0-RC1
2019-05-17 16:58:53 -04:00
Johannes Rudolph 6e8ab67219
Adapt README again because reason given was probably wrong
It seems the problem might already be fixed in master.
2019-05-17 22:10:37 +02:00
Johannes Rudolph 39609b0d3e
Add note that sbt 1.3.x is currently unsupported 2019-05-17 22:04:03 +02:00
Johannes Rudolph a093b91433
Revert to old README until new version has been released 2019-05-17 21:51:09 +02:00
Eugene Yokota 08c49358c7 Reduce concurrency of scalafmtCheck
Ref scalameta/scalafmt#1399
2019-05-17 14:51:07 -04:00
Eugene Yokota 9d3b626567 Fix ScalaTest issue with ScalaLibrary classloader
Ref #4689
Ref #4671
2019-05-17 14:24:55 -04:00
Eugene Yokota 2376de63d1 sbt 1.3.0-RC1 2019-05-17 11:23:02 -04:00
Guillaume Martres 18bba7366b Upgrade the other dotty test for consistency 2019-05-17 12:04:07 +02:00
Guillaume Martres 19658c2ee0 Reenable dotty-compiler-plugin test
https://github.com/lampepfl/dotty/issues/5671 is fixed now.

Also synchronize the test with
8ffed083c7/sbt-dotty/sbt-test/sbt-dotty/compiler-plugin
2019-05-17 12:04:04 +02:00
eugene yokota 5f127c6339
Merge pull request #4684 from eatkins/fix-warnings
Fix warnings
2019-05-16 16:17:45 -04:00
Ethan Atkins 5a9f5a69d5 Fix warnings
These lines added new warnings that slipped through the cracks.
2019-05-15 17:27:07 -07:00
eugene yokota a85b486b4c
export repo using Coursier (#267)
export repo using Coursier

Ref https://github.com/sbt/sbt/issues/4661
2019-05-15 10:52:39 -04:00
eugene yokota 15b4befa9c
Merge pull request #4679 from eatkins/rt-jar
Don't ever invalidate rt.jar
2019-05-14 22:13:45 -04:00