From 18fb6841437338fd7aceb7ae6ac19c89cf75dbff Mon Sep 17 00:00:00 2001 From: James Roper Date: Thu, 9 Apr 2015 11:45:33 +1000 Subject: [PATCH] Update incremental compile debug message sbt 0.13.1 was changed so that products were invalidated not just when they were deleted, but also when they were modified, however the debug message was not updated to reflect this, causing people to think invalidated class files had been deleted. --- .../inc/src/main/scala/sbt/inc/IncrementalCommon.scala | 4 ++-- notes/0.13.9/debug-removed-products.markdown | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 notes/0.13.9/debug-removed-products.markdown diff --git a/compile/inc/src/main/scala/sbt/inc/IncrementalCommon.scala b/compile/inc/src/main/scala/sbt/inc/IncrementalCommon.scala index e854c66a2..e11939285 100644 --- a/compile/inc/src/main/scala/sbt/inc/IncrementalCommon.scala +++ b/compile/inc/src/main/scala/sbt/inc/IncrementalCommon.scala @@ -196,7 +196,7 @@ private[inc] abstract class IncrementalCommon(log: Logger, options: IncOptions) checkAbsolute(srcChanges.added.toList) log.debug( "\nInitial source changes: \n\tremoved:" + srcChanges.removed + "\n\tadded: " + srcChanges.added + "\n\tmodified: " + srcChanges.changed + - "\nRemoved products: " + changes.removedProducts + + "\nInvalidated products: " + changes.removedProducts + "\nExternal API changes: " + changes.external + "\nModified binary dependencies: " + changes.binaryDeps + "\nInitial directly invalidated sources: " + srcDirect + @@ -335,4 +335,4 @@ private[inc] abstract class IncrementalCommon(log: Logger, options: IncOptions) } xs.toSet } -} \ No newline at end of file +} diff --git a/notes/0.13.9/debug-removed-products.markdown b/notes/0.13.9/debug-removed-products.markdown new file mode 100644 index 000000000..6e43b6640 --- /dev/null +++ b/notes/0.13.9/debug-removed-products.markdown @@ -0,0 +1,10 @@ + [@jroper]: https://github.com/jroper + [1961]: https://github.com/sbt/sbt/issues/1961 + +### Changes with compatibility implications + +### Improvements + +### Fixes + +- Correct incermental compile debug message for invalidated products [#1961][1961] by [@jroper][@jroper]