From c5ce6363764b4256e2d70e470634d8e75fc2f565 Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Tue, 27 Aug 2019 17:47:32 -0400 Subject: [PATCH] Flip the default to not use Gigahorse by default Fixes https://github.com/sbt/sbt/issues/3570 The primary motivation for bringing in Gigahorse was to speed up the dependency resolution, especially in a high-latency environment like Australia, by enabling keep-alive. One of unintended consequences was that it ended up exposing either a bug in okhttp or Nexus / Artifactory's handling of keep-alive, since corporate users behind these proxy repositories started to experience problem publishing. Multiple people have also reported that putting network proxies like HAProxy works around this issue, which seems consistent with the theory. Now that dependency resolution has switched to using Coursier by default, I am just going to flip the default here so publishing would use Ivy's default URL handler based on `java.net.HttpURLConnection` - https://github.com/sbt/ivy/blob/5681e1a77a149b93a4cfbe4a86d0263d7bd223eb/src/java/org/apache/ivy/util/url/BasicURLHandler.java --- .../main/scala/sbt/internal/librarymanagement/LMSysProp.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/scala/sbt/internal/librarymanagement/LMSysProp.scala b/core/src/main/scala/sbt/internal/librarymanagement/LMSysProp.scala index 1fe46916f..15bb4a9e5 100644 --- a/core/src/main/scala/sbt/internal/librarymanagement/LMSysProp.scala +++ b/core/src/main/scala/sbt/internal/librarymanagement/LMSysProp.scala @@ -54,5 +54,5 @@ object LMSysProp { } } - lazy val useGigahorse: Boolean = getOrTrue("sbt.gigahorse") + lazy val useGigahorse: Boolean = getOrFalse("sbt.gigahorse") }