From 0368243ed9db9237e7397ea23ec008e0b25086ac Mon Sep 17 00:00:00 2001 From: Friendseeker <66892505+Friendseeker@users.noreply.github.com> Date: Thu, 31 Oct 2024 15:05:48 -0700 Subject: [PATCH 1/2] Return 1 when Client failed --- client/src/main/java/sbt/client/Client.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/src/main/java/sbt/client/Client.java b/client/src/main/java/sbt/client/Client.java index 6ffe838ff..dcabbf158 100644 --- a/client/src/main/java/sbt/client/Client.java +++ b/client/src/main/java/sbt/client/Client.java @@ -9,19 +9,21 @@ package sbt.client; import sbt.internal.client.NetworkClient; -import java.nio.file.Paths; import org.fusesource.jansi.AnsiConsole; public class Client { public static void main(final String[] args) { boolean isWin = System.getProperty("os.name").toLowerCase().startsWith("win"); + boolean hadError = false; try { if (isWin) AnsiConsole.systemInstall(); NetworkClient.main(args); } catch (final Throwable t) { t.printStackTrace(); + hadError = true; } finally { if (isWin) AnsiConsole.systemUninstall(); + if (hadError) System.exit(1); } } } From c58842da4e8e143fc9c9d355054536e7f21f8145 Mon Sep 17 00:00:00 2001 From: friendseeker <66892505+Friendseeker@users.noreply.github.com> Date: Thu, 31 Oct 2024 19:37:16 -0700 Subject: [PATCH 2/2] Add smoke test --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6cb5ca518..617efd46d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -167,6 +167,8 @@ jobs: run: | # test building sbtn on Linux sbt "-Dsbt.io.virtual=false" nativeImage + # smoke test native Image + ./client/target/bin/sbtn shutdown # test launcher script echo build using JDK 8 test using JDK 8 and JDK 11 cd launcher-package