From b47ca1b9efbc2ae9f840914cea8efa3d52d7e71c Mon Sep 17 00:00:00 2001 From: Yusuke Izawa Date: Mon, 29 May 2017 19:33:55 +0900 Subject: [PATCH] Implement sequential[B](tasks: Seq[Initialize[Task[B]]]) and remove useless comment outs --- .../scala/sbt/internal/TaskSequential.scala | 18 ++++++------------ notes/1.0.0/fix-task-sequential.markdown | 5 +++++ 2 files changed, 11 insertions(+), 12 deletions(-) create mode 100644 notes/1.0.0/fix-task-sequential.markdown diff --git a/main/src/main/scala/sbt/internal/TaskSequential.scala b/main/src/main/scala/sbt/internal/TaskSequential.scala index 4cfcd84cb..a646bc739 100644 --- a/main/src/main/scala/sbt/internal/TaskSequential.scala +++ b/main/src/main/scala/sbt/internal/TaskSequential.scala @@ -757,6 +757,12 @@ trait TaskSequential { last ) + def sequential[B](tasks: Seq[Initialize[Task[B]]]): Initialize[Task[B]] = { + val initTasks: Seq[Initialize[Task[B]]] = tasks.init + val lastTask: Initialize[Task[B]] = tasks.last + sequential(initTasks.map(unitTask), lastTask) + } + def sequential[B]( tasks: Seq[Initialize[Task[Unit]]], last: Initialize[Task[B]] @@ -775,15 +781,3 @@ trait TaskSequential { () } } - -// for { -// i <- 0 to 21 -// } { -// val idx = 0 to i -// val tparams = (idx map { "A" + _ }).mkString(", ") -// val params = (idx map { j => s"task$j: Initialize[Task[A$j]]" }).mkString(", ") -// val args = (idx map { j => s"unitTask(task$j)" }).mkString(", ") -// println(s""" def sequential[$tparams, B]($params, -// | last: Initialize[Task[B]]): Initialize[Task[B]] = -// | sequential(List($args), last)""".stripMargin) -// } diff --git a/notes/1.0.0/fix-task-sequential.markdown b/notes/1.0.0/fix-task-sequential.markdown new file mode 100644 index 000000000..314bd4077 --- /dev/null +++ b/notes/1.0.0/fix-task-sequential.markdown @@ -0,0 +1,5 @@ +### Improvements + +- Implement `sequential[B](tasks: Seq[Initialize[Task[B]]])` method. by [@3tty0n][@3tty0n] + + [@3tty0n]: https://github.com/3tty0n