From 92202d435317e9c0c104346d85e1bdd77f2805ae Mon Sep 17 00:00:00 2001
From: Josh Suereth <joshua.suereth@gmail.com>
Date: Fri, 24 Jul 2015 10:42:49 -0400
Subject: [PATCH] Add warning to MakePom for intransitive dependencies.

Intransitive does not work in Maven, and does not translate to pom.xml.
---
 ivy/src/main/scala/sbt/MakePom.scala | 37 +++++++++++++++++-----------
 1 file changed, 23 insertions(+), 14 deletions(-)

diff --git a/ivy/src/main/scala/sbt/MakePom.scala b/ivy/src/main/scala/sbt/MakePom.scala
index 1dfa5d1fe..530070dda 100644
--- a/ivy/src/main/scala/sbt/MakePom.scala
+++ b/ivy/src/main/scala/sbt/MakePom.scala
@@ -236,21 +236,30 @@ class MakePom(val log: Logger) {
   def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String]): NodeSeq =
     makeDependency(dependency, includeTypes, Nil)
 
-  def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String], excludes: Seq[ExcludeRule]): NodeSeq =
-    {
-      val artifacts = dependency.getAllDependencyArtifacts
-      val includeArtifacts = artifacts.filter(d => includeTypes(d.getType))
-      if (artifacts.isEmpty) {
-        val configs = dependency.getModuleConfigurations
-        if (configs.filterNot(Set("sources", "docs")).nonEmpty) {
-          val (scope, optional) = getScopeAndOptional(dependency.getModuleConfigurations)
-          makeDependencyElem(dependency, scope, optional, None, None, excludes)
-        } else NodeSeq.Empty
-      } else if (includeArtifacts.isEmpty)
-        NodeSeq.Empty
-      else
-        NodeSeq.fromSeq(artifacts.flatMap(a => makeDependencyElem(dependency, a, excludes)))
+  def makeDependency(dependency: DependencyDescriptor, includeTypes: Set[String], excludes: Seq[ExcludeRule]): NodeSeq = {
+    def warnIntransitve(): Unit =
+      if (!dependency.isTransitive)
+        log.warn(
+          s"""Translating intransitive dependency (${dependency.getDependencyId}) into pom.xml, but maven does not support intransitive dependencies.
+             |  Please use exclusions instead so transitive dependencies will be correctly excluded in dependent projects.
+           """.stripMargin)
+      else ()
+    val artifacts = dependency.getAllDependencyArtifacts
+    val includeArtifacts = artifacts.filter(d => includeTypes(d.getType))
+    if (artifacts.isEmpty) {
+      val configs = dependency.getModuleConfigurations
+      if (configs.filterNot(Set("sources", "docs")).nonEmpty) {
+        warnIntransitve()
+        val (scope, optional) = getScopeAndOptional(dependency.getModuleConfigurations)
+        makeDependencyElem(dependency, scope, optional, None, None, excludes)
+      } else NodeSeq.Empty
+    } else if (includeArtifacts.isEmpty) {
+      NodeSeq.Empty
+    } else {
+      warnIntransitve()
+      NodeSeq.fromSeq(artifacts.flatMap(a => makeDependencyElem(dependency, a, excludes)))
     }
+  }
 
   @deprecated("Use `makeDependencyElem` variant which takes excludes", "0.13.9")
   def makeDependencyElem(dependency: DependencyDescriptor, artifact: DependencyArtifactDescriptor): Option[Elem] =