From 8fee1e2666ddf391d5ba7c7cc9ac33a196a2b534 Mon Sep 17 00:00:00 2001
From: Eugene Yokota <eed3si9n@gmail.com>
Date: Tue, 13 Aug 2019 23:35:50 -0400
Subject: [PATCH] improve "X is evicted completely"

Fixes https://github.com/sbt/sbt/issues/4946

1. This rewords "evicted completely" to "evicted for all versions"
2. Skips transitive and complete evictions (eviction that has no winner version)
---
 .../main/scala/sbt/librarymanagement/EvictionWarning.scala  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/src/main/scala/sbt/librarymanagement/EvictionWarning.scala b/core/src/main/scala/sbt/librarymanagement/EvictionWarning.scala
index 22405934c..c090cd2ad 100644
--- a/core/src/main/scala/sbt/librarymanagement/EvictionWarning.scala
+++ b/core/src/main/scala/sbt/librarymanagement/EvictionWarning.scala
@@ -183,7 +183,7 @@ object EvictionPair {
     }
     val winnerRev = a.winner match {
       case Some(r) => s":${r.module.revision} is selected over ${revsStr}"
-      case _       => " is evicted completely"
+      case _       => " is evicted for all versions"
     }
     val title = s"\t* ${a.organization}:${a.name}$winnerRev"
     title :: (if (a.showCallers) callers.reverse else Nil) ::: List("")
@@ -312,7 +312,9 @@ object EvictionWarning {
             binaryIncompatibleEvictionExists = true
         }
       case p =>
-        if (!guessCompatible(p)) {
+        // don't report on a transitive eviction that does not have a winner
+        // https://github.com/sbt/sbt/issues/4946
+        if (!guessCompatible(p) && p.winner.isDefined) {
           if (options.warnTransitiveEvictions)
             transitiveEvictions += p
           if (options.warnEvictionSummary)