From 5cea7ae09fc20650660650bd339771a388781d52 Mon Sep 17 00:00:00 2001 From: jvican Date: Fri, 24 Feb 2017 17:10:07 +0100 Subject: [PATCH] Do a first pass on the Zinc internal implementation This commit addresses several concers: * Document better the Zinc internal implementation. * Getting the implementation ready for moving things from internal to public APIs. This will be done in a follow-up commit. * Removing `inputs` and `setups` from the `IncrementalCompilerUtil` as they exist mainly to interface between Scala code and Java code. The reality is that both Java and Scala developers can easily call the constructors by themselves and don't learn more API methods. * Removes unused imports, that emit stupid warnings. * Make code more readable, especifically in the analyzing compilers for both Java and Scala, which was hardly understandable and documented. * Make `AnalyzingJavaCompiler` to extend `JavaCompiler` as `AnalyzingCompiler` does for `ScalaCompiler`. In an upcoming commit, `AnalyzingCompiler` will be renamed into `AnalyzingScalaCompiler` for consistency reasons. * Replace use of `sbt.util.Logger` helpers by `sbt.util.InterfaceUtil`. --- .../scala/sbt/internal/inc/BridgeProviderSpecification.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/zinc-ivy-integration/src/test/scala/sbt/internal/inc/BridgeProviderSpecification.scala b/internal/zinc-ivy-integration/src/test/scala/sbt/internal/inc/BridgeProviderSpecification.scala index 170545e8e..35c9fda9b 100644 --- a/internal/zinc-ivy-integration/src/test/scala/sbt/internal/inc/BridgeProviderSpecification.scala +++ b/internal/zinc-ivy-integration/src/test/scala/sbt/internal/inc/BridgeProviderSpecification.scala @@ -10,7 +10,7 @@ import sbt.internal.librarymanagement.JsonUtil import sbt.io.IO import sbt.io.syntax._ import sbt.librarymanagement.{ ModuleID, UpdateOptions, Resolver, Patterns, FileRepository, DefaultMavenRepository } -import sbt.util.{ Logger, Level } +import sbt.util.Logger import xsbti.{ ComponentProvider, GlobalLock } /**