From ef70d84323415c4c0cadb57545eeea73a6b796f7 Mon Sep 17 00:00:00 2001 From: Josh Suereth Date: Fri, 1 Aug 2014 15:41:26 -0400 Subject: [PATCH 1/2] Fixes #1306 - Attempt to turn test suite names into better filenames. --- testing/src/main/scala/sbt/JUnitXmlTestsListener.scala | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala b/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala index 16f7bfc45..815a1110d 100644 --- a/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala +++ b/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala @@ -2,6 +2,7 @@ package sbt import java.io.{ StringWriter, PrintWriter, File } import java.net.InetAddress + import scala.collection.mutable.ListBuffer import scala.util.DynamicVariable import scala.xml.{ Elem, Node => XNode, XML } @@ -154,8 +155,12 @@ class JUnitXmlTestsListener(val outputDir: String) extends TestsListener { writeSuite() } + // Here we normalize the name to ensure that it's a nicer filename, rather than + // contort the user into not using spaces. + private[this] def normalizeName(s: String) = s.replaceAll("""\s+""", "-") + private def writeSuite() = { - val file = new File(targetDir, testSuite.value.name + ".xml").getAbsolutePath + val file = new File(targetDir, s"${normalizeName(testSuite.value.name)}.xml").getAbsolutePath // TODO would be nice to have a logger and log this with level debug // System.err.println("Writing JUnit XML test report: " + file) XML.save(file, testSuite.value.stop(), "UTF-8", true, null) From b6e37917315b866607c2c1e0b663825a96af76ba Mon Sep 17 00:00:00 2001 From: Josh Suereth Date: Fri, 1 Aug 2014 17:18:37 -0400 Subject: [PATCH 2/2] Add notes for test report fix. --- notes/0.13.6.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/notes/0.13.6.md b/notes/0.13.6.md index 6794ed72d..c542ee36c 100644 --- a/notes/0.13.6.md +++ b/notes/0.13.6.md @@ -34,6 +34,7 @@ [1476]: https://github.com/sbt/sbt/pull/1476 [1477]: https://github.com/sbt/sbt/pull/1477 [1486]: https://github.com/sbt/sbt/pull/1486 + [1487]: https://github.com/sbt/sbt/pull/1487 [@dansanduleac]: https://github.com/dansanduleac [@2m]: https://github.com/2m [@pvlugter]: https://github.com/pvlugter @@ -78,6 +79,7 @@ - Fixes cross versioning to recognize version number with mutiple -tags. [#1433][1433] by [@henrikengstrom][@henrikengstrom] - Works around "Not a simple type" breaking `-Xfatal-warnings`. [#1477][1477] by [@puffnfresh][@puffnfresh] - Fixes sLog usage in tandem with the `set` comamnd [#1486][1486] [@jsuereth][@jsuereth] +- Test suites with whitespace will have prettier filenames [#1487][1487] [@jsuereth][@jsuereth] ### enablePlugins/disablePlugins