From 164fb5f847d1bd2014ddce10d9190017f5165f6f Mon Sep 17 00:00:00 2001 From: Dale Wijnand Date: Fri, 18 Dec 2015 14:04:09 +0000 Subject: [PATCH] Drop sealed from the typeclasses in Append --- main/settings/src/main/scala/sbt/Append.scala | 6 +++--- .../drop-sealed-from-Append-typeclasses.markdown | 10 ++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 notes/0.13.10/drop-sealed-from-Append-typeclasses.markdown diff --git a/main/settings/src/main/scala/sbt/Append.scala b/main/settings/src/main/scala/sbt/Append.scala index ee7738b24..fafd65f5c 100644 --- a/main/settings/src/main/scala/sbt/Append.scala +++ b/main/settings/src/main/scala/sbt/Append.scala @@ -6,14 +6,14 @@ import scala.annotation.implicitNotFound object Append { @implicitNotFound(msg = "No implicit for Append.Value[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}") - sealed trait Value[A, B] { + trait Value[A, B] { def appendValue(a: A, b: B): A } @implicitNotFound(msg = "No implicit for Append.Values[${A}, ${B}] found,\n so ${B} cannot be appended to ${A}") - sealed trait Values[A, -B] { + trait Values[A, -B] { def appendValues(a: A, b: B): A } - sealed trait Sequence[A, -B, T] extends Value[A, T] with Values[A, B] + trait Sequence[A, -B, T] extends Value[A, T] with Values[A, B] implicit def appendSeq[T, V <: T]: Sequence[Seq[T], Seq[V], V] = new Sequence[Seq[T], Seq[V], V] { def appendValues(a: Seq[T], b: Seq[V]): Seq[T] = a ++ b diff --git a/notes/0.13.10/drop-sealed-from-Append-typeclasses.markdown b/notes/0.13.10/drop-sealed-from-Append-typeclasses.markdown new file mode 100644 index 000000000..6ad216120 --- /dev/null +++ b/notes/0.13.10/drop-sealed-from-Append-typeclasses.markdown @@ -0,0 +1,10 @@ + + [1171]: https://github.com/sbt/sbt/issues/1171 + [2322]: https://github.com/sbt/sbt/pull/2322 + +### Fixes with compatibility implications + +### Improvements +- Drops `sealed` from the typeclasses in Append. [#2322][] by [@dwijnand][] + +### Bug fixes