From 78c007c91014d69421ab87668f8f0003ab46f3e6 Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Sat, 20 Apr 2019 03:23:08 -0400 Subject: [PATCH 1/3] sbt-scalafmt 2.0.0 --- .scalafmt.conf | 3 +++ .travis.yml | 2 +- project/plugins.sbt | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.scalafmt.conf b/.scalafmt.conf index a36334e44..866ffc284 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,3 +1,4 @@ +version = 2.0.0-RC5 maxColumn = 100 project.git = true project.excludeFilters = [ /sbt-test/, /input_sources/, /contraband-scala/ ] @@ -16,3 +17,5 @@ align.openParenDefnSite = false # For better code clarity danglingParentheses = true + +trailingCommas = preserve diff --git a/.travis.yml b/.travis.yml index 220810d8b..d37eb6afa 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,7 +10,7 @@ env: # WHITESOURCE_PASSWORD= - secure: d3bu2KNwsVHwfhbGgO+gmRfDKBJhfICdCJFGWKf2w3Gv86AJZX9nuTYRxz0KtdvEHO5Xw8WTBZLPb2thSJqhw9OCm4J8TBAVqCP0ruUj4+aqBUFy4bVexQ6WKE6nWHs4JPzPk8c6uC1LG3hMuzlC8RGETXtL/n81Ef1u7NjyXjs= matrix: - - SBT_CMD=";mimaReportBinaryIssues ;scalafmtCheck ;headerCheck ;test:headerCheck ;whitesourceOnPush ;test:compile ;mainSettingsProj/test ;safeUnitTests ;otherUnitTests; doc" + - SBT_CMD=";mimaReportBinaryIssues ;scalafmtCheckAll ;headerCheck ;test:headerCheck ;whitesourceOnPush ;test:compile ;mainSettingsProj/test ;safeUnitTests ;otherUnitTests; doc" - SBT_CMD="scripted actions/*" - SBT_CMD="scripted apiinfo/* compiler-project/* ivy-deps-management/*" - SBT_CMD="scripted dependency-management/*1of4" diff --git a/project/plugins.sbt b/project/plugins.sbt index 3c00d1ebf..a41e98daf 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -2,7 +2,7 @@ scalaVersion := "2.12.8" scalacOptions ++= Seq("-feature", "-language:postfixOps") addSbtPlugin("org.scala-sbt" % "sbt-houserules" % "0.3.9") -addSbtPlugin("com.geirsson" % "sbt-scalafmt" % "1.5.1") +addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.0.0") addSbtPlugin("org.scala-sbt" % "sbt-contraband" % "0.4.1") addSbtPlugin("de.heikoseeberger" % "sbt-header" % "3.0.2") addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.9.0") From 1e157b991a94da95d191ef68a20a4f7c115d2686 Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Sat, 20 Apr 2019 03:23:54 -0400 Subject: [PATCH 2/3] apply formatting --- .../main/scala/sbt/internal/util/Dag.scala | 4 +- .../main/scala/sbt/internal/util/IDSet.scala | 5 +- .../main/scala/sbt/internal/util/INode.scala | 4 +- .../scala/sbt/internal/util/Settings.scala | 8 +- .../main/scala/sbt/internal/util/Signal.scala | 8 +- .../src/test/scala/SettingsExample.scala | 4 +- .../src/test/scala/SettingsTest.scala | 8 +- .../scala/sbt/internal/util/LineReader.scala | 6 +- .../sbt/internal/util/complete/History.scala | 9 +- .../sbt/internal/util/complete/Parser.scala | 28 ++++-- .../sbt/internal/util/complete/Parsers.scala | 4 +- .../src/main/scala/sbt/RawCompileLike.scala | 2 +- main-actions/src/main/scala/sbt/Sync.scala | 4 +- .../src/main/scala/sbt/compiler/Eval.scala | 6 +- .../test/scala/sbt/compiler/EvalTest.scala | 2 +- main-settings/src/main/scala/sbt/Def.scala | 6 +- .../src/main/scala/sbt/InputTask.scala | 4 +- main-settings/src/main/scala/sbt/Scope.scala | 5 +- .../main/scala/sbt/BackgroundJobService.scala | 17 ++-- main/src/main/scala/sbt/Defaults.scala | 50 +++++++---- main/src/main/scala/sbt/EvaluateTask.scala | 8 +- main/src/main/scala/sbt/Main.scala | 8 +- main/src/main/scala/sbt/Plugins.scala | 81 +++++++++-------- main/src/main/scala/sbt/Project.scala | 2 +- main/src/main/scala/sbt/ScopeFilter.scala | 27 +++--- main/src/main/scala/sbt/ScriptedPlugin.scala | 2 +- main/src/main/scala/sbt/SessionVar.scala | 4 +- .../main/scala/sbt/TemplateCommandUtil.scala | 4 +- main/src/main/scala/sbt/Watch.scala | 2 +- .../main/scala/sbt/internal/AddSettings.scala | 2 +- main/src/main/scala/sbt/internal/Clean.scala | 9 +- .../main/scala/sbt/internal/Continuous.scala | 52 +++++------ .../sbt/internal/EvaluateConfigurations.scala | 60 +++++++------ .../src/main/scala/sbt/internal/Inspect.scala | 2 +- main/src/main/scala/sbt/internal/Load.scala | 29 +++---- .../src/main/scala/sbt/internal/Resolve.scala | 3 +- .../scala/sbt/internal/TaskProgress.scala | 2 +- .../sbt/internal/server/NetworkChannel.scala | 2 +- .../sbt/internal/server/SettingQuery.scala | 2 +- .../JsonRpcNotificationMessageFormats.scala | 2 +- .../codec/JsonRpcRequestMessageFormats.scala | 2 +- .../codec/JsonRpcResponseErrorFormats.scala | 2 +- .../codec/JsonRpcResponseMessageFormats.scala | 2 +- run/src/main/scala/sbt/Run.scala | 8 +- run/src/main/scala/sbt/TrapExit.scala | 8 +- sbt/src/test/scala/testpkg/ServerSpec.scala | 8 +- .../sbt/scriptedtest/ScriptedTests.scala | 29 +++---- .../src/main/scala/sbt/std/Streams.scala | 12 ++- .../src/main/scala/sbt/std/TaskExtra.scala | 2 +- tasks-standard/src/test/scala/TaskGen.scala | 6 +- .../src/test/scala/TaskRunnerCircular.scala | 8 +- .../src/test/scala/TaskSerial.scala | 6 +- .../src/test/scala/checkResult.scala | 20 ++--- .../main/scala/sbt/CompletionService.scala | 9 +- tasks/src/main/scala/sbt/Execute.scala | 6 +- .../scala/sbt/JUnitXmlTestsListener.scala | 87 +++++++++++-------- .../src/main/scala/sbt/TestFramework.scala | 6 +- 57 files changed, 405 insertions(+), 303 deletions(-) diff --git a/internal/util-collection/src/main/scala/sbt/internal/util/Dag.scala b/internal/util-collection/src/main/scala/sbt/internal/util/Dag.scala index ab0f30b7e..f5f584290 100644 --- a/internal/util-collection/src/main/scala/sbt/internal/util/Dag.scala +++ b/internal/util-collection/src/main/scala/sbt/internal/util/Dag.scala @@ -27,7 +27,9 @@ object Dag { def visit(node: T): Unit = { if (!discovered(node)) { discovered(node) = true; - try { visitAll(dependencies(node)); } catch { case c: Cyclic => throw node :: c } + try { + visitAll(dependencies(node)); + } catch { case c: Cyclic => throw node :: c } finished += node () } else if (!finished(node)) diff --git a/internal/util-collection/src/main/scala/sbt/internal/util/IDSet.scala b/internal/util-collection/src/main/scala/sbt/internal/util/IDSet.scala index 789ef8c14..bf8d42ed3 100644 --- a/internal/util-collection/src/main/scala/sbt/internal/util/IDSet.scala +++ b/internal/util-collection/src/main/scala/sbt/internal/util/IDSet.scala @@ -48,7 +48,10 @@ object IDSet { def isEmpty = backing.isEmpty def process[S](t: T)(ifSeen: S)(ifNew: => S) = - if (contains(t)) ifSeen else { this += t; ifNew } + if (contains(t)) ifSeen + else { + this += t; ifNew + } override def toString = backing.toString } diff --git a/internal/util-collection/src/main/scala/sbt/internal/util/INode.scala b/internal/util-collection/src/main/scala/sbt/internal/util/INode.scala index 345f16eed..3f854f719 100644 --- a/internal/util-collection/src/main/scala/sbt/internal/util/INode.scala +++ b/internal/util-collection/src/main/scala/sbt/internal/util/INode.scala @@ -95,7 +95,9 @@ abstract class EvaluateSettings[ScopeType] { } private[this] def run0(work: => Unit): Unit = { - try { work } catch { case e: Throwable => complete.put(Some(e)) } + try { + work + } catch { case e: Throwable => complete.put(Some(e)) } workComplete() } diff --git a/internal/util-collection/src/main/scala/sbt/internal/util/Settings.scala b/internal/util-collection/src/main/scala/sbt/internal/util/Settings.scala index 2936a6296..5aa6f18e6 100644 --- a/internal/util-collection/src/main/scala/sbt/internal/util/Settings.scala +++ b/internal/util-collection/src/main/scala/sbt/internal/util/Settings.scala @@ -206,7 +206,9 @@ trait Init[ScopeType] { // order the initializations. cyclic references are detected here. val ordered: Seq[Compiled[_]] = sort(cMap) // evaluation: apply the initializations. - try { applyInits(ordered) } catch { + try { + applyInits(ordered) + } catch { case rru: RuntimeUndefined => throw Uninitialized(cMap.keys.toSeq, delegates, rru.undefined, true) } @@ -285,7 +287,9 @@ trait Init[ScopeType] { def executor = x } eval.run - } finally { x.shutdown() } + } finally { + x.shutdown() + } } def showUndefined( diff --git a/internal/util-collection/src/main/scala/sbt/internal/util/Signal.scala b/internal/util-collection/src/main/scala/sbt/internal/util/Signal.scala index c65d44199..857c38807 100644 --- a/internal/util-collection/src/main/scala/sbt/internal/util/Signal.scala +++ b/internal/util-collection/src/main/scala/sbt/internal/util/Signal.scala @@ -70,7 +70,9 @@ object Signals { private final class Signals0 { def supported(signal: String): Boolean = { import sun.misc.Signal - try { new Signal(signal); true } catch { case _: IllegalArgumentException => false } + try { + new Signal(signal); true + } catch { case _: IllegalArgumentException => false } } // returns a LinkageError in `action` as Left(t) in order to avoid it being @@ -85,6 +87,8 @@ private final class Signals0 { val oldHandler = Signal.handle(intSignal, newHandler) try Right(action()) - catch { case e: LinkageError => Left(e) } finally { Signal.handle(intSignal, oldHandler); () } + catch { case e: LinkageError => Left(e) } finally { + Signal.handle(intSignal, oldHandler); () + } } } diff --git a/internal/util-collection/src/test/scala/SettingsExample.scala b/internal/util-collection/src/test/scala/SettingsExample.scala index fea35b5ed..bcdc3916d 100644 --- a/internal/util-collection/src/test/scala/SettingsExample.scala +++ b/internal/util-collection/src/test/scala/SettingsExample.scala @@ -28,7 +28,9 @@ case class SettingsExample() extends Init[Scope] { val delegates: Scope => Seq[Scope] = { case s @ Scope(index, proj) => s +: (if (index <= 0) Nil - else { (if (proj > 0) List(Scope(index)) else Nil) ++: delegates(Scope(index - 1)) }) + else { + (if (proj > 0) List(Scope(index)) else Nil) ++: delegates(Scope(index - 1)) + }) } // Not using this feature in this example. diff --git a/internal/util-collection/src/test/scala/SettingsTest.scala b/internal/util-collection/src/test/scala/SettingsTest.scala index a2dde0f09..b0bda5dc8 100644 --- a/internal/util-collection/src/test/scala/SettingsTest.scala +++ b/internal/util-collection/src/test/scala/SettingsTest.scala @@ -158,7 +158,9 @@ object SettingsTest extends Properties("settings") { // property("Catches circular references") = forAll(chainLengthGen) { checkCircularReferences _ } final def checkCircularReferences(intermediate: Int): Prop = { val ccr = new CCR(intermediate) - try { evaluate(setting(chk, ccr.top) :: Nil); false } catch { + try { + evaluate(setting(chk, ccr.top) :: Nil); false + } catch { case _: java.lang.Exception => true } } @@ -195,7 +197,9 @@ object SettingsTest extends Properties("settings") { } def evaluate(settings: Seq[Setting[_]]): Settings[Scope] = - try { make(settings)(delegates, scopeLocal, showFullKey) } catch { + try { + make(settings)(delegates, scopeLocal, showFullKey) + } catch { case e: Throwable => e.printStackTrace(); throw e } } diff --git a/internal/util-complete/src/main/scala/sbt/internal/util/LineReader.scala b/internal/util-complete/src/main/scala/sbt/internal/util/LineReader.scala index ddf48ad34..549ded4d6 100644 --- a/internal/util-complete/src/main/scala/sbt/internal/util/LineReader.scala +++ b/internal/util-complete/src/main/scala/sbt/internal/util/LineReader.scala @@ -166,7 +166,11 @@ private[sbt] object JLine { def withJLine[T](action: => T): T = withTerminal { t => t.init - try { action } finally { t.restore } + try { + action + } finally { + t.restore + } } def simple( diff --git a/internal/util-complete/src/main/scala/sbt/internal/util/complete/History.scala b/internal/util-complete/src/main/scala/sbt/internal/util/complete/History.scala index 1613235ad..b65dba0dc 100644 --- a/internal/util-complete/src/main/scala/sbt/internal/util/complete/History.scala +++ b/internal/util-complete/src/main/scala/sbt/internal/util/complete/History.scala @@ -19,7 +19,10 @@ final class History private (val lines: IndexedSeq[String], val path: Option[Fil def !! : Option[String] = !-(1) def apply(i: Int): Option[String] = - if (0 <= i && i < size) Some(lines(i)) else { sys.error("Invalid history index: " + i) } + if (0 <= i && i < size) Some(lines(i)) + else { + sys.error("Invalid history index: " + i) + } def !(i: Int): Option[String] = apply(i) @@ -54,5 +57,7 @@ object History { new History(lines.toIndexedSeq, path) def number(s: String): Option[Int] = - try { Some(s.toInt) } catch { case _: NumberFormatException => None } + try { + Some(s.toInt) + } catch { case _: NumberFormatException => None } } diff --git a/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parser.scala b/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parser.scala index 8b5a860dc..9357b3e83 100644 --- a/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parser.scala +++ b/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parser.scala @@ -641,16 +641,28 @@ private final case class SoftInvalid(fail: Failure) extends ValidParser[Nothing] } private final class TrapAndFail[A](a: Parser[A]) extends ValidParser[A] { - def result = try { a.result } catch { case _: Exception => None } - def resultEmpty = try { a.resultEmpty } catch { case e: Exception => fail(e) } + def result = + try { + a.result + } catch { case _: Exception => None } + def resultEmpty = + try { + a.resultEmpty + } catch { case e: Exception => fail(e) } - def derive(c: Char) = try { trapAndFail(a derive c) } catch { - case e: Exception => Invalid(fail(e)) - } + def derive(c: Char) = + try { + trapAndFail(a derive c) + } catch { + case e: Exception => Invalid(fail(e)) + } - def completions(level: Int) = try { a.completions(level) } catch { - case _: Exception => Completions.nil - } + def completions(level: Int) = + try { + a.completions(level) + } catch { + case _: Exception => Completions.nil + } override def toString = "trap(" + a + ")" override def isTokenStart = a.isTokenStart diff --git a/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parsers.scala b/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parsers.scala index 789e545ba..eb68fa679 100644 --- a/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parsers.scala +++ b/internal/util-complete/src/main/scala/sbt/internal/util/complete/Parsers.scala @@ -264,7 +264,9 @@ trait Parsers { */ def mapOrFail[S, T](p: Parser[S])(f: S => T): Parser[T] = p flatMap { s => - try { success(f(s)) } catch { case e: Exception => failure(e.toString) } + try { + success(f(s)) + } catch { case e: Exception => failure(e.toString) } } /** diff --git a/main-actions/src/main/scala/sbt/RawCompileLike.scala b/main-actions/src/main/scala/sbt/RawCompileLike.scala index 8c46ffc24..59533a725 100644 --- a/main-actions/src/main/scala/sbt/RawCompileLike.scala +++ b/main-actions/src/main/scala/sbt/RawCompileLike.scala @@ -57,7 +57,7 @@ object RawCompileLike { FilesInfo[HashFileInfo] :+: FilesInfo[ModifiedFileInfo] :+: Seq[File] :+: File :+: Seq[String] :+: Int :+: HNil val inputs - : Inputs = hash(sources.toSet ++ optionFiles(options, fileInputOpts)) :+: lastModified( + : Inputs = hash(sources.toSet ++ optionFiles(options, fileInputOpts)) :+: lastModified( classpath.toSet ) :+: classpath :+: outputDirectory :+: options :+: maxErrors :+: HNil val cachedComp = inputChanged(cacheStoreFactory make "inputs") { (inChanged, in: Inputs) => diff --git a/main-actions/src/main/scala/sbt/Sync.scala b/main-actions/src/main/scala/sbt/Sync.scala index 780282119..b0a3f3b46 100644 --- a/main-actions/src/main/scala/sbt/Sync.scala +++ b/main-actions/src/main/scala/sbt/Sync.scala @@ -123,7 +123,9 @@ object Sync { def readInfo[F <: FileInfo]( store: CacheStore )(implicit infoFormat: JsonFormat[F]): RelationInfo[F] = - try { readUncaught[F](store)(infoFormat) } catch { + try { + readUncaught[F](store)(infoFormat) + } catch { case _: IOException => (Relation.empty[File, File], Map.empty[File, F]) case _: ZipException => (Relation.empty[File, File], Map.empty[File, F]) case e: TranslatedException => diff --git a/main-actions/src/main/scala/sbt/compiler/Eval.scala b/main-actions/src/main/scala/sbt/compiler/Eval.scala index 18ce0fac1..c024cf577 100644 --- a/main-actions/src/main/scala/sbt/compiler/Eval.scala +++ b/main-actions/src/main/scala/sbt/compiler/Eval.scala @@ -218,7 +218,11 @@ final class Eval( val extra = ev.read(cacheFile(back, moduleName)) (extra, loader) case _ => - try { compileAndLoad(run, unit, imports, backing, moduleName, ev) } finally { unlinkAll() } + try { + compileAndLoad(run, unit, imports, backing, moduleName, ev) + } finally { + unlinkAll() + } } val generatedFiles = getGeneratedFiles(backing, moduleName) diff --git a/main-actions/src/test/scala/sbt/compiler/EvalTest.scala b/main-actions/src/test/scala/sbt/compiler/EvalTest.scala index 27a670231..bb5a40af0 100644 --- a/main-actions/src/test/scala/sbt/compiler/EvalTest.scala +++ b/main-actions/src/test/scala/sbt/compiler/EvalTest.scala @@ -89,7 +89,7 @@ val p = { i => value(eval.eval("abs(" + i + ")", new EvalImports(imports.zipWithIndex, "imp"))) == math.abs( i - ) + ) private[this] def local(i: Int) = "{ class ETest(val i: Int); new ETest(" + i + ") }" val LocalType = "AnyRef{val i: Int}" diff --git a/main-settings/src/main/scala/sbt/Def.scala b/main-settings/src/main/scala/sbt/Def.scala index a42255f4e..a55ea4979 100644 --- a/main-settings/src/main/scala/sbt/Def.scala +++ b/main-settings/src/main/scala/sbt/Def.scala @@ -59,7 +59,7 @@ object Def extends Init[Scope] with TaskMacroExtra { key.scope, withColor(key.key.label, keyNameColor), ref => displayRelative2(current, ref) - ) + ) ) private[sbt] def showShortKey( @@ -81,7 +81,7 @@ object Def extends Init[Scope] with TaskMacroExtra { key.scope, withColor(key.key.label, keyNameColor), ref => displayShort(ref) - ) + ) ) } @@ -103,7 +103,7 @@ object Def extends Init[Scope] with TaskMacroExtra { key.scope, withColor(key.key.label, keyNameColor), ref => displayBuildRelative(currentBuild, ref) - ) + ) ) /** diff --git a/main-settings/src/main/scala/sbt/InputTask.scala b/main-settings/src/main/scala/sbt/InputTask.scala index 16866a652..3a43877bf 100644 --- a/main-settings/src/main/scala/sbt/InputTask.scala +++ b/main-settings/src/main/scala/sbt/InputTask.scala @@ -29,7 +29,7 @@ final class InputTask[T] private (val parser: State => Parser[Task[T]]) { case Left(msg) => val indented = msg.linesIterator.map(" " + _).mkString("\n") Parser.failure(s"Invalid programmatic input:\n$indented") - } + } ) } @@ -50,7 +50,7 @@ object InputTask { val indented = msg.linesIterator.map(" " + _).mkString("\n") sys.error(s"Invalid programmatic input:\n$indented") } - ) + ) ) ) } diff --git a/main-settings/src/main/scala/sbt/Scope.scala b/main-settings/src/main/scala/sbt/Scope.scala index f63661135..d241dcdfa 100644 --- a/main-settings/src/main/scala/sbt/Scope.scala +++ b/main-settings/src/main/scala/sbt/Scope.scala @@ -55,7 +55,7 @@ object Scope { subThis(thisScope.config, scope.config), subThis(thisScope.task, scope.task), subThis(thisScope.extra, scope.extra) - ) + ) def subThis[T](sub: ScopeAxis[T], into: ScopeAxis[T]): ScopeAxis[T] = if (into == This) sub else into @@ -273,8 +273,7 @@ object Scope { taskInherit: AttributeKey[_] => Seq[AttributeKey[_]], ): Scope => Seq[Scope] = { val index = delegates(refs, configurations, projectInherit, configInherit) - scope => - indexedDelegates(resolve, index, rootProject, taskInherit)(scope) + scope => indexedDelegates(resolve, index, rootProject, taskInherit)(scope) } @deprecated("Use variant without extraInherit", "1.1.1") diff --git a/main/src/main/scala/sbt/BackgroundJobService.scala b/main/src/main/scala/sbt/BackgroundJobService.scala index 6d3883fe3..b99f51a74 100644 --- a/main/src/main/scala/sbt/BackgroundJobService.scala +++ b/main/src/main/scala/sbt/BackgroundJobService.scala @@ -48,16 +48,15 @@ abstract class BackgroundJobService extends Closeable { object BackgroundJobService { private[sbt] def jobIdParser: (State, Seq[JobHandle]) => Parser[Seq[JobHandle]] = { import DefaultParsers._ - (state, handles) => - { - val stringIdParser: Parser[Seq[String]] = Space ~> token( - NotSpace examples handles.map(_.id.toString).toSet, - description = "" - ).+ - stringIdParser.map { strings => - strings.map(Integer.parseInt(_)).flatMap(id => handles.find(_.id == id)) - } + (state, handles) => { + val stringIdParser: Parser[Seq[String]] = Space ~> token( + NotSpace examples handles.map(_.id.toString).toSet, + description = "" + ).+ + stringIdParser.map { strings => + strings.map(Integer.parseInt(_)).flatMap(id => handles.find(_.id == id)) } + } } } diff --git a/main/src/main/scala/sbt/Defaults.scala b/main/src/main/scala/sbt/Defaults.scala index cfdddd6a7..c68addc6c 100755 --- a/main/src/main/scala/sbt/Defaults.scala +++ b/main/src/main/scala/sbt/Defaults.scala @@ -268,8 +268,7 @@ object Defaults extends BuildCommon { taskTemporaryDirectory := { val dir = IO.createTemporaryDirectory; dir.deleteOnExit(); dir }, onComplete := { val tempDirectory = taskTemporaryDirectory.value - () => - Clean.deleteContents(tempDirectory, _ => false) + () => Clean.deleteContents(tempDirectory, _ => false) }, useSuperShell := { if (insideCI.value) false else sbt.internal.TaskProgress.isEnabled }, progressReports := { (s: State) => @@ -295,8 +294,7 @@ object Defaults extends BuildCommon { Continuous.dynamicInputs := Continuous.dynamicInputsImpl.value, externalHooks := { val repository = fileTreeRepository.value - compileOptions => - Some(ExternalHooks(compileOptions, repository)) + compileOptions => Some(ExternalHooks(compileOptions, repository)) }, logBuffered :== false, commands :== Nil, @@ -757,7 +755,7 @@ object Defaults extends BuildCommon { ) ) lazy val testTasks - : Seq[Setting[_]] = testTaskOptions(test) ++ testTaskOptions(testOnly) ++ testTaskOptions( + : Seq[Setting[_]] = testTaskOptions(test) ++ testTaskOptions(testOnly) ++ testTaskOptions( testQuick ) ++ testDefaults ++ Seq( testLoader := ClassLoaders.testTask.value, @@ -1686,10 +1684,11 @@ object Defaults extends BuildCommon { private[sbt] def foldMappers[A](mappers: Seq[A => Option[A]]) = mappers.foldRight({ p: A => p - }) { (mapper, mappers) => - { p: A => - mapper(p).getOrElse(mappers(p)) - } + }) { + (mapper, mappers) => + { p: A => + mapper(p).getOrElse(mappers(p)) + } } private[sbt] def none[A]: Option[A] = (None: Option[A]) private[sbt] def jnone[A]: Optional[A] = none[A].toOptional @@ -2773,7 +2772,7 @@ object Classpaths { } ) implicit val RangePositionFormat - : IsoLList.Aux[RangePosition, String :*: LineRange :*: LNil] = LList.iso( + : IsoLList.Aux[RangePosition, String :*: LineRange :*: LNil] = LList.iso( { r: RangePosition => ("path", r.path) :*: ("range", r.range) :*: LNil }, { in: String :*: LineRange :*: LNil => @@ -3188,8 +3187,7 @@ object Classpaths { case _ => sys.error("Invalid configuration '" + confString + "'") // shouldn't get here } val m = ms.toMap - s => - m.getOrElse(s, Nil) + s => m.getOrElse(s, Nil) } def union[A, B](maps: Seq[A => Seq[B]]): A => Seq[B] = @@ -3365,12 +3363,16 @@ object Classpaths { // try/catch for supporting earlier launchers def bootIvyHome(app: xsbti.AppConfiguration): Option[File] = - try { Option(app.provider.scalaProvider.launcher.ivyHome) } catch { + try { + Option(app.provider.scalaProvider.launcher.ivyHome) + } catch { case _: NoSuchMethodError => None } def bootChecksums(app: xsbti.AppConfiguration): Vector[String] = - try { app.provider.scalaProvider.launcher.checksums.toVector } catch { + try { + app.provider.scalaProvider.launcher.checksums.toVector + } catch { case _: NoSuchMethodError => IvySbt.DefaultChecksums } @@ -3380,23 +3382,33 @@ object Classpaths { /** Loads the `appRepositories` configured for this launcher, if supported. */ def appRepositories(app: xsbti.AppConfiguration): Option[Vector[Resolver]] = - try { Some(app.provider.scalaProvider.launcher.appRepositories.toVector map bootRepository) } catch { + try { + Some(app.provider.scalaProvider.launcher.appRepositories.toVector map bootRepository) + } catch { case _: NoSuchMethodError => None } def bootRepositories(app: xsbti.AppConfiguration): Option[Vector[Resolver]] = - try { Some(app.provider.scalaProvider.launcher.ivyRepositories.toVector map bootRepository) } catch { + try { + Some(app.provider.scalaProvider.launcher.ivyRepositories.toVector map bootRepository) + } catch { case _: NoSuchMethodError => None } private[this] def mavenCompatible(ivyRepo: xsbti.IvyRepository): Boolean = - try { ivyRepo.mavenCompatible } catch { case _: NoSuchMethodError => false } + try { + ivyRepo.mavenCompatible + } catch { case _: NoSuchMethodError => false } private[this] def skipConsistencyCheck(ivyRepo: xsbti.IvyRepository): Boolean = - try { ivyRepo.skipConsistencyCheck } catch { case _: NoSuchMethodError => false } + try { + ivyRepo.skipConsistencyCheck + } catch { case _: NoSuchMethodError => false } private[this] def descriptorOptional(ivyRepo: xsbti.IvyRepository): Boolean = - try { ivyRepo.descriptorOptional } catch { case _: NoSuchMethodError => false } + try { + ivyRepo.descriptorOptional + } catch { case _: NoSuchMethodError => false } private[this] def bootRepository(repo: xsbti.Repository): Resolver = { import xsbti.Predefined diff --git a/main/src/main/scala/sbt/EvaluateTask.scala b/main/src/main/scala/sbt/EvaluateTask.scala index ca08ee093..a6fab3b55 100644 --- a/main/src/main/scala/sbt/EvaluateTask.scala +++ b/main/src/main/scala/sbt/EvaluateTask.scala @@ -367,7 +367,11 @@ object EvaluateTask { def withStreams[T](structure: BuildStructure, state: State)(f: Streams => T): T = { val str = std.Streams.closeable(structure.streams(state)) - try { f(str) } finally { str.close() } + try { + f(str) + } finally { + str.close() + } } def getTask[T]( @@ -585,5 +589,5 @@ object EvaluateTask { (transitiveClasspathDependency in scoped.scope := { () }) :: Nil } else { Nil - } + } } diff --git a/main/src/main/scala/sbt/Main.scala b/main/src/main/scala/sbt/Main.scala index dd58fec86..943a17736 100644 --- a/main/src/main/scala/sbt/Main.scala +++ b/main/src/main/scala/sbt/Main.scala @@ -624,7 +624,9 @@ object BuiltinCommands { catch { case NonFatal(e) => try export0(s) - finally { throw e } + finally { + throw e + } } export0(newS) } @@ -704,7 +706,7 @@ object BuiltinCommands { s => CommandStrings.showHelp ++ CommandStrings.printHelp ++ CommandStrings.multiTaskHelp ++ keysHelp( s - ) + ) def keysHelp(s: State): Help = if (Project.isProjectLoaded(s)) @@ -850,7 +852,7 @@ object BuiltinCommands { if (version != app.id.version()) { state.log.warn(s"""sbt version mismatch, current: ${app.id .version()}, in build.properties: "$version", use 'reboot' to use the new value.""") - } + } ) } diff --git a/main/src/main/scala/sbt/Plugins.scala b/main/src/main/scala/sbt/Plugins.scala index 086e521c7..93666c953 100644 --- a/main/src/main/scala/sbt/Plugins.scala +++ b/main/src/main/scala/sbt/Plugins.scala @@ -189,49 +189,48 @@ object Plugins extends PluginsFunctions { val allEnabledByClause = defined.filterNot(_.isRoot).flatMap(d => asEnabledByClauses(d)) // Note: Here is where the function begins. We're given a list of plugins now. - (requestedPlugins, log) => - { - timed("Plugins.deducer#function", log) { - def explicitlyDisabled(p: AutoPlugin): Boolean = hasExclude(requestedPlugins, p) - val alwaysEnabled: List[AutoPlugin] = - defined.filter(_.isAlwaysEnabled).filterNot(explicitlyDisabled) - val knowledge0: Set[Atom] = ((flatten(requestedPlugins) ++ alwaysEnabled) collect { - case x: AutoPlugin => Atom(x.label) - }).toSet - val clauses = Clauses((allRequirementsClause ::: allEnabledByClause) filterNot { - _.head subsetOf knowledge0 - }) - log.debug( - s"deducing auto plugins based on known facts ${knowledge0.toString} and clauses ${clauses.toString}" - ) - Logic.reduce( - clauses, - (flattenConvert(requestedPlugins) ++ convertAll(alwaysEnabled)).toSet - ) match { - case Left(problem) => throw AutoPluginException(problem) - case Right(results) => - log.debug(s" :: deduced result: ${results}") - val selectedAtoms: List[Atom] = results.ordered - val selectedPlugins = selectedAtoms map { a => - byAtomMap.getOrElse( - a, - throw AutoPluginException(s"${a} was not found in atom map.") - ) - } - val forbidden: Set[AutoPlugin] = - (selectedPlugins flatMap { Plugins.asExclusions }).toSet - val c = selectedPlugins.toSet & forbidden - if (c.nonEmpty) { - exclusionConflictError(requestedPlugins, selectedPlugins, c.toSeq sortBy { - _.label - }) - } - val retval = topologicalSort(selectedPlugins) - // log.debug(s" :: sorted deduced result: ${retval.toString}") - retval - } + (requestedPlugins, log) => { + timed("Plugins.deducer#function", log) { + def explicitlyDisabled(p: AutoPlugin): Boolean = hasExclude(requestedPlugins, p) + val alwaysEnabled: List[AutoPlugin] = + defined.filter(_.isAlwaysEnabled).filterNot(explicitlyDisabled) + val knowledge0: Set[Atom] = ((flatten(requestedPlugins) ++ alwaysEnabled) collect { + case x: AutoPlugin => Atom(x.label) + }).toSet + val clauses = Clauses((allRequirementsClause ::: allEnabledByClause) filterNot { + _.head subsetOf knowledge0 + }) + log.debug( + s"deducing auto plugins based on known facts ${knowledge0.toString} and clauses ${clauses.toString}" + ) + Logic.reduce( + clauses, + (flattenConvert(requestedPlugins) ++ convertAll(alwaysEnabled)).toSet + ) match { + case Left(problem) => throw AutoPluginException(problem) + case Right(results) => + log.debug(s" :: deduced result: ${results}") + val selectedAtoms: List[Atom] = results.ordered + val selectedPlugins = selectedAtoms map { a => + byAtomMap.getOrElse( + a, + throw AutoPluginException(s"${a} was not found in atom map.") + ) + } + val forbidden: Set[AutoPlugin] = + (selectedPlugins flatMap { Plugins.asExclusions }).toSet + val c = selectedPlugins.toSet & forbidden + if (c.nonEmpty) { + exclusionConflictError(requestedPlugins, selectedPlugins, c.toSeq sortBy { + _.label + }) + } + val retval = topologicalSort(selectedPlugins) + // log.debug(s" :: sorted deduced result: ${retval.toString}") + retval } } + } } private[sbt] def topologicalSort(ns: List[AutoPlugin]): List[AutoPlugin] = { diff --git a/main/src/main/scala/sbt/Project.scala b/main/src/main/scala/sbt/Project.scala index 09c1546ca..9a55a760a 100755 --- a/main/src/main/scala/sbt/Project.scala +++ b/main/src/main/scala/sbt/Project.scala @@ -837,7 +837,7 @@ object Project extends ProjectExtra { task, (state, value) => persistAndSet(resolveContext(key, scoped.scope, state), state, value)(f) - ) + ) ) } diff --git a/main/src/main/scala/sbt/ScopeFilter.scala b/main/src/main/scala/sbt/ScopeFilter.scala index 623dffa8c..8e7a4e7a1 100644 --- a/main/src/main/scala/sbt/ScopeFilter.scala +++ b/main/src/main/scala/sbt/ScopeFilter.scala @@ -40,8 +40,7 @@ object ScopeFilter { val pf = projects(data) val cf = configurations(data) val tf = tasks(data) - s => - pf(s.project) && cf(s.config) && tf(s.task) + s => pf(s.project) && cf(s.config) && tf(s.task) } } @@ -49,12 +48,11 @@ object ScopeFilter { new ScopeFilter { private[sbt] def apply(data: Data): Scope => Boolean = { val d = delegate(data) - scope => - { - val accept = d(scope) - println((if (accept) "ACCEPT " else "reject ") + scope) - accept - } + scope => { + val accept = d(scope) + println((if (accept) "ACCEPT " else "reject ") + scope) + accept + } } } @@ -203,7 +201,7 @@ object ScopeFilter { (p, thisRef) match { case (ThisProject, Some(pref)) => pref case _ => Scope.resolveProjectRef(current, rootProject, p) - } + } new Data(build.units, resolve, scopes) } @@ -216,7 +214,7 @@ object ScopeFilter { Project.getProject(ref, structure).toList flatMap { p => (if (classpath) p.dependencies.map(_.project) else Nil) ++ (if (aggregate) p.aggregate else Nil) - } + } private[this] def byDeps( ref: ProjectReference, @@ -273,8 +271,7 @@ object ScopeFilter { private[sbt] def apply(data: Data): In => Boolean = { val a = self(data) val b = other(data) - s => - a(s) && b(s) + s => a(s) && b(s) } } @@ -283,8 +280,7 @@ object ScopeFilter { private[sbt] def apply(data: Data): In => Boolean = { val a = self(data) val b = other(data) - s => - a(s) || b(s) + s => a(s) || b(s) } } @@ -292,8 +288,7 @@ object ScopeFilter { def unary_- : Base[In] = new Base[In] { private[sbt] def apply(data: Data): In => Boolean = { val a = self(data) - s => - !a(s) + s => !a(s) } } } diff --git a/main/src/main/scala/sbt/ScriptedPlugin.scala b/main/src/main/scala/sbt/ScriptedPlugin.scala index f3c4163dc..f602cab5b 100644 --- a/main/src/main/scala/sbt/ScriptedPlugin.scala +++ b/main/src/main/scala/sbt/ScriptedPlugin.scala @@ -126,7 +126,7 @@ object ScriptedPlugin extends AutoPlugin { import DefaultParsers._ val scriptedFiles - : NameFilter = ("test": NameFilter) | "test.script" | "pending" | "pending.script" + : NameFilter = ("test": NameFilter) | "test.script" | "pending" | "pending.script" val pairs = (scriptedBase * AllPassFilter * AllPassFilter * scriptedFiles).get map { (f: File) => val p = f.getParentFile diff --git a/main/src/main/scala/sbt/SessionVar.scala b/main/src/main/scala/sbt/SessionVar.scala index 6a29086dc..a9a04607a 100644 --- a/main/src/main/scala/sbt/SessionVar.scala +++ b/main/src/main/scala/sbt/SessionVar.scala @@ -64,7 +64,9 @@ object SessionVar { def read[T](key: ScopedKey[Task[T]], state: State)(implicit f: JsonFormat[T]): Option[T] = Project.structure(state).streams(state).use(key) { s => - try { Some(s.getInput(key, DefaultDataID).read[T]) } catch { case NonFatal(_) => None } + try { + Some(s.getInput(key, DefaultDataID).read[T]) + } catch { case NonFatal(_) => None } } def load[T](key: ScopedKey[Task[T]], state: State)(implicit f: JsonFormat[T]): Option[T] = diff --git a/main/src/main/scala/sbt/TemplateCommandUtil.scala b/main/src/main/scala/sbt/TemplateCommandUtil.scala index e32837275..0246d015d 100644 --- a/main/src/main/scala/sbt/TemplateCommandUtil.scala +++ b/main/src/main/scala/sbt/TemplateCommandUtil.scala @@ -117,7 +117,9 @@ private[sbt] object TemplateCommandUtil { val interfaceClass = getInterfaceClass(interfaceClassName, loader) val interface = interfaceClass.getDeclaredConstructor().newInstance().asInstanceOf[AnyRef] val method = interfaceClass.getMethod(methodName, argTypes: _*) - try { method.invoke(interface, args: _*) } catch { + try { + method.invoke(interface, args: _*) + } catch { case e: InvocationTargetException => throw e.getCause } } diff --git a/main/src/main/scala/sbt/Watch.scala b/main/src/main/scala/sbt/Watch.scala index d9bdab1bb..6acebe47b 100644 --- a/main/src/main/scala/sbt/Watch.scala +++ b/main/src/main/scala/sbt/Watch.scala @@ -261,7 +261,7 @@ object Watch { case Update(prev, cur, _) if prev.value != cur.value => action case _: Creation[_] | _: Deletion[_] => action case _ => Ignore - } + } /** * The minimum delay between build triggers for the same file. If the file is detected diff --git a/main/src/main/scala/sbt/internal/AddSettings.scala b/main/src/main/scala/sbt/internal/AddSettings.scala index 71d42ac59..2fd4a6667 100644 --- a/main/src/main/scala/sbt/internal/AddSettings.scala +++ b/main/src/main/scala/sbt/internal/AddSettings.scala @@ -27,7 +27,7 @@ object AddSettings { /** Adds all settings from autoplugins. */ val autoPlugins - : AddSettings = new AutoPlugins(const(true)) // Note: We do not expose fine-grained autoplugins because + : AddSettings = new AutoPlugins(const(true)) // Note: We do not expose fine-grained autoplugins because // it's dangerous to control at that level right now. // Leaving the hook in place in case we need to expose // it, but most likely it will remain locked out diff --git a/main/src/main/scala/sbt/internal/Clean.scala b/main/src/main/scala/sbt/internal/Clean.scala index 0173fe9d8..03ec356e3 100644 --- a/main/src/main/scala/sbt/internal/Clean.scala +++ b/main/src/main/scala/sbt/internal/Clean.scala @@ -64,19 +64,16 @@ object Clean { // Don't use a regular logger because the logger actually writes to the target directory. val debug = (logLevel in scope).?.value.orElse(state.value.get(logLevel.key)) match { case Some(Level.Debug) => - (string: String) => - println(s"[debug] $string") + (string: String) => println(s"[debug] $string") case _ => - (_: String) => - {} + (_: String) => {} } val delete = tryDelete(debug) cleanFiles.value.sorted.reverseIterator.foreach(delete) (fileOutputs in scope).value.foreach { g => val filter: TypedPath => Boolean = { val globFilter = g.toTypedPathFilter - tp => - !globFilter(tp) || excludeFilter(tp) + tp => !globFilter(tp) || excludeFilter(tp) } deleteContents(g.base.toFile, filter, FileTreeView.DEFAULT, delete) delete(g.base.toFile) diff --git a/main/src/main/scala/sbt/internal/Continuous.scala b/main/src/main/scala/sbt/internal/Continuous.scala index 7123525ea..f5e5ef2e3 100644 --- a/main/src/main/scala/sbt/internal/Continuous.scala +++ b/main/src/main/scala/sbt/internal/Continuous.scala @@ -456,14 +456,13 @@ object Continuous extends DeprecatedContinuous { } } } - () => - { - val res = f.view.map(_()).min - // Print the default watch message if there are multiple tasks - if (configs.size > 1) - Watch.defaultStartWatch(count.get(), project, commands).foreach(logger.info(_)) - res - } + () => { + val res = f.view.map(_()).min + // Print the default watch message if there are multiple tasks + if (configs.size > 1) + Watch.defaultStartWatch(count.get(), project, commands).foreach(logger.info(_)) + res + } } private def getFileEvents( configs: Seq[Config], @@ -500,11 +499,9 @@ object Continuous extends DeprecatedContinuous { if (excludedBuildFilter(entry)) onMetaBuildEvent(c, event) else Watch.Ignore ).min } - event: Event => - event -> oe(event) + event: Event => event -> oe(event) } - event: Event => - f.view.map(_.apply(event)).minBy(_._2) + event: Event => f.view.map(_.apply(event)).minBy(_._2) } val monitor: FileEventMonitor[FileAttributes] = new FileEventMonitor[FileAttributes] { @@ -654,26 +651,23 @@ object Continuous extends DeprecatedContinuous { .map { inputStreamKey => val is = extracted.runTask(inputStreamKey, state)._2 val handler = c.watchSettings.inputHandler.getOrElse(defaultInputHandler(inputParser)) - () => - handler(is) + () => handler(is) } .getOrElse(() => Watch.Ignore) - (string: String) => - (default(string) :: alternative() :: Nil).min + (string: String) => (default(string) :: alternative() :: Nil).min + } + () => { + val stringBuilder = new StringBuilder + while (inputStream.available > 0) stringBuilder += inputStream.read().toChar + val newBytes = stringBuilder.toString + val parse: ActionParser => Watch.Action = parser => parser(newBytes) + val allEvents = inputHandlers.map(parse).filterNot(_ == Watch.Ignore) + if (allEvents.exists(_ != Watch.Ignore)) { + val res = allEvents.min + logger.debug(s"Received input events: ${allEvents mkString ","}. Taking $res") + res + } else Watch.Ignore } - () => - { - val stringBuilder = new StringBuilder - while (inputStream.available > 0) stringBuilder += inputStream.read().toChar - val newBytes = stringBuilder.toString - val parse: ActionParser => Watch.Action = parser => parser(newBytes) - val allEvents = inputHandlers.map(parse).filterNot(_ == Watch.Ignore) - if (allEvents.exists(_ != Watch.Ignore)) { - val res = allEvents.min - logger.debug(s"Received input events: ${allEvents mkString ","}. Taking $res") - res - } else Watch.Ignore - } } private def combineInputAndFileEvents( diff --git a/main/src/main/scala/sbt/internal/EvaluateConfigurations.scala b/main/src/main/scala/sbt/internal/EvaluateConfigurations.scala index 5fcc13f76..862cb52ed 100644 --- a/main/src/main/scala/sbt/internal/EvaluateConfigurations.scala +++ b/main/src/main/scala/sbt/internal/EvaluateConfigurations.scala @@ -119,8 +119,7 @@ private[sbt] object EvaluateConfigurations { offset: Int ): LazyClassLoaded[Seq[Setting[_]]] = { val l = evaluateSbtFile(eval, file, lines, imports, offset) - loader => - l(loader).settings + loader => l(loader).settings } /** @@ -160,36 +159,35 @@ private[sbt] object EvaluateConfigurations { eval.unlinkDeferred() // Tracks all the files we generated from evaluating the sbt file. val allGeneratedFiles = (definitions.generated ++ dslEntries.flatMap(_.generated)) - loader => - { - val projects = { - val compositeProjects = definitions.values(loader).collect { - case p: CompositeProject => p - } - CompositeProject.expand(compositeProjects).map(resolveBase(file.getParentFile, _)) + loader => { + val projects = { + val compositeProjects = definitions.values(loader).collect { + case p: CompositeProject => p } - val (settingsRaw, manipulationsRaw) = - dslEntries map (_.result apply loader) partition { - case DslEntry.ProjectSettings(_) => true - case _ => false - } - val settings = settingsRaw flatMap { - case DslEntry.ProjectSettings(settings) => settings - case _ => Nil - } - val manipulations = manipulationsRaw map { - case DslEntry.ProjectManipulation(f) => f - } - // TODO -get project manipulations. - new LoadedSbtFile( - settings, - projects, - importDefs, - manipulations, - definitions, - allGeneratedFiles - ) + CompositeProject.expand(compositeProjects).map(resolveBase(file.getParentFile, _)) } + val (settingsRaw, manipulationsRaw) = + dslEntries map (_.result apply loader) partition { + case DslEntry.ProjectSettings(_) => true + case _ => false + } + val settings = settingsRaw flatMap { + case DslEntry.ProjectSettings(settings) => settings + case _ => Nil + } + val manipulations = manipulationsRaw map { + case DslEntry.ProjectManipulation(f) => f + } + // TODO -get project manipulations. + new LoadedSbtFile( + settings, + projects, + importDefs, + manipulations, + definitions, + allGeneratedFiles + ) + } } /** move a project to be relative to this file after we've evaluated it. */ @@ -337,7 +335,7 @@ object Index { case AttributeEntry(key, value: Task[_]) => (value, ScopedKey(scope, key.asInstanceOf[AttributeKey[Task[_]]])) } - ) + ) pairs.toMap[Task[_], ScopedKey[Task[_]]] } diff --git a/main/src/main/scala/sbt/internal/Inspect.scala b/main/src/main/scala/sbt/internal/Inspect.scala index 02866698f..ecc84b5b3 100644 --- a/main/src/main/scala/sbt/internal/Inspect.scala +++ b/main/src/main/scala/sbt/internal/Inspect.scala @@ -31,7 +31,7 @@ object Inspect { (s: State) => spacedModeParser(s) flatMap { mode => commandHandler(s, mode) | keyHandler(s)(mode) - } + } val spacedModeParser: State => Parser[Mode] = (_: State) => { val default = "-" ^^^ Details(false) val actual = "actual" ^^^ Details(true) diff --git a/main/src/main/scala/sbt/internal/Load.scala b/main/src/main/scala/sbt/internal/Load.scala index 59c381326..89a5ae35b 100755 --- a/main/src/main/scala/sbt/internal/Load.scala +++ b/main/src/main/scala/sbt/internal/Load.scala @@ -132,7 +132,9 @@ private[sbt] object Load { } private def bootIvyHome(app: xsbti.AppConfiguration): Option[File] = - try { Option(app.provider.scalaProvider.launcher.ivyHome) } catch { + try { + Option(app.provider.scalaProvider.launcher.ivyHome) + } catch { case _: NoSuchMethodError => None } @@ -176,14 +178,13 @@ private[sbt] object Load { val imports = BuildUtil.baseImports ++ config.detectedGlobalPlugins.imports - loader => - { - val loaded = EvaluateConfigurations(eval, files, imports)(loader) - // TODO - We have a potential leak of config-classes in the global directory right now. - // We need to find a way to clean these safely, or at least warn users about - // unused class files that could be cleaned when multiple sbt instances are not running. - loaded.settings - } + loader => { + val loaded = EvaluateConfigurations(eval, files, imports)(loader) + // TODO - We have a potential leak of config-classes in the global directory right now. + // We need to find a way to clean these safely, or at least warn users about + // unused class files that could be cleaned when multiple sbt instances are not running. + loaded.settings + } } def loadGlobal( state: State, @@ -303,13 +304,13 @@ private[sbt] object Load { case tk: Task[t] => setDefinitionKey(tk, key).asInstanceOf[T] case ik: InputTask[t] => ik.mapTask(tk => setDefinitionKey(tk, key)).asInstanceOf[T] case _ => value - } + } def setResolved(defining: ScopedKey[_]) = λ[ScopedKey ~> Option]( (key: ScopedKey[_]) => key.key match { case resolvedScoped.key => Some(defining.asInstanceOf[A1$]) case _ => None - } + } ) ss.map( s => s mapConstant setResolved(s.key) mapReferenced mapSpecial(s.key) mapInit setDefining @@ -421,8 +422,7 @@ private[sbt] object Load { def lazyEval(unit: BuildUnit): () => Eval = { lazy val eval = mkEval(unit) - () => - eval + () => eval } def mkEval(unit: BuildUnit): Eval = @@ -616,8 +616,7 @@ private[sbt] object Load { checkProjectBase(against, fResolved) fResolved } - p => - p.copy(base = resolve(p.base)) + p => p.copy(base = resolve(p.base)) } def resolveProjects(loaded: PartBuild): LoadedBuild = { diff --git a/main/src/main/scala/sbt/internal/Resolve.scala b/main/src/main/scala/sbt/internal/Resolve.scala index cd7ce4d6c..211c0f9dd 100644 --- a/main/src/main/scala/sbt/internal/Resolve.scala +++ b/main/src/main/scala/sbt/internal/Resolve.scala @@ -24,8 +24,7 @@ object Resolve { :: resolveConfig(index, key, mask) _ :: Nil ) - scope => - rs.foldLeft(scope)((s, f) => f(s)) + scope => rs.foldLeft(scope)((s, f) => f(s)) } def resolveTask(mask: ScopeMask)(scope: Scope): Scope = diff --git a/main/src/main/scala/sbt/internal/TaskProgress.scala b/main/src/main/scala/sbt/internal/TaskProgress.scala index 39f9fa7ee..438e1f287 100644 --- a/main/src/main/scala/sbt/internal/TaskProgress.scala +++ b/main/src/main/scala/sbt/internal/TaskProgress.scala @@ -130,7 +130,7 @@ private[sbt] object TaskProgress { case LogOption.Always => Some(true) case LogOption.Never => Some(false) case _ => None - } + } ) .getOrElse(true) } diff --git a/main/src/main/scala/sbt/internal/server/NetworkChannel.scala b/main/src/main/scala/sbt/internal/server/NetworkChannel.scala index 34aac577d..f7613541e 100644 --- a/main/src/main/scala/sbt/internal/server/NetworkChannel.scala +++ b/main/src/main/scala/sbt/internal/server/NetworkChannel.scala @@ -211,7 +211,7 @@ final class NetworkChannel( errorDesc => log.error( s"Got invalid chunk from client (${new String(chunk.toArray, "UTF-8")}): " + errorDesc - ), + ), onCommand ) case _ => diff --git a/main/src/main/scala/sbt/internal/server/SettingQuery.scala b/main/src/main/scala/sbt/internal/server/SettingQuery.scala index 28c73b1ef..e233e3804 100644 --- a/main/src/main/scala/sbt/internal/server/SettingQuery.scala +++ b/main/src/main/scala/sbt/internal/server/SettingQuery.scala @@ -118,7 +118,7 @@ object SettingQuery { getJsonWriter(key.key) map { implicit jw: JsonWriter[A] => toJson(value) } - ) + ) def handleSettingQueryEither( req: SettingQuery, diff --git a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcNotificationMessageFormats.scala b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcNotificationMessageFormats.scala index a19c85833..07a8b1f64 100644 --- a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcNotificationMessageFormats.scala +++ b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcNotificationMessageFormats.scala @@ -13,7 +13,7 @@ import sjsonnew.shaded.scalajson.ast.unsafe.JValue trait JsonRpcNotificationMessageFormats { self: sbt.internal.util.codec.JValueFormats with sjsonnew.BasicJsonProtocol => implicit lazy val JsonRpcNotificationMessageFormat - : JsonFormat[sbt.internal.protocol.JsonRpcNotificationMessage] = + : JsonFormat[sbt.internal.protocol.JsonRpcNotificationMessage] = new JsonFormat[sbt.internal.protocol.JsonRpcNotificationMessage] { override def read[J]( jsOpt: Option[J], diff --git a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcRequestMessageFormats.scala b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcRequestMessageFormats.scala index 6ffb60830..829b8d2a4 100644 --- a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcRequestMessageFormats.scala +++ b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcRequestMessageFormats.scala @@ -13,7 +13,7 @@ import sjsonnew.{ Builder, DeserializationException, JsonFormat, Unbuilder, dese trait JsonRpcRequestMessageFormats { self: sbt.internal.util.codec.JValueFormats with sjsonnew.BasicJsonProtocol => implicit lazy val JsonRpcRequestMessageFormat - : JsonFormat[sbt.internal.protocol.JsonRpcRequestMessage] = + : JsonFormat[sbt.internal.protocol.JsonRpcRequestMessage] = new JsonFormat[sbt.internal.protocol.JsonRpcRequestMessage] { override def read[J]( jsOpt: Option[J], diff --git a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseErrorFormats.scala b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseErrorFormats.scala index 885187970..6d54a55ab 100644 --- a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseErrorFormats.scala +++ b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseErrorFormats.scala @@ -13,7 +13,7 @@ import sjsonnew.shaded.scalajson.ast.unsafe.JValue trait JsonRpcResponseErrorFormats { self: sbt.internal.util.codec.JValueFormats with sjsonnew.BasicJsonProtocol => implicit lazy val JsonRpcResponseErrorFormat - : JsonFormat[sbt.internal.protocol.JsonRpcResponseError] = + : JsonFormat[sbt.internal.protocol.JsonRpcResponseError] = new JsonFormat[sbt.internal.protocol.JsonRpcResponseError] { override def read[J]( jsOpt: Option[J], diff --git a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseMessageFormats.scala b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseMessageFormats.scala index beabf1512..3ea29d13b 100644 --- a/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseMessageFormats.scala +++ b/protocol/src/main/scala/sbt/internal/protocol/codec/JsonRpcResponseMessageFormats.scala @@ -21,7 +21,7 @@ trait JsonRpcResponseMessageFormats { with sbt.internal.protocol.codec.JsonRpcResponseErrorFormats with sjsonnew.BasicJsonProtocol => implicit lazy val JsonRpcResponseMessageFormat - : JsonFormat[sbt.internal.protocol.JsonRpcResponseMessage] = + : JsonFormat[sbt.internal.protocol.JsonRpcResponseMessage] = new JsonFormat[sbt.internal.protocol.JsonRpcResponseMessage] { override def read[J]( jsOpt: Option[J], diff --git a/run/src/main/scala/sbt/Run.scala b/run/src/main/scala/sbt/Run.scala index a1aef0668..22883d43d 100644 --- a/run/src/main/scala/sbt/Run.scala +++ b/run/src/main/scala/sbt/Run.scala @@ -68,7 +68,9 @@ class Run(newLoader: Seq[File] => ClassLoader, trapExit: Boolean) extends ScalaR log.info("Running " + mainClass + " " + options.mkString(" ")) def execute() = - try { run0(mainClass, classpath, options, log) } catch { + try { + run0(mainClass, classpath, options, log) + } catch { case e: java.lang.reflect.InvocationTargetException => throw e.getCause } def directExecute(): Try[Unit] = @@ -109,7 +111,9 @@ class Run(newLoader: Seq[File] => ClassLoader, trapExit: Boolean) extends ScalaR val currentThread = Thread.currentThread val oldLoader = Thread.currentThread.getContextClassLoader currentThread.setContextClassLoader(loader) - try { main.invoke(null, options.toArray[String]); () } catch { + try { + main.invoke(null, options.toArray[String]); () + } catch { case t: Throwable => t.getCause match { case e: java.lang.IllegalAccessError => diff --git a/run/src/main/scala/sbt/TrapExit.scala b/run/src/main/scala/sbt/TrapExit.scala index 00f17b77c..ea41e7259 100644 --- a/run/src/main/scala/sbt/TrapExit.scala +++ b/run/src/main/scala/sbt/TrapExit.scala @@ -59,7 +59,9 @@ object TrapExit { private[this] def runUnmanaged(execute: => Unit, log: Logger): Int = { log.warn("Managed execution not possible: security manager not installed.") - try { execute; 0 } catch { + try { + execute; 0 + } catch { case e: Exception => log.error("Error during execution: " + e.toString) log.trace(e) @@ -153,7 +155,9 @@ private final class TrapExit(delegateManager: SecurityManager) extends SecurityM def runManaged(f: Supplier[Unit], xlog: xsbti.Logger): Int = { val _ = running.incrementAndGet() try runManaged0(f, xlog) - finally { running.decrementAndGet(); () } + finally { + running.decrementAndGet(); () + } } private[this] def runManaged0(f: Supplier[Unit], xlog: xsbti.Logger): Int = { val log: Logger = xlog diff --git a/sbt/src/test/scala/testpkg/ServerSpec.scala b/sbt/src/test/scala/testpkg/ServerSpec.scala index da78827fd..f7e87331d 100644 --- a/sbt/src/test/scala/testpkg/ServerSpec.scala +++ b/sbt/src/test/scala/testpkg/ServerSpec.scala @@ -176,10 +176,14 @@ object TestServer { try { f(testServer) } finally { - try { testServer.bye() } finally {} + try { + testServer.bye() + } finally {} } case _ => - try { testServer.bye() } finally {} + try { + testServer.bye() + } finally {} hostLog("Server started but not connected properly... restarting...") withTestServer(testBuild)(f) } diff --git a/scripted-sbt-redux/src/main/scala/sbt/scriptedtest/ScriptedTests.scala b/scripted-sbt-redux/src/main/scala/sbt/scriptedtest/ScriptedTests.scala index 89dae6604..db1727a2a 100644 --- a/scripted-sbt-redux/src/main/scala/sbt/scriptedtest/ScriptedTests.scala +++ b/scripted-sbt-redux/src/main/scala/sbt/scriptedtest/ScriptedTests.scala @@ -61,22 +61,21 @@ final class ScriptedTests( val g = groupDir.getName val n = nme.getName val label = s"$g / $n" - () => - { - println(s"Running $label") - val result = testResources.readWriteResourceDirectory(g, n) { testDirectory => - val buffer = new BufferedLogger(new FullLogger(log)) - val singleTestRunner = () => { - val handlers = - createScriptedHandlers(testDirectory, buffer, RemoteSbtCreatorKind.LauncherBased) - val runner = new BatchScriptRunner - val states = new mutable.HashMap[StatementHandler, StatementHandler#State]() - commonRunTest(label, testDirectory, prescripted, handlers, runner, states, buffer) - } - runOrHandleDisabled(label, testDirectory, singleTestRunner, buffer) + () => { + println(s"Running $label") + val result = testResources.readWriteResourceDirectory(g, n) { testDirectory => + val buffer = new BufferedLogger(new FullLogger(log)) + val singleTestRunner = () => { + val handlers = + createScriptedHandlers(testDirectory, buffer, RemoteSbtCreatorKind.LauncherBased) + val runner = new BatchScriptRunner + val states = new mutable.HashMap[StatementHandler, StatementHandler#State]() + commonRunTest(label, testDirectory, prescripted, handlers, runner, states, buffer) } - Seq(result) + runOrHandleDisabled(label, testDirectory, singleTestRunner, buffer) } + Seq(result) + } } } @@ -140,7 +139,7 @@ final class ScriptedTests( def logTests(size: Int, how: String) = log.info( - f"Running $size / $totalSize (${size * 100D / totalSize}%3.2f%%) scripted tests with $how" + f"Running $size / $totalSize (${size * 100d / totalSize}%3.2f%%) scripted tests with $how" ) logTests(runFromSourceBasedTests.size, "RunFromSourceMain") logTests(launcherBasedTests.size, "sbt/launcher") diff --git a/tasks-standard/src/main/scala/sbt/std/Streams.scala b/tasks-standard/src/main/scala/sbt/std/Streams.scala index 1c0f9be15..2cf08dce4 100644 --- a/tasks-standard/src/main/scala/sbt/std/Streams.scala +++ b/tasks-standard/src/main/scala/sbt/std/Streams.scala @@ -100,13 +100,19 @@ trait Streams[Key] { def use[T](key: Key)(f: TaskStreams[Key] => T): T = { val s = apply(key) s.open() - try { f(s) } finally { s.close() } + try { + f(s) + } finally { + s.close() + } } } trait CloseableStreams[Key] extends Streams[Key] with java.io.Closeable object Streams { private[this] val closeQuietly = (c: Closeable) => - try { c.close() } catch { case _: IOException => () } + try { + c.close() + } catch { case _: IOException => () } def closeable[Key](delegate: Streams[Key]): CloseableStreams[Key] = new CloseableStreams[Key] { private[this] val streams = new collection.mutable.HashMap[Key, ManagedStreams[Key]] @@ -160,7 +166,7 @@ object Streams { new OutputStreamWriter(new FileOutputStream(f), IO.defaultCharset) ) ) - ) + ) ) def binary(sid: String = default): BufferedOutputStream = diff --git a/tasks-standard/src/main/scala/sbt/std/TaskExtra.scala b/tasks-standard/src/main/scala/sbt/std/TaskExtra.scala index 6168332f5..5eba31888 100644 --- a/tasks-standard/src/main/scala/sbt/std/TaskExtra.scala +++ b/tasks-standard/src/main/scala/sbt/std/TaskExtra.scala @@ -168,7 +168,7 @@ trait TaskExtra { x => t.result.map { tx => Result.tryValues[S](tx :: Nil, x) - } + } ) def ||[T >: S](alt: Task[T]): Task[T] = flatMapR { case Value(v) => task(v); case Inc(_) => alt diff --git a/tasks-standard/src/test/scala/TaskGen.scala b/tasks-standard/src/test/scala/TaskGen.scala index ae46b22e6..92d8b29d8 100644 --- a/tasks-standard/src/test/scala/TaskGen.scala +++ b/tasks-standard/src/test/scala/TaskGen.scala @@ -29,7 +29,11 @@ object TaskGen extends std.TaskExtra { Execute.noTriggers, ExecuteProgress.empty[Task] )(std.Transform(dummies)) - try { x.run(root)(service) } finally { shutdown() } + try { + x.run(root)(service) + } finally { + shutdown() + } } def tryRun[T](root: Task[T], checkCycles: Boolean, maxWorkers: Int): T = run(root, checkCycles, maxWorkers) match { diff --git a/tasks-standard/src/test/scala/TaskRunnerCircular.scala b/tasks-standard/src/test/scala/TaskRunnerCircular.scala index e396c5704..532d45173 100644 --- a/tasks-standard/src/test/scala/TaskRunnerCircular.scala +++ b/tasks-standard/src/test/scala/TaskRunnerCircular.scala @@ -27,7 +27,9 @@ object TaskRunnerCircularTest extends Properties("TaskRunner Circular") { else iterate(task(t - 1).named((t - 1).toString)) } - try { checkResult(tryRun(iterate(top), true, workers), intermediate) } catch { + try { + checkResult(tryRun(iterate(top), true, workers), intermediate) + } catch { case i: Incomplete if cyclic(i) => ("Unexpected cyclic exception: " + i) |: false } } @@ -40,7 +42,9 @@ object TaskRunnerCircularTest extends Properties("TaskRunner Circular") { else iterate(task(t - 1).named((t - 1).toString), i - 1) } - try { tryRun(top, true, workers); false } catch { case i: Incomplete => cyclic(i) } + try { + tryRun(top, true, workers); false + } catch { case i: Incomplete => cyclic(i) } } def cyclic(i: Incomplete) = diff --git a/tasks-standard/src/test/scala/TaskSerial.scala b/tasks-standard/src/test/scala/TaskSerial.scala index e48d68c61..a7bf8cbff 100644 --- a/tasks-standard/src/test/scala/TaskSerial.scala +++ b/tasks-standard/src/test/scala/TaskSerial.scala @@ -89,7 +89,11 @@ object TaskTest { Execute.noTriggers, ExecuteProgress.empty[Task] )(taskToNode(idK[Task])) - try { x.run(root)(service) } finally { shutdown() } + try { + x.run(root)(service) + } finally { + shutdown() + } } def tryRun[T]( root: Task[T], diff --git a/tasks-standard/src/test/scala/checkResult.scala b/tasks-standard/src/test/scala/checkResult.scala index ece4657e9..4eb13075d 100644 --- a/tasks-standard/src/test/scala/checkResult.scala +++ b/tasks-standard/src/test/scala/checkResult.scala @@ -15,15 +15,15 @@ object checkResult { def apply[T](run: => T, expected: T) = { ("Expected: " + expected) |: (try { - val actual = run - ("Actual: " + actual) |: (actual == expected) - } catch { - case i: Incomplete => - println(i) - "One or more tasks failed" |: false - case NonFatal(e) => - e.printStackTrace() - "Error in framework" |: false - }) + val actual = run + ("Actual: " + actual) |: (actual == expected) + } catch { + case i: Incomplete => + println(i) + "One or more tasks failed" |: false + case NonFatal(e) => + e.printStackTrace() + "Error in framework" |: false + }) } } diff --git a/tasks/src/main/scala/sbt/CompletionService.scala b/tasks/src/main/scala/sbt/CompletionService.scala index 3b18fe48b..18ed0c481 100644 --- a/tasks/src/main/scala/sbt/CompletionService.scala +++ b/tasks/src/main/scala/sbt/CompletionService.scala @@ -37,15 +37,18 @@ object CompletionService { val future = try completion.submit { new Callable[T] { def call = work() } } catch { case _: RejectedExecutionException => throw Incomplete(None, message = Some("cancelled")) } - () => - future.get() + () => future.get() } def manage[A, T]( service: CompletionService[A, T] )(setup: A => Unit, cleanup: A => Unit): CompletionService[A, T] = wrap(service) { (node, work) => () => setup(node) - try { work() } finally { cleanup(node) } + try { + work() + } finally { + cleanup(node) + } } def wrap[A, T]( service: CompletionService[A, T] diff --git a/tasks/src/main/scala/sbt/Execute.scala b/tasks/src/main/scala/sbt/Execute.scala index ce222b78a..2332441d6 100644 --- a/tasks/src/main/scala/sbt/Execute.scala +++ b/tasks/src/main/scala/sbt/Execute.scala @@ -67,7 +67,7 @@ private[sbt] final class Execute[F[_] <: AnyRef]( view.inline(a) match { case Some(v) => Value(v()) case None => results(a) - } + } ) private[this] type State = State.Value private[this] object State extends Enumeration { @@ -81,7 +81,9 @@ private[sbt] final class Execute[F[_] <: AnyRef]( "State: " + state.toString + "\n\nResults: " + results + "\n\nCalls: " + callers + "\n\n" def run[A](root: F[A])(implicit strategy: Strategy): Result[A] = - try { runKeep(root)(strategy)(root) } catch { case i: Incomplete => Inc(i) } + try { + runKeep(root)(strategy)(root) + } catch { case i: Incomplete => Inc(i) } def runKeep[A](root: F[A])(implicit strategy: Strategy): RMap[F, Result] = { assert(state.isEmpty, "Execute already running/ran.") diff --git a/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala b/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala index de18077fd..e4a744900 100644 --- a/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala +++ b/testing/src/main/scala/sbt/JUnitXmlTestsListener.scala @@ -62,16 +62,16 @@ class JUnitXmlTestsListener(val outputDir: String, logger: Logger) extends Tests val properties = { - // create a clone, defending against [[ConcurrentModificationException]] - val clonedProperties = System.getProperties.clone.asInstanceOf[Hashtable[AnyRef, AnyRef]] - val iter = clonedProperties.entrySet.iterator - val props: ListBuffer[XNode] = new ListBuffer() - while (iter.hasNext) { - val next = iter.next - props += - } - props + // create a clone, defending against [[ConcurrentModificationException]] + val clonedProperties = System.getProperties.clone.asInstanceOf[Hashtable[AnyRef, AnyRef]] + val iter = clonedProperties.entrySet.iterator + val props: ListBuffer[XNode] = new ListBuffer() + while (iter.hasNext) { + val next = iter.next + props += } + props + } /** @@ -104,38 +104,51 @@ class JUnitXmlTestsListener(val outputDir: String, logger: Logger) extends Tests ) val result = - - { properties } + + {properties} { - for (e <- events) yield selector.testName.split('.').last - case nested: NestedTestSelector => nested.suiteId().split('.').last + "." + nested.testName() - case other => s"(It is not a test it is a ${other.getClass.getCanonicalName})" - } - } time={ (e.duration() / 1000.0).toString }> + for (e <- events) + yield + selector.testName.split('.').last + case nested: NestedTestSelector => + nested.suiteId().split('.').last + "." + nested.testName() + case other => s"(It is not a test it is a ${other.getClass.getCanonicalName})" + } + } time={(e.duration() / 1000.0).toString}> { - val trace: String = if (e.throwable.isDefined) { - val stringWriter = new StringWriter() - val writer = new PrintWriter(stringWriter) - e.throwable.get.printStackTrace(writer) - writer.flush() - stringWriter.toString - } else { - "" - } - e.status match { - case TStatus.Error if (e.throwable.isDefined)=> { trace } - case TStatus.Error=> - case TStatus.Failure if (e.throwable.isDefined)=> { trace } - case TStatus.Failure=> - case TStatus.Ignored | TStatus.Skipped | TStatus.Pending=> - case _ => {} - } - } + val trace: String = if (e.throwable.isDefined) { + val stringWriter = new StringWriter() + val writer = new PrintWriter(stringWriter) + e.throwable.get.printStackTrace(writer) + writer.flush() + stringWriter.toString + } else { + "" + } + e.status match { + case TStatus.Error if (e.throwable.isDefined) => + {trace} + case TStatus.Error => + case TStatus.Failure if (e.throwable.isDefined) => + {trace} + case TStatus.Failure => + case TStatus.Ignored | TStatus.Skipped | TStatus.Pending => + case _ => {} + } + } - } + } diff --git a/testing/src/main/scala/sbt/TestFramework.scala b/testing/src/main/scala/sbt/TestFramework.scala index 21df1cc8f..dcaa6c717 100644 --- a/testing/src/main/scala/sbt/TestFramework.scala +++ b/testing/src/main/scala/sbt/TestFramework.scala @@ -272,7 +272,11 @@ object TestFramework { private[this] def withContextLoader[T](loader: ClassLoader)(eval: => T): T = { val oldLoader = Thread.currentThread.getContextClassLoader Thread.currentThread.setContextClassLoader(loader) - try { eval } finally { Thread.currentThread.setContextClassLoader(oldLoader) } + try { + eval + } finally { + Thread.currentThread.setContextClassLoader(oldLoader) + } } @deprecated("1.3.0", "This has been replaced by the ClassLoaders.test task.") def createTestLoader( From 621a72e49a455456c642b449994265c87896ff92 Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Sat, 20 Apr 2019 14:04:54 -0400 Subject: [PATCH 3/3] workaround Scalafmt regex Ref https://github.com/scalameta/scalafmt/issues/1404 --- .scalafmt.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.scalafmt.conf b/.scalafmt.conf index 866ffc284..c9dd647d2 100644 --- a/.scalafmt.conf +++ b/.scalafmt.conf @@ -1,7 +1,7 @@ version = 2.0.0-RC5 maxColumn = 100 project.git = true -project.excludeFilters = [ /sbt-test/, /input_sources/, /contraband-scala/ ] +project.excludeFilters = [ "\\Wsbt-test\\W", "\\Winput_sources\\W", "\\Wcontraband-scala\\W" ] # http://docs.scala-lang.org/style/scaladoc.html recommends the JavaDoc style. # scala/scala is written that way too https://github.com/scala/scala/blob/v2.12.2/src/library/scala/Predef.scala