From f00011c8fdf4c2af6df26f8792b40255e166de12 Mon Sep 17 00:00:00 2001
From: Tomasz Michalak <tmichalak@antmicro.com>
Date: Tue, 1 Dec 2020 15:16:20 +0100
Subject: [PATCH] bitread: Make private members const and add some comments

Signed-off-by: Tomasz Michalak <tmichalak@antmicro.com>
---
 lib/include/prjxray/xilinx/bitstream_reader.h | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/lib/include/prjxray/xilinx/bitstream_reader.h b/lib/include/prjxray/xilinx/bitstream_reader.h
index 094371ad..35224bb9 100644
--- a/lib/include/prjxray/xilinx/bitstream_reader.h
+++ b/lib/include/prjxray/xilinx/bitstream_reader.h
@@ -84,9 +84,9 @@ class BitstreamReader {
 	iterator end();
 
        private:
-	static std::array<uint8_t, 4> kSyncWord;
-	const std::vector<uint32_t> kWcfgCmd = {0x30008001, 0x1};
-	const std::vector<uint32_t> kNullCmd = {0x30008001, 0x0};
+	static const std::array<uint8_t, 4> kSyncWord;
+	static const std::array<uint32_t, 2> kWcfgCmd;
+	static const std::array<uint32_t, 2> kNullCmd;
 
 	std::vector<uint32_t> words_;
 };
@@ -170,9 +170,19 @@ BitstreamReader<ArchType>::InitWithBytes(T bitstream) {
 
 // Sync word as specified in UG470 page 81
 template <typename ArchType>
-std::array<uint8_t, 4> BitstreamReader<ArchType>::kSyncWord{0xAA, 0x99, 0x55,
+const std::array<uint8_t, 4> BitstreamReader<ArchType>::kSyncWord{0xAA, 0x99, 0x55,
                                                             0x66};
 
+// Writing the WCFG(0x1) command in type 1 packet with 1 word to the CMD register (0x30008001)
+// Refer to UG470 page 110
+template <typename ArchType>
+const std::array<uint32_t, 2> BitstreamReader<ArchType>::kWcfgCmd = {0x30008001, 0x1};
+
+// Writing the NULL(0x0) command in type 1 packet with 1 word to the CMD register (0x30008001)
+// Refer to UG470 page 110
+template <typename ArchType>
+const std::array<uint32_t, 2> BitstreamReader<ArchType>::kNullCmd = {0x30008001, 0x0};
+
 template <typename ArchType>
 typename BitstreamReader<ArchType>::iterator
 BitstreamReader<ArchType>::begin() {