From acf7aafce16a7f37e248e1403d8ef01b250116d0 Mon Sep 17 00:00:00 2001 From: Keith Rothman <537074+litghost@users.noreply.github.com> Date: Wed, 20 Feb 2019 14:36:17 -0800 Subject: [PATCH] Save fuzzer logs, even on success. Previous CI logic deleted logs files along with intermediate outputs from fuzzers. This makes debugging issues like #661 harder. Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com> --- .github/kokoro/db-full.sh | 2 +- fuzzers/Makefile | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/kokoro/db-full.sh b/.github/kokoro/db-full.sh index 653988e5..ffad3745 100755 --- a/.github/kokoro/db-full.sh +++ b/.github/kokoro/db-full.sh @@ -154,6 +154,6 @@ echo "----------------------------------------" cd fuzzers echo echo "Cleaning up so CI doesn't save all the excess data." - make clean + make clean_fuzzers ) echo "----------------------------------------" diff --git a/fuzzers/Makefile b/fuzzers/Makefile index a024caf0..b14bc645 100644 --- a/fuzzers/Makefile +++ b/fuzzers/Makefile @@ -11,6 +11,7 @@ FUZZONLY=N BITONLY=N all: +clean: clean_fuzzers clean_logs define fuzzer @@ -21,8 +22,10 @@ define fuzzer all: $(1)/run.ok # Make the clean target run `make clean` in the fuzzer's directory. -clean:: +clean_fuzzers:: $$(MAKE) -C $(1) clean + +clean_logs:: rm -rf $(1)/logs # Describe how to create the fuzzer's run.ok file. @@ -99,3 +102,5 @@ endif quick: $(MAKE) QUICK=Y + +.PHONY: all clean clean_fuzzers clean_logs quick