From 9c4971162ea19b8d2d18717809452d9d5c2f028a Mon Sep 17 00:00:00 2001 From: Herbert Poetzl Date: Wed, 31 Jan 2018 23:53:20 +0100 Subject: [PATCH] Make loop condition more readable Signed-off-by: Herbert Poetzl --- lib/include/prjxray/xilinx/xc7series/crc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/include/prjxray/xilinx/xc7series/crc.h b/lib/include/prjxray/xilinx/xc7series/crc.h index 78785ae0..df6bcac8 100644 --- a/lib/include/prjxray/xilinx/xc7series/crc.h +++ b/lib/include/prjxray/xilinx/xc7series/crc.h @@ -16,12 +16,14 @@ namespace xc7series { // frame data (32bit) pair and return the newly computed CRC value. uint32_t icap_crc(uint32_t addr, uint32_t data, uint32_t prev) { + constexpr int kAddressBitWidth = 5; + constexpr int kDataBitWidth = 32; + uint64_t poly = static_cast(kCrc32CastagnoliPolynomial) << 1; uint64_t val = (static_cast(addr) << 32) | data; uint64_t crc = prev; - constexpr int kFivePlusThrityTwo = 37; - for (int i = 0; i < kFivePlusThrityTwo; i++) { + for (int i = 0; i < kAddressBitWidth + kDataBitWidth; i++) { if ((val & 1) != (crc & 1)) crc ^= poly;