From cb3d5b55e1b480a89c462462d0bb6e119cd89dab Mon Sep 17 00:00:00 2001 From: Patrick Urban Date: Wed, 3 Sep 2025 16:06:09 +0200 Subject: [PATCH] colognechip: remove unnecessary code in `set_quad_bit` and `bulk_erase_flash` --- src/colognechip.cpp | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/src/colognechip.cpp b/src/colognechip.cpp index 6e8c3a1..4b6167e 100644 --- a/src/colognechip.cpp +++ b/src/colognechip.cpp @@ -218,22 +218,11 @@ bool CologneChip::dumpFlash(uint32_t base_addr, uint32_t len) */ bool CologneChip::set_quad_bit(bool set_quad) { - /* prepare SPI access */ - prepare_flash_access(); - - printInfo("Update Quad Enable Bit ", false); - try { - std::unique_ptr flash(_spi ? - new SPIFlash(reinterpret_cast(_spi), false, _verbose): - new SPIFlash(this, false, _verbose)); - flash->set_quad_bit(set_quad); - } catch (std::exception &e) { - printError("Fail"); - printError(std::string(e.what())); + if (!SPIInterface::set_quad_bit(set_quad)) { return false; } - return post_flash_access(); + return true; } /** @@ -241,15 +230,11 @@ bool CologneChip::set_quad_bit(bool set_quad) */ bool CologneChip::bulk_erase_flash() { - /* prepare SPI access */ - prepare_flash_access(); - - printInfo("Bulk Erase ", false); if (!SPIInterface::bulk_erase_flash()) { return false; } - return post_flash_access(); + return true; } /**