From e91ec306bac48a1a0945b5714bf7cd55d9301f8b Mon Sep 17 00:00:00 2001
From: Holger Vogt <holger.vogt@uni-due.de>
Date: Sat, 10 Apr 2021 20:11:47 +0200
Subject: [PATCH] Remove some compiler warnings

---
 src/frontend/nutinp.c        | 2 +-
 src/frontend/outitf.c        | 9 ++++++---
 src/frontend/plotting/pvec.c | 7 +++++--
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/frontend/nutinp.c b/src/frontend/nutinp.c
index 7597dba3b..746605f76 100644
--- a/src/frontend/nutinp.c
+++ b/src/frontend/nutinp.c
@@ -93,7 +93,7 @@ inp_nutsource(FILE *fp, bool comfile, char *filename)
                 ld = dd;
                 continue;
             }
-            (void) strncpy(name, dd->line, BSIZE_SP);
+            (void) strncpy(name, dd->line, BSIZE_SP - 1);
             s = skip_ws(name);
             t = skip_non_ws(s);
             *t = '\0';
diff --git a/src/frontend/outitf.c b/src/frontend/outitf.c
index ce704a66c..ca3bb132b 100644
--- a/src/frontend/outitf.c
+++ b/src/frontend/outitf.c
@@ -246,9 +246,9 @@ beginPlot(JOB *analysisPtr, CKTcircuit *circuitPtr, char *cktName, char *analNam
 
         /* Pass 1. */
         if (numsaves && !saveall) {
-            for (i = 0; i < numsaves; i++)
-                if (!savesused[i])
-                    for (j = 0; j < numNames; j++)
+            for (i = 0; i < numsaves; i++) {
+                if (!savesused[i]) {
+                    for (j = 0; j < numNames; j++) {
                         if (name_eq(saves[i].name, dataNames[j])) {
                             addDataDesc(run, dataNames[j], dataType, j, initmem);
                             savesused[i] = TRUE;
@@ -262,6 +262,9 @@ beginPlot(JOB *analysisPtr, CKTcircuit *circuitPtr, char *cktName, char *analNam
                             saves[i].used = 1;
                             break;
                         }
+                    }
+                }
+            }
         } else {
             for (i = 0; i < numNames; i++)
                 if (!refName || !name_eq(dataNames[i], refName))
diff --git a/src/frontend/plotting/pvec.c b/src/frontend/plotting/pvec.c
index f202a660c..1a5e75a6b 100644
--- a/src/frontend/plotting/pvec.c
+++ b/src/frontend/plotting/pvec.c
@@ -83,8 +83,11 @@ pvec(struct dvec *d)
 
     if (d->v_numdims > 1) {
         dimstring(d->v_dims, d->v_numdims, buf3);
-        size_t icopy = BSIZE_SP - 11;
-        snprintf(buf2, icopy, ", dims = [%s]", buf3);
+        size_t icopy = BSIZE_SP - 1;
+        size_t len = (size_t)snprintf(buf2, icopy, ", dims = [%s]", buf3);
+        if (len > icopy) {
+            fprintf(stderr, "Warning: Potential buffer overflow while setting a vector dimension");
+        }
         strcat(buf, buf2);
     }