From ada71a6ec7f506ff408266e8630bd57b1884f313 Mon Sep 17 00:00:00 2001
From: rlar <rlar>
Date: Sun, 14 Dec 2014 20:58:26 +0100
Subject: [PATCH] inpcom.c, `inp_fix_subckt()', bogus and useless invocation of
 `inp_quote_params()'

---
 src/frontend/inpcom.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/frontend/inpcom.c b/src/frontend/inpcom.c
index c0f9d888e..ec8298fc3 100644
--- a/src/frontend/inpcom.c
+++ b/src/frontend/inpcom.c
@@ -2170,7 +2170,7 @@ inp_fix_subckt(struct names *subckt_w_params, char *s)
             num_params++;
         }
         /* now sort parameters in order of dependencies */
-        inp_sort_params(start_card, head, start_card, end_card);
+        inp_sort_params(start_card, head, NULL, NULL);
 
         /* create new ordered parameter string for subckt call */
         c = head->li_next;
@@ -6114,10 +6114,6 @@ inp_quote_params(struct line *s_c, struct line *e_c, struct dependency *deps, in
         if (in_control || curr_line[0] == '.' || curr_line[0] == '*')
             continue;
 
-/* FIXME: useless and potentially buggy code, when called from line 2225:
-   we check parameters like l={length}, but not complete lines: We just
-   live from the fact, that there are device names for all characters
-   of the alphabet */
         num_terminals = get_number_terminals(curr_line);
 
         if (num_terminals <= 0)
@@ -6126,17 +6122,11 @@ inp_quote_params(struct line *s_c, struct line *e_c, struct dependency *deps, in
         for (i = 0; i < num_params; i++) {
             str_ptr = curr_line;
 
-/* FIXME: useless and potentially buggy code, when called from line 2225:
-   we check parameters like
-   l={length}, but not complete lines: this will always lead to str_ptr = "" */
             for (j = 0; j < num_terminals+1; j++) {
                 str_ptr = skip_non_ws(str_ptr);
                 str_ptr = skip_ws(str_ptr);
             }
 
-/* FIXME: useless and potentially buggy code: we check parameters like
-   l={length}, but the following will not work for such a parameter string.
-   We just live from the fact that str_ptr = "". */
             while ((str_ptr = ya_search_identifier(str_ptr, deps[i].param_name, curr_line)) != NULL) {
                 beg = str_ptr - 1;
                 end = str_ptr + strlen(deps[i].param_name);