From 8bf9a67fc895ed92838f5d0a7aaad60ce2dc646f Mon Sep 17 00:00:00 2001
From: rlar <rlar>
Date: Sun, 14 Dec 2014 16:20:53 +0100
Subject: [PATCH] inpcom.c, cleanup `inp_sort_params()'

---
 src/frontend/inpcom.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/src/frontend/inpcom.c b/src/frontend/inpcom.c
index eb15d8fa5..a7247430a 100644
--- a/src/frontend/inpcom.c
+++ b/src/frontend/inpcom.c
@@ -3722,22 +3722,14 @@ inp_sort_params(struct line *start_card, struct line *end_card, struct line *car
 
     for (i = 0; i < num_params; i++)
         if (!deps[i].skip) {
-            char *param_name = deps[i].param_name;
-            for (j = 0; j < num_params; j++) {
-//        for (j = i + 1; j < num_params; j++) {  /* FIXME: to be tested */
-                if (j == i)
-                    continue;
-
-                if (search_plain_identifier(deps[j].param_str, param_name)) {
+            char *param = deps[i].param_name;
+            for (j = 0; j < num_params; j++)
+                if (j != i && search_plain_identifier(deps[j].param_str, param)) {
                     for (ind = 0; deps[j].depends_on[ind]; ind++)
-                        if (strcmp(param_name, deps[j].depends_on[ind]) == 0)
-                            break;
-                    if (!deps[j].depends_on[ind]) {
-                        deps[j].depends_on[ind++] = param_name;
-                        deps[j].depends_on[ind]   = NULL;
-                    }
+                        ;
+                    deps[j].depends_on[ind++] = param;
+                    deps[j].depends_on[ind]   = NULL;
                 }
-            }
         }
 
     max_level = 0;