From 86264b98796458ffcb5ac57f7ef0ee290a7e524e Mon Sep 17 00:00:00 2001 From: rlar Date: Wed, 17 Jul 2013 21:08:27 +0200 Subject: [PATCH] CKTmodCrt(), cleanup, always assign to `*modfast' for all invocations of CKTmodCrt() alias newModel() the following is true (modfast != NULL) && (*modfast == NULL) see (grep "git --no-pager grep -nH -e 'CKTmodCrt\\|newModel'") --- src/spicelib/analysis/cktmcrt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spicelib/analysis/cktmcrt.c b/src/spicelib/analysis/cktmcrt.c index d682b1aec..4508759d0 100644 --- a/src/spicelib/analysis/cktmcrt.c +++ b/src/spicelib/analysis/cktmcrt.c @@ -30,11 +30,11 @@ CKTmodCrt(CKTcircuit *ckt, int type, GENmodel **modfast, IFuid name) mymodfast->GENmodName = name; mymodfast->GENnextModel = ckt->CKThead[type]; ckt->CKThead[type] = mymodfast; - if(modfast) *modfast=mymodfast; nghash_insert(ckt->MODnameHash, name, mymodfast); + *modfast = mymodfast; return(OK); } else { - if(modfast) *modfast=mymodfast; + *modfast = mymodfast; return(E_EXISTS); } /*NOTREACHED*/