From a0c49a026ad89ee63fbe0b38fc4f00af60f6a144 Mon Sep 17 00:00:00 2001 From: jalcim Date: Sun, 26 Apr 2026 22:06:07 +0200 Subject: [PATCH 1/2] fix(netcmp): correct signal handler type for K&R declaration netcmp.c:55 declares oldinthandler with empty parameter list: void (*oldinthandler)() = SIG_DFL; In K&R / pre-C23, this means 'function with unspecified parameters'. GCC 14+ infers void(*)(void), which is incompatible with signal(2)'s expected void(*)(int) handler. The signal(SIGINT, oldinthandler) calls at lines 8777 and 8784 then fail with -Wincompatible-pointer-types (now a default error in GCC 14+). This 1-line fix matches the actual usage as a SIGINT handler with int signum parameter, and restores tclnetgen.so build on Fedora 41+ / Debian 13+ / Ubuntu 24.04+ (any system with GCC 14+). Tested: tclnetgen.so now builds successfully and 'netgen -batch lvs' mode works again. --- base/netcmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/netcmp.c b/base/netcmp.c index 529b1b9..72f088c 100644 --- a/base/netcmp.c +++ b/base/netcmp.c @@ -52,7 +52,7 @@ the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #ifdef TCL_NETGEN int InterruptPending = 0; -void (*oldinthandler)() = SIG_DFL; +void (*oldinthandler)(int) = SIG_DFL; extern Tcl_Interp *netgeninterp; extern int check_interrupt(); #endif From 8a2bbe0723de52ac5324063cfbc5de8e4cb5bd06 Mon Sep 17 00:00:00 2001 From: "R. Timothy Edwards" Date: Mon, 27 Apr 2026 09:50:37 -0400 Subject: [PATCH 2/2] Updated version to go along with PR #105 from user jalcim on github. --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index b3a4111..8d116e3 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.5.318 +1.5.319