From 2d6f1f71b52f3052e03bdc41220633db542dbb9a Mon Sep 17 00:00:00 2001 From: "D. Mitch Bailey" Date: Thu, 2 Sep 2021 22:29:17 -0700 Subject: [PATCH 1/5] Reduce and clarify debugging message. Add missing new line to "Flattening non-matched subcircuits. --- base/netcmp.c | 4 +++- tcltk/netgen.tcl.in | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/base/netcmp.c b/base/netcmp.c index 5641fea..fbc0353 100644 --- a/base/netcmp.c +++ b/base/netcmp.c @@ -6894,7 +6894,9 @@ int reorderpins(struct hashlist *p, int file) for (ob = ptr->cell; ob != NULL; ) { /* Catch badness */ if (ob->next && (ob->next->node > 100000)) { - Fprintf(stdout, "Bad.\n"); + if (ob->next->node % 100000 == 0) { + Fprintf(stdout, "Bad node. Node count %d\n", ob->next->node); + } } if (ob->type == FIRSTPIN) { diff --git a/tcltk/netgen.tcl.in b/tcltk/netgen.tcl.in index 2bd2e8e..dcfa8a3 100644 --- a/tcltk/netgen.tcl.in +++ b/tcltk/netgen.tcl.in @@ -562,7 +562,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} { if {[netgen::print queue] != {}} { if {([lsearch $noflat [lindex $endval 0]] == -1) && ([lsearch $noflat [lindex $endval 1]] == -1)} { - netgen::log put " Flattening non-matched subcircuits $endval" + netgen::log put " Flattening non-matched subcircuits $endval\n" netgen::flatten class "[lindex $endval 0] $fnum1" netgen::flatten class "[lindex $endval 1] $fnum2" } else { From a05ede99db5b3ddfcd0661bfdaf45078457e66f8 Mon Sep 17 00:00:00 2001 From: "D. Mitch Bailey" Date: Mon, 6 Sep 2021 18:31:38 -0700 Subject: [PATCH 2/5] Added missing newlines Print debug message every 100 lines --- base/netcmp.c | 4 ++-- tcltk/netgen.tcl.in | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/base/netcmp.c b/base/netcmp.c index fbc0353..789de13 100644 --- a/base/netcmp.c +++ b/base/netcmp.c @@ -6893,8 +6893,8 @@ int reorderpins(struct hashlist *p, int file) for (ob = ptr->cell; ob != NULL; ) { /* Catch badness */ - if (ob->next && (ob->next->node > 100000)) { - if (ob->next->node % 100000 == 0) { + if (ob->next && (ob->next->node > 99999)) { + if (ob->next->node % 100 == 0) { /* print once every 100 nodes over 100000 */ Fprintf(stdout, "Bad node. Node count %d\n", ob->next->node); } } diff --git a/tcltk/netgen.tcl.in b/tcltk/netgen.tcl.in index dcfa8a3..7c2e1e4 100644 --- a/tcltk/netgen.tcl.in +++ b/tcltk/netgen.tcl.in @@ -566,7 +566,7 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} { netgen::flatten class "[lindex $endval 0] $fnum1" netgen::flatten class "[lindex $endval 1] $fnum2" } else { - netgen::log put " Continuing with black-boxed subcircuits $endval" + netgen::log put " Continuing with black-boxed subcircuits $endval\n" lappend matcherr [lindex $endval 0] # Match pins netgen::log echo off @@ -611,13 +611,13 @@ proc netgen::lvs { name1 name2 {setupfile setup.tcl} {logfile comp.out} args} { if {[netgen::print queue] != {}} { if {([lsearch $noflat [lindex $endval 1]] == -1) && ([lsearch $noflat [lindex $endval 1]] == -1)} { - netgen::log put " Flattening non-matched subcircuits $endval" + netgen::log put " Flattening non-matched subcircuits $endval\n" netgen::flatten class "[lindex $endval 0] $fnum1" netgen::flatten class "[lindex $endval 1] $fnum2" } else { - netgen::log put " Continuing with black-boxed subcircuits $endval" + netgen::log put " Continuing with black-boxed subcircuits $endval\n" lappend matcherr [lindex $endval 0] - netgen::log put " Continuing with black-boxed subcircuits $endval" + netgen::log put " Continuing with black-boxed subcircuits $endval\n" lappend matcherr [lindex $endval 0] # Match pins netgen::log echo off From df1c4c5153a1460c34f3cacc4b3a98e824a2a92b Mon Sep 17 00:00:00 2001 From: "D. Mitch Bailey" Date: Tue, 7 Sep 2021 10:19:27 -0700 Subject: [PATCH 3/5] Changed debug print increment from 100 -> 10000. --- base/netcmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/netcmp.c b/base/netcmp.c index 789de13..aec25fd 100644 --- a/base/netcmp.c +++ b/base/netcmp.c @@ -6894,7 +6894,7 @@ int reorderpins(struct hashlist *p, int file) for (ob = ptr->cell; ob != NULL; ) { /* Catch badness */ if (ob->next && (ob->next->node > 99999)) { - if (ob->next->node % 100 == 0) { /* print once every 100 nodes over 100000 */ + if (ob->next->node % 10000 == 0) { /* print once every 10000 nodes over 100000 */ Fprintf(stdout, "Bad node. Node count %d\n", ob->next->node); } } From 1338e3beb56b96e08cee3adf75d07da15313785f Mon Sep 17 00:00:00 2001 From: "D. Mitch Bailey" Date: Tue, 7 Sep 2021 19:16:33 -0700 Subject: [PATCH 4/5] Removed debugging statement. --- base/netcmp.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/base/netcmp.c b/base/netcmp.c index aec25fd..38444d1 100644 --- a/base/netcmp.c +++ b/base/netcmp.c @@ -6892,13 +6892,6 @@ int reorderpins(struct hashlist *p, int file) "Ordering will be arbitrary.\n", tc2->name); for (ob = ptr->cell; ob != NULL; ) { - /* Catch badness */ - if (ob->next && (ob->next->node > 99999)) { - if (ob->next->node % 10000 == 0) { /* print once every 10000 nodes over 100000 */ - Fprintf(stdout, "Bad node. Node count %d\n", ob->next->node); - } - } - if (ob->type == FIRSTPIN) { if ((*matchfunc)(ob->model.class, tc2->name)) { char *sptr = ob->instance.name; From 18dcac73bcb10455475826facbfdb4c25ce1a951 Mon Sep 17 00:00:00 2001 From: Tim Edwards Date: Tue, 7 Sep 2021 22:27:31 -0400 Subject: [PATCH 5/5] Updated version to go along with the merge of pull request #31 from Mitch Bailey. --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 3cd6538..af72c96 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.5.201 +1.5.202