From f69b02b092fbbd9eaac7092548028d87b045d871 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Sun, 29 Sep 2024 23:00:00 +0100 Subject: [PATCH] sim/SimExtract.c: extEnumTilePerim() Call to function with fewer arguments than declared parameters This is a complete guess based on function parameter types and the locallity of the 'pNum' value. This error predates the 2017 Initial Commit git history. Copilot Autofix rejected: extEnumTilePerim(tile, devptr->exts_deviceSDTypes[i], SimTransTerms, (ClientData) &transistor, (ClientData) NULL ); CodeQL: https://github.com/dlmiles/magic/security/code-scanning/26 --- sim/SimExtract.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/SimExtract.c b/sim/SimExtract.c index 417c9879..eb7f0981 100644 --- a/sim/SimExtract.c +++ b/sim/SimExtract.c @@ -486,7 +486,7 @@ SimTransistorTile(tile, pNum, arg) devptr = ExtCurStyle->exts_device[t]; for (i = 0; !TTMaskHasType(&devptr->exts_deviceSDTypes[i], TT_SPACE); i++) - extEnumTilePerim(tile, devptr->exts_deviceSDTypes[i], + extEnumTilePerim(tile, devptr->exts_deviceSDTypes[i], pNum, SimTransTerms, (ClientData) &transistor ); }