From bd03a550d372903d22724ec4b00aca1818d36f76 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Fri, 4 Oct 2024 12:16:10 +0100 Subject: [PATCH] CmdCD.c: DBOrientUse() called with too many arguments. Comment added to come back to later. DBOrientUse(cellname, dodef/*, orient*/); --- commands/CmdCD.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/commands/CmdCD.c b/commands/CmdCD.c index 3b029218..5d8f7d46 100644 --- a/commands/CmdCD.c +++ b/commands/CmdCD.c @@ -1633,7 +1633,14 @@ CmdCellname( TxError("Cannot set orientation by name. Use selection.\n"); break; } - DBOrientUse(cellname, dodef, orient); + /* FIXME reading the function documentation above DBOrientUse() this method + * is only used to report orientation. The selection interface should be + * used to change orientation. Which is conveyed in the TxError() above. + * So the 3rd argument here does not do anything. + * Maybe the intention here is to display the current orientation, if so + * please remove this comment and the extra argument 'orient' below. + */ + DBOrientUse(cellname, dodef/*, orient*/); break; case IDX_ABUTMENT: DBAbutmentUse(cellname, dolist);