From ba2db7bbd35625ec44498e01bd17490ac8521411 Mon Sep 17 00:00:00 2001
From: Tim Edwards <tim@opencircuitdesign.com>
Date: Wed, 28 Mar 2018 12:09:19 -0400
Subject: [PATCH] Option "ext2spice subcircuit top" was implemented wrong and
 would cause a crash.  Corrected the implementation as well as implemented an
 option for "subcircuit top auto" that generates a subcircuit header or not
 depending on the presence or absense of ports in the top level cell.

---
 ext2spice/ext2hier.c  | 22 ++++++++++++++++++++--
 ext2spice/ext2spice.c |  6 ------
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/ext2spice/ext2hier.c b/ext2spice/ext2hier.c
index fb9386bf..4c8de5d5 100644
--- a/ext2spice/ext2hier.c
+++ b/ext2spice/ext2hier.c
@@ -1787,8 +1787,26 @@ esHierVisit(hc, cdata)
 	fprintf(esSpiceF, "* Black-box entry subcircuit for %s abstract view\n",
 		def->def_name);
 
+    /* Automatic subcircuit handling for top level:  Check if the top	*/
+    /* level has any ports defined.  If so, make a subcircuit record	*/
+    /* for it.  If not, don't.						*/
+
+    if ((def == topdef) && (locDoSubckt == AUTO))
+    {
+	/* Determine if there are ports */
+	locDoSubckt = FALSE;
+	for (snode = (EFNode *) def->def_firstn.efnode_next;
+			snode != &def->def_firstn;
+			snode = (EFNode *) snode->efnode_next)
+	    if (snode->efnode_flags & (EF_PORT | EF_SUBS_PORT))
+	    {
+		locDoSubckt = TRUE;
+		break;
+	    }
+    }
+
     /* Generate subcircuit header */
-    if ((def != topdef) || (def->def_flags & DEF_SUBCIRCUIT))
+    if ((def != topdef) || (def->def_flags & DEF_SUBCIRCUIT) || (locDoSubckt == TRUE))
 	topVisit(def, doStub);
     else
 	fprintf(esSpiceF, "\n* Top level circuit %s\n\n", topdef->def_name);
@@ -1835,7 +1853,7 @@ esHierVisit(hc, cdata)
 	}
     }
 
-    if ((def != topdef) || (def->def_flags & DEF_SUBCIRCUIT))
+    if ((def != topdef) || (def->def_flags & DEF_SUBCIRCUIT) || (locDoSubckt == TRUE))
 	fprintf(esSpiceF, ".ends\n\n");
     else
 	fprintf(esSpiceF, ".end\n\n");
diff --git a/ext2spice/ext2spice.c b/ext2spice/ext2spice.c
index 6350bbd8..32a4ecf6 100644
--- a/ext2spice/ext2spice.c
+++ b/ext2spice/ext2spice.c
@@ -845,13 +845,7 @@ runexttospice:
     locDoSubckt = FALSE;
     if (esDoHierarchy)
     {
-	if ((esDoSubckt == TRUE) || (locDoSubckt == TRUE))
-	    topVisit(efFlatRootDef, FALSE);
-
 	ESGenerateHierarchy(inName, flatFlags);
-
-	if ((esDoSubckt == TRUE) || (locDoSubckt == TRUE))
-	    fprintf(esSpiceF, ".ends\n");
     }
     else
     {