From 686adc13b3703f6df856cb2bd18113cbfcef8255 Mon Sep 17 00:00:00 2001 From: "Darryl L. Miles" Date: Fri, 31 Jan 2025 16:09:00 +0000 Subject: [PATCH] tiles: unclear why TileStoreFreeList is an exported global Looks private internal implementation detail that may benefit from compiler single compile unit optimisations. --- tiles/tile.c | 4 ++-- tiles/tile.h | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/tiles/tile.c b/tiles/tile.c index dd779e44..6f846153 100644 --- a/tiles/tile.c +++ b/tiles/tile.c @@ -61,8 +61,8 @@ global const Rect TiPlaneRect = { {MINFINITY+2, MINFINITY+2}, {INFINITY-2, INFIN #ifdef HAVE_SYS_MMAN_H -global Tile *TileStoreFreeList = NULL; -global Tile *TileStoreFreeList_end = NULL; +static Tile *TileStoreFreeList = NULL; +static Tile *TileStoreFreeList_end = NULL; /* The new Tile Allocation scheme (Magic 8.0) */ diff --git a/tiles/tile.h b/tiles/tile.h index d621a41a..4208f270 100644 --- a/tiles/tile.h +++ b/tiles/tile.h @@ -85,9 +85,6 @@ typedef Tile *TileStore; /* Page size is 4KB so we mmap a segment equal to 64 pages */ #define TILE_STORE_BLOCK_SIZE (4 * 1024 * 64) -extern Tile *TileStoreFreeList; -extern Tile *TileStoreFreeList_end; - #endif /* HAVE_SYS_MMAN_H */ #define BOTTOM(tp) ((tp)->ti_ll.p_y)