From 4ea0f6a9b75fa6e7b7484464fc5198eb5ada9506 Mon Sep 17 00:00:00 2001
From: "Darryl L. Miles" <darryl.miles@darrylmiles.org>
Date: Fri, 4 Oct 2024 16:01:27 +0100
Subject: [PATCH] DBcellcopy.c: fix warning: self-comparison always evaluates
 to false

Looks like a straighforward logic bug from a recent (2023) change.

GCC14 -Wall cleanup series [-Wtautological-compare]
---
 database/DBcellcopy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/database/DBcellcopy.c b/database/DBcellcopy.c
index d253ea08..3a173c6b 100644
--- a/database/DBcellcopy.c
+++ b/database/DBcellcopy.c
@@ -666,7 +666,7 @@ DBFlattenInPlace(use, dest, xMask, dolabels, toplabels, doclear)
 		scx.scx_y++;
 		scx.scx_x = use->cu_xlo;
 	    }
-	    else if (use->cu_yhi > use->cu_yhi)
+	    else if (use->cu_ylo > use->cu_yhi)
 	    {
 		scx.scx_y--;
 		scx.scx_x = use->cu_xlo;