From 291ba96285bcd7c2176f95229fc540bd88a25b88 Mon Sep 17 00:00:00 2001 From: Tim Edwards Date: Mon, 13 May 2024 21:51:59 -0400 Subject: [PATCH] Corrected a bad statement running Tcl_NewListObj() that fails to assign the result to anything, causing later uses of variable "lobj" to have an unitialized value and potentially causing a crash condition. Thanks to Risto Bell for pointing out the error. --- VERSION | 2 +- commands/CmdRS.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/VERSION b/VERSION index ad84a18e..97d9b26a 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -8.3.482 +8.3.483 diff --git a/commands/CmdRS.c b/commands/CmdRS.c index bda7d9c9..9f06c33c 100644 --- a/commands/CmdRS.c +++ b/commands/CmdRS.c @@ -2338,8 +2338,7 @@ CmdSetLabel(w, cmd) if (locargc == 2) { #ifdef MAGIC_WRAPPER - Tcl_Obj *lobj; - Tcl_NewListObj(0, NULL); + lobj = Tcl_NewListObj(0, NULL); Tcl_ListObjAppendElement(magicinterp, lobj, Tcl_NewIntObj(DefaultLabel->lab_offset.p_x)); Tcl_ListObjAppendElement(magicinterp, lobj,